X2Go Bug report logs -
#668
[Patch] Replace "echo -n" with printf
Reported by: Lars Wendler <polynomial-c@gentoo.org>
Date: Fri, 7 Nov 2014 16:05:01 UTC
Severity: important
Tags: patch, pending
Fixed in version 4.0.1.19
Done: X2Go Release Manager <git-admin@x2go.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>
:
Bug#668
; Package x2goclient
.
(Fri, 07 Nov 2014 16:05:01 GMT) (full text, mbox, link).
Acknowledgement sent
to Lars Wendler <polynomial-c@gentoo.org>
:
New Bug report received and forwarded. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>
.
Your message had a Version: pseudo-header with an invalid package
version:
git master
please either use found or fixed to the control server with a correct
version, or reply to this report indicating the correct version so the
maintainer (or someone else) can correct it for you.
(Fri, 07 Nov 2014 16:05:01 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: git master
Hi,
at Gentoo latest version of the dash shell doesn't support "echo -n"
anymore[1]. The result is that x2gpath returns every path with a
prefixed "-n " when dash is used as /bin/sh.
Accoring to "man p1 echo" section "APPLICATION USAGE" applications
should not rely on "echo -n" but use printf instead.
The attached patch does exactly that.
Kind regards
Lars
[1] https://bugs.gentoo.org/528452
--
Lars Wendler
Gentoo package maintainer
GPG: 4DD8 C47C CDFA 5295 E1A6 3FC8 F696 74AB 981C A6FC
[0001-echo-n-cannot-be-expected-to-work-with-every-POSIX-s.patch (text/x-patch, attachment)]
[Message part 3 (application/pgp-signature, inline)]
Information forwarded
to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>
:
Bug#668
; Package x2goclient
.
(Fri, 07 Nov 2014 21:00:01 GMT) (full text, mbox, link).
Acknowledgement sent
to Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>
.
(Fri, 07 Nov 2014 21:00:02 GMT) (full text, mbox, link).
Message #10 received at 668@bugs.x2go.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Control: reassign -1 x2goserver
Control: tag -1 patch
Control: severity -1 important
Hi Lars,
On Fr 07 Nov 2014 16:51:42 CET, Lars Wendler wrote:
> Package: x2goclient
> Version: git master
>
>
> Hi,
>
> at Gentoo latest version of the dash shell doesn't support "echo -n"
> anymore[1]. The result is that x2gpath returns every path with a
> prefixed "-n " when dash is used as /bin/sh.
> Accoring to "man p1 echo" section "APPLICATION USAGE" applications
> should not rely on "echo -n" but use printf instead.
> The attached patch does exactly that.
>
> Kind regards
> Lars
>
> [1] https://bugs.gentoo.org/528452
I will apply your patch ASAP. You made a valid point!
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]
Bug reassigned from package 'x2goclient' to 'x2goserver'.
Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
to 668-submit@bugs.x2go.org
.
(Fri, 07 Nov 2014 21:00:02 GMT) (full text, mbox, link).
Added tag(s) patch.
Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
to 668-submit@bugs.x2go.org
.
(Fri, 07 Nov 2014 21:00:02 GMT) (full text, mbox, link).
Severity set to 'important' from 'normal'
Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
to 668-submit@bugs.x2go.org
.
(Fri, 07 Nov 2014 21:00:02 GMT) (full text, mbox, link).
Information forwarded
to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>
:
Bug#668
; Package x2goserver
.
(Fri, 28 Nov 2014 04:20:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>
.
(Fri, 28 Nov 2014 04:20:02 GMT) (full text, mbox, link).
Message #21 received at 668@bugs.x2go.org (full text, mbox, reply):
tag #668 pending
fixed #668 4.0.1.19
thanks
Hello,
X2Go issue #668 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=8cb97ab
The issue will most likely be fixed in src:x2goserver (4.0.1.19).
light+love
X2Go Git Admin (on behalf of the sender of this mail)
---
commit 8cb97ab3cc698ecb24002fdd3cff83964efcbf54
Author: Lars Wendler <polynomial-c@gentoo.org>
Date: Fri Nov 28 05:13:55 2014 +0100
Use "printf" instead of "echo -n". (Fixes: #668).
diff --git a/debian/changelog b/debian/changelog
index 0b65e2f..7723cbd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -88,6 +88,10 @@ x2goserver (4.0.1.19-0x2go1) UNRELEASED; urgency=medium
only capture the file descriptor backreference in the regex and
send any close failures to syslog. (Fixes: #678).
+ [ Lars Wendler ]
+ * New upstream version (4.0.1.19):
+ - Use "printf" instead of "echo -n". (Fixes: #668).
+
-- Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Tue, 07 Oct 2014 15:35:38 +0200
x2goserver (4.0.1.18-0x2go1) unstable; urgency=medium
Added tag(s) pending.
Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
to control@bugs.x2go.org
.
(Fri, 28 Nov 2014 04:20:03 GMT) (full text, mbox, link).
Marked as fixed in versions 4.0.1.19.
Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
to control@bugs.x2go.org
.
(Fri, 28 Nov 2014 04:20:03 GMT) (full text, mbox, link).
Message sent on
to Lars Wendler <polynomial-c@gentoo.org>
:
Bug#668.
(Fri, 28 Nov 2014 04:20:03 GMT) (full text, mbox, link).
Information forwarded
to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>
:
Bug#668
; Package x2goserver
.
(Tue, 24 Feb 2015 20:55:58 GMT) (full text, mbox, link).
Acknowledgement sent
to X2Go Release Manager <git-admin@x2go.org>
:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>
.
(Tue, 24 Feb 2015 20:55:59 GMT) (full text, mbox, link).
Message #33 received at 668@bugs.x2go.org (full text, mbox, reply):
close #668
thanks
Hello,
we are very hopeful that X2Go issue #668 reported by you
has been resolved in the new release (4.0.1.19) of the
X2Go source project »src:x2goserver«.
You can view the complete changelog entry of src:x2goserver (4.0.1.19)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goserver.
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=49c91751e560ad09ab4490cc3bd6687509c05755;hp=724d2eefe399485a71e79c705a0aad125e853230
If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goserver.
Thanks a lot for contributing to X2Go!!!
light+love
X2Go Git Admin (on behalf of the sender of this mail)
---
X2Go Component: src:x2goserver
Version: 4.0.1.19-0x2go1
Status: RELEASE
Date: Tue, 24 Feb 2015 21:49:22 +0100
Fixes: 405 632 633 638 644 664 668 671 672 675 676 678 697 698 700 712 715 727 728 770
Changes:
x2goserver (4.0.1.19-0x2go1) RELEASED; urgency=medium
.
[ Mike Gabriel ]
* New upstream version (4.0.1.19):
- Use File::Which to detect if sshfs command is available
before trying to mount a client-side folder.
- Be a bit more tolerant when trying to detect if a
desktop icon is to be removed (using regexp, not
eq).
- Xsession script: Prevent bash failures when sourcing external bash
scripts beyond our scope. (Fixes: #632, #675).
- x2gogetapps: Support scanning of sub-directories when searching for
.desktop files. We allow to dive down one level into subdirs, we on
purpose do not recursively dive into the complete subtree. (Fixes: #633).
- Make man2html an optional tool. Don't fail if it is missing on the
build system (required for openSUSE/SLES builds).
- Fix x2goserver-xsession/Makefile on SUSE. Detect SUSE distro and create
Xsession related directory symlinks (xinitrc.d and Xclients.d).
- Hack for x2goserver-xsession/Makefile during SUSE builds. If
directoy /usr/share/doc/packages/brp-check-suse is present, the build env
is also considered to be a SUSE system.
- Trigger Xsession code for SUSE systems (look for /etc/SUSE-brand or
/etc/SuSE-release for SUSE system recognition). (Fixes: #671).
- x2gosqlitewrapper.c: Fix rpmlint error: no-return-in-nonvoid-function.
Return the exitcode of execve().
- Fix gramma in error message (in x2goresume-session).
- x2gocleansessions: Call x2gormforward also on terminated sessions. This
will make sure that re-assigned ports are really available on new session
startup.
- x2golistsessions(_root): Only update session state in session DB if
x2goagent's state file really exists. This addresses a problem that occurs
when x2golistsessions gets called via an x2gobroker-agent. The
x2golistsessions script may show session states (--all-servers) of
sessions on other servers that have session states files on their remote
/tmp dirs. These files are not accessible for that x2golistsessions script
and should simply be ignored. (Fixes: #638).
- Provide pam_namespace support for has_agent_state_file() function.
- Fix missing session list output if state file does not exist on the
machine that runs x2golistsessions(_root).
- Accept more verbose "DENY" output from x2godesktopsharing.
- Make sure that all "su"-to-user-contexts use /bin/sh for wrapping around
the executed command (in x2gocleansessions and x2golistsessions_root).
- Also enforce /bin/sh as shell in su command in x2goprint.
- README.i18n: Add file that explains the translation workflow for
this package. Thanks to Mark Pedersen-Cook for drafting this file.
- Make SSH agent forwarding work after having reconnected via SSH and
having resumed a session. (Fixes: #672). Thanks to Robert Siemer for
coming up with that idea.
- Fix cross-user X2Go Desktop Sharing after being broken by implementing
clipboard mode feature (and probably other code changes).
- Document session startup / resumption failures (and their reasons) in
server-side log output.
- Handle AD domain users gracefully when X2Go is used with SQLite DB
backend. (Fixes: #664).
- Improve sanitizer, use 'x2gosid' sanitizer for session IDs everywhere.
Drop unused 'pnixusername' sanitizer in 4.0.1.x release of X2Go Server.
- Allow usernames in session IDs of length 48 chars.
- Start sshfs with a timeout of 30 seconds (because it never finishes if
something is wrong with the client-side TCP socket). Also remove/unmount
mountpoints erroneously registered sshfs mountpoints if sshfs command
times out. Furthermore, print errors to STDERR (not STDOUT). (Fixes:
#405).
- Handle execution of ss command from Perl script x2golistdesktops in a way
that not only works on Debian, but also on Fedora et al. (Fixes: #727).
- Provide legacy support for old File::Path packages in x2godbadmin.
(Fixes: #715).
- Fix wrong evocation of x2gosyslog ("error" -> "err").
- Use "undef $dbh" instead of "$dbh->disconnect()". Fixes SQLite3 issues on
SLE 11.x.
- Only call $dbh->sqlite_busy_timeout() if the $dbh object is capable of
that. Works around a too-old DBD::SQLite package on SLE 11.x.
- Legacy for applications (and X2Go scripts) that expect $SSH_CLIENT to be
set in the X2Go session's environment. (Fixes: #644).
- Add man page for x2gogetapps. Weave into that a security / disclaimer
message as proposed by Stefan Baur. (Fixes: #728).
* debian/control:
+ Add D (x2goserver): libfile-which-perl.
+ Add C (x2goserver: x2godesktopsharing (<< 3.1.1.2-0~). (Fixes: #700).
+ Bump Standards: to 3.9.6. No changes needed.
+ Don't depend on libdb-pg-perl for armhf builds. (Fixes: #712). Thanks to
Heinrich Schuchardt for providing information on this.
+ Upgrade to D again (bin:package x2goserver): xfonts-base (Fixes: #770).
* debian/x2goserver.docs:
+ Install README.i18n file into bin:package x2goserver.
* x2goserver.spec:
+ Add to R: perl(File::Which).
+ Additionally adapt to building on openSUSE/SLES.
+ No shell expansion possible in obs-build, detect perl version only for
non-SUSE builds.
+ Add to R: x2goserver-xsession.
+ Don't mention /etc/x2go/x2gosql/sql twice (directly and with wildcard).
+ No %{_sysconfdir}/x2go/Xclients.d on SUSE systems.
+ Use %{_localstatedir} instead of %{_sharedstatedir}.
+ Use proper if... then... clauses.
+ For SUSE builds: Add to R: shadow (useradd, groupadd).
+ Replace historical "egrep" with "grep -E".
+ Systemd support for SUSE >= 12.10.
+ Set %defattr macro for every bin:package.
+ SUSE and Fedora/RHEL have different package group names.
+ Add x2goserver-rpmlintrc file to handle some rpmlint errors and warnings.
+ SUSE has openssh, but no openssh-server.
+ Add to R (x2goserver): perl-X2Go-Server.
+ Add to R (diverse): perl(Config::Simple), perl(Switch) and
perl(Capture::Tiny).
+ Add to R (x2goserver): perl(File::BaseDir).
+ Don't hard-code /var/lib/ in $HOME path of to-be-created user
"x2gouser".
+ Add to BR: findutils.
+ For Fedora-like systems, don't make x2goserver bin:package authoritative
for non-X2Go directories. (Fixes: #676).
+ Remove macro call %systemd_pre for Fedora/EPEL-7 builds. No such macro in
Fedora/RHEL7. (Fixes: 698).
+ Create system user x2gouser with $HOME in /var/lib/x2go. (Fixes: #697).
+ Always set BuildRoot: parameter.
+ BuildRequires: SUSE <= 11.3 has xorg-x11, not xinit.
+ Requires (x2goserver-xsession): SUSE <= 11.3 has xorg-x11, not xinit.
+ No Bashisms in scriptlets.
+ rpmlint requires shared-mime-info at build time on SLE <= 11.3.
+ "%set_permissions" / "%verify_permissions" macros are not know in SLE <=
11.3. Using "%run permissions" and "%verify permissions" instead.
+ On SUSE, add permissions.d/x2goserver.
+ Fix SQLite wrapper permissions (02775 -> 02755)
+ Use if then clauses for creating user/group x2goprint.
.
[ Matthew L. Dailey ]
* New upstream version (4.0.1.19):
- x2gocleansessions: Redirect stdin, stdout and stderr to /dev/null, test
for the existence of the file descriptor before issuing the close,
only capture the file descriptor backreference in the regex and
send any close failures to syslog. (Fixes: #678).
.
[ Lars Wendler ]
* New upstream version (4.0.1.19):
- Use "printf" instead of "echo -n". (Fixes: #668).
Marked Bug as done
Request was from X2Go Release Manager <git-admin@x2go.org>
to control@bugs.x2go.org
.
(Tue, 24 Feb 2015 20:56:05 GMT) (full text, mbox, link).
Notification sent
to Lars Wendler <polynomial-c@gentoo.org>
:
Bug acknowledged by developer.
(Tue, 24 Feb 2015 20:56:05 GMT) (full text, mbox, link).
Message sent on
to Lars Wendler <polynomial-c@gentoo.org>
:
Bug#668.
(Tue, 24 Feb 2015 20:56:21 GMT) (full text, mbox, link).
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.x2go.org>
to internal_control@bugs.x2go.org
.
(Wed, 25 Mar 2015 06:24:02 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
X2Go Developers <owner@bugs.x2go.org>.
Last modified:
Wed Oct 30 12:56:31 2024;
Machine Name:
ymir.das-netzwerkteam.de
X2Go Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.