X2Go Bug report logs - #668
[Patch] Replace "echo -n" with printf

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Lars Wendler <polynomial-c@gentoo.org>

Date: Fri, 7 Nov 2014 16:05:01 UTC

Severity: important

Tags: patch, pending

Fixed in version 4.0.1.19

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#668: [X2Go-Dev] Bug#668: [Patch] Replace "echo -n" with printf
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 668@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Fri, 07 Nov 2014 21:00:01 +0000
Resent-Message-ID: <handler.668.B668.14153937644486@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 668
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 668-submit@bugs.x2go.org id=B668.14153937644486
          (code B ref 668); Fri, 07 Nov 2014 21:00:01 +0000
Received: (at 668) by bugs.x2go.org; 7 Nov 2014 20:56:04 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id DC3705DEA7
	for <668@bugs.x2go.org>; Fri,  7 Nov 2014 21:56:03 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 56B0021B4;
	Fri,  7 Nov 2014 21:56:03 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id E9FA03BC2A;
	Fri,  7 Nov 2014 21:56:02 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id lrD9hIEiiuLL; Fri,  7 Nov 2014 21:56:02 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 9CD483BA01;
	Fri,  7 Nov 2014 21:56:02 +0100 (CET)
Received: from p5B3B9A55.dip0.t-ipconnect.de (p5B3B9A55.dip0.t-ipconnect.de
 [91.59.154.85]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Fri, 07 Nov 2014 20:56:02 +0000
Date: Fri, 07 Nov 2014 20:56:02 +0000
Message-ID: <20141107205602.Horde.cGVPKzbnxm1YpRM8Ba8EcQ1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Lars Wendler <polynomial-c@gentoo.org>, 668@bugs.x2go.org
In-Reply-To: <20141107165142.7acf1f19@shanghai.paradoxon.rec>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 91.59.154.85
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_PRbBrrm3nhRElelOFqIpJw2";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Control: reassign -1 x2goserver
Control: tag -1 patch
Control: severity -1 important

Hi Lars,

On  Fr 07 Nov 2014 16:51:42 CET, Lars Wendler wrote:

> Package: x2goclient
> Version: git master
>
>
> Hi,
>
> at Gentoo latest version of the dash shell doesn't support "echo -n"
> anymore[1]. The result is that x2gpath returns every path with a
> prefixed "-n " when dash is used as /bin/sh.
> Accoring to "man p1 echo" section "APPLICATION USAGE" applications
> should not rely on "echo -n" but use printf instead.
> The attached patch does exactly that.
>
> Kind regards
> Lars
>
> [1] https://bugs.gentoo.org/528452

I will apply your patch ASAP. You made a valid point!

Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Apr 20 10:23:08 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.