X2Go Bug report logs - #1118
Share folder is broken for x2goclient-4.0.5.2-2016.09.20-setup.exe

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Michael <ayuanx@gmail.com>

Date: Tue, 29 Nov 2016 05:00:02 UTC

Severity: normal

Tags: build-win32, pending

Merged with 1105, 1110, 1114, 1115, 1128, 1150

Found in version 4.0.5.2

Fixed in version 4.1.0.0

Full log


Message #12 received at 1118@bugs.x2go.org (full text, mbox, reply):

Received: (at 1118) by bugs.x2go.org; 29 Nov 2016 17:47:54 +0000
From ionic@ionic.de  Tue Nov 29 18:47:51 2016
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 7DCDA3BC8A
	for <1118@bugs.x2go.org>; Tue, 29 Nov 2016 18:47:51 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id KJNACi15P-vl for <1118@bugs.x2go.org>;
	Tue, 29 Nov 2016 18:47:44 +0100 (CET)
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 8C4623BC7D
	for <1118@bugs.x2go.org>; Tue, 29 Nov 2016 18:47:44 +0100 (CET)
Received: from nopileos.local (178.162.222.41.adsl.inet-telecom.org [178.162.222.41])
	by mail.ionic.de (Postfix) with ESMTPSA id DA0954F00066;
	Tue, 29 Nov 2016 18:47:43 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1480441664; bh=JnHK7Y0WwqDIWU8XAeM/RU+RmYImRnopnjZ1NUMHzuA=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=HJ51cUJ7cDt8tm+BAEIReUzUXF2zA+Eyr1PiMQqxycvkIniA2qOt+5TKwRKBzmCL6
	 Y5ehTYj7NFrs3BC5PIMvI/jGJrcd1rtgx1NIEG+OVkV7xLCwLh52ygi4WJskfwTsbs
	 NxOalvnzi3CD7eWiRVdlG1z0PlFeh3C3deS25Z7w=
Subject: Re: [X2Go-Dev] Share folder is broken for
 x2goclient-4.0.5.2-2016.09.20-setup.exe
To: Michael <ayuanx@gmail.com>, 1118@bugs.x2go.org
References: <CAPuhghXHdipZZWsD1EiNwipb_Ksg=djtAUCfrBkC8f_ODph7Mw@mail.gmail.com>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <2a11eb7c-be89-f040-dba6-46d6bca48bf0@ionic.de>
Date: Tue, 29 Nov 2016 18:47:41 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0)
 Gecko/20100101 Thunderbird/45.5.0
MIME-Version: 1.0
In-Reply-To: <CAPuhghXHdipZZWsD1EiNwipb_Ksg=djtAUCfrBkC8f_ODph7Mw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="D09c906F7ai3o6jS6JOUXjgm5NL42CW9O"
[Message part 1 (text/plain, inline)]
Control: reassign -1 x2goclient 4.0.5.2
Control: tag -1 win32

On 29.11.2016 05:55 AM, Michael wrote:
> Package: x2goclient-4.0.5.2-2016.09.20-setup
> Version: x2goclient-4.0.5.2-2016.09.20-setup
> 
> Steps to reproduce:
> 
> 1. Install x2goclient-4.0.5.2-2016.09.20-setup.exe
> 
> 2. Make sure C:\Users\XXXXXXX\.x2go\etc does not exist, or delete it if existed.
> 
> 3. Create a new session to a x2go server.
> 
> 4. Enable share folder and watch the bug report window.
> 
> From the source code:
> 
> 9931 void ONMainWindow::startWinServers()
> 9932 {
> 9952         generateHostKey(RSA_KEY_TYPE);
> 
> For Windows, we only generate RSA_KEY, but in
> 
> 8013 QString ONMainWindow::createRSAKey()
> 8014 {
> 8043 #ifdef Q_OS_WIN
> 8044     rsa.setFileName (
> 8045         wapiShortFileName (
> 8046             homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub" ) );
> 8056     if ( !rsa.open ( QIODevice::ReadOnly | QIODevice::Text ) )
> 8057     {
> 
> 
> We check DSA_KEY instead, which of course would not exist.
> 
> To fix this bug:
> 
> 8046   -          homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub" ) );
> 8046   +         homeDir+"\\.x2go\\etc\\ssh_host_rsa_key.pub" ) );


I'm aware of that bug, but probably won't fix it directly. That thing shouldn't
come up with the new code in my bugfix/osx branch, since I've rewritten almost
all of the host key, client key (as used for the local [*not* remote] ssh
daemon) and ssh daemon handling. Changing portions there on the current master
branch would only lead to biggish conflicts while rebasing - that's not really
worth the effort. I'm rather concentrating on getting the other functionality
done and release-worthy instead, which will automatically fix this bug.



Mihai

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat May 18 00:59:32 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.