X2Go Bug report logs - #922
Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Robert Nowotny <rnowotny@rotek.at>

To: git-admin@x2go.org, submit@bugs.x2go.org

Subject: Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)

Date: Mon, 17 Aug 2015 15:53:21 +0200

[Message part 1 (text/plain, inline)]

Package: x2goagent
Version: 3.5.0.32


As discussed with IONIC, there is a problem when You try to connect to 
different servers from Windows at the same time, using multiple 
instances of x2go client.
The reason is, that the x2go servers are all using the same SSH_Port. 
That should not be a problem from my point of view, so that behaviour 
should be further investigated.

The problem was reported already a very long time ago, but still exists 
: https://www.mail-archive.com/x2go-user@lists.berlios.de/msg00547.html

In the meantime, here a small patch for x2gostartagent script:
That patch uses a different SSH_PORT for each Server, therefore try to 
avoid conflicts.

There are two methods implemented :

method one, suitable for Class "C" Networks, with no possible conflicts. 
The SSH Port is dependent on the last octet of the servers host adress.
method two, with randomized ports, what may lead to conflicts from case 
to case, but can handle networks were servers might have the same last 
octet of the host adress.

However, that patch enables to have multiple instances of x2goclients 
running on one windows machine, against different hosts.

please find attached the IRC conversation log with Ionic, as well as the 
patched script for x2gostartagent

I hove it can be committed, I am getting tired to patch my hosts on 
every x2go server update ;-)

yours sincerely

Robert Nowotny
Rotek GmbH

[Message part 2 (text/html, inline)]

[irclog.txt (text/plain, attachment)]

[x2gostartagent (text/plain, attachment)]

Message #16 received at 922@bugs.x2go.org (full text, mbox, reply):

From: Mihai Moldovan <ionic@ionic.de>

To: 922-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 922@bugs.x2go.org

Subject: X2Go issue (in src:x2goserver) has been marked as pending for release

Date: Sun, 23 Aug 2015 23:10:52 +0200 (CEST)

tag #922 pending
fixed #922 4.0.1.20
thanks

Hello,

X2Go issue #922 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=beb3517

The issue will most likely be fixed in src:x2goserver (4.0.1.20).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit beb351773b40c8ecdca035f970aa17e646786ba9
Author: Mihai Moldovan <ionic@ionic.de>
Date:   Sun Aug 23 23:08:45 2015 +0200

    x2goserver/bin/x2gostartagent: changes to Robert Nowotny's SSH_PORT patch. Fixes: #922.
    
    Use default outgoing interface to determine IP address.
    
    Use the whole range of ${RANDOM}'s pool.
    
    Seed it for good measure.
    
    Change the default method to randomization instead of IP-based
    initialization.
    
    If IP-based initialization was requested but the default outgoing IP
    address unavailable, fall back to randomization.

diff --git a/debian/changelog b/debian/changelog
index 159b682..bd416a2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -62,6 +62,12 @@ x2goserver (4.0.1.20-0x2go1) UNRELEASED; urgency=low
       state change when updating the cached state result.
     - x2goserver/sbin/x2gocleansessions: only output status refreshing debug
       message if the old and new states actually differ. Prevents log spam.
+    - x2goserver/bin/x2gostartagent: changes to Robert Nowotny's SSH_PORT
+      patch. Fixes: #922. Use default outgoing interface to determine IP
+      address. Use the whole range of ${RANDOM}'s pool. Seed it for good
+      measure. Change the default method to randomization instead of IP-based
+      initialization. If IP-based initialization was requested but the default
+      outgoing IP address unavailable, fall back to randomization.
   * x2goserver.spec:
     - Add sudo and logcheck as BuildRequires and Requires. Don't own
       directories that are owned by sudo and logcheck. Logcheck is not
@@ -90,6 +96,11 @@ x2goserver (4.0.1.20-0x2go1) UNRELEASED; urgency=low
     + Use proper comment header explaining about preinst script argument
       calls (not postinst).
 
+  [ Robert Nowotny ]
+  * New upstream version (4.0.1.20):
+    - x2goserver/bin/x2gostartagent: original patch for SSH_PORT
+      randomization/IP-based initialization. Submitted as #922.
+
  -- X2Go Release Manager <git-admin@x2go.org>  Tue, 24 Feb 2015 22:11:49 +0100
 
 x2goserver (4.0.1.19-0x2go2) UNRELEASED; urgency=low

Message #28 received at 922@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 922@bugs.x2go.org

Subject: Fwd: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports.

Date: Wed, 30 Dec 2015 09:50:56 +0000

[Message part 1 (text/plain, inline)]

----- Weitergeleitete Nachricht von Mike Gabriel  
<mike.gabriel@das-netzwerkteam.de> -----
  Datum: Wed, 30 Dec 2015 09:21:20 +0000
    Von: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Betreff: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for  
creating ports.
     An: x2go-dev@lists.x2go.org

Hi guys,

On  So 23 Aug 2015 23:10:59 CEST, git-admin wrote:

> This is an automated email from the git hooks/post-receive script.
>
> x2go pushed a commit to branch master
> in repository x2goserver.
>
> commit bfe3ba761c1d3e9143285ca17edc87ac763ce35d
> Author: Mihai Moldovan <ionic@ionic.de>
> Date:   Sun Aug 23 23:08:45 2015 +0200
>
>    x2goserver/bin/x2gostartagent: changes to Robert Nowotny's  
> SSH_PORT patch. Fixes: #922.
>
>    Use default outgoing interface to determine IP address.
>
>    Use the whole range of ${RANDOM}'s pool.
>
>    Seed it for good measure.
>
>    Change the default method to randomization instead of IP-based
>    initialization.
>
>    If IP-based initialization was requested but the default outgoing IP
>    address unavailable, fall back to randomization.
>

Haven't looked at X2Go Server code for a while... Today I found the below...

> +# Get server IP address.
> +get_server_ip_address() {
> +	# The provided IP address should be outside of any local network.
> +	# We are only interested in how the kernel would try to reach the
> +	# non-local IP address specified here. It is not actually contacted
> +	# in any way.
> +	typeset ip_output="$(ip route get 8.8.8.8)"
> +
> +	# Remove newlines.
> +	ip_output="${ip_output//$'\n'}"
> +
> +	# Fetch source address.
> +	typeset src_address="$(grep -oe  
> 'src[[:space:]]\{1,\}\(\([[:digit:]]\{1,3\}\.\)\{3\}[[:digit:]]\{1,3\}\)'  
> <<< "${ip_output}" | sed -e 's/src[[:space:]]\{1,\}//')"
> +
> +	if [ -n "${src_address}" ]; then
> +		printf "${src_address}"
> +		return "0"
> +	fi
> +
> +	return "1"
> +}

Has anyone of you ever heard of IPv6? And has anyone ever seen setups  
where the IPv6 traffic is routed via a different interface compared to  
IPv4 traffic?

Furthermore, within the last years, I never had any problems with  
server-side ports being the same on different servers. I mostly  
connect through PyHoca. So if there is a problem in X2Go Client  
regarding server-side SSH tunnel ports, why--the hack--do you fix that  
in X2Go Server?

If the port allocation is a problem at all, it certainly is a problem  
that requires fixing in X2Go Client, not X2Go Server.

Please consider reverting this flawed patch!!!

Scratching my head and wondering...

Mike

----- Ende der weitergeleiteten Nachricht -----

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Message #33 received at 922@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 922@bugs.x2go.org

Subject: Fwd: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports.

Date: Wed, 30 Dec 2015 09:51:15 +0000

[Message part 1 (text/plain, inline)]

----- Weitergeleitete Nachricht von Mike Gabriel  
<mike.gabriel@das-netzwerkteam.de> -----
  Datum: Wed, 30 Dec 2015 09:40:19 +0000
    Von: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Betreff: Re: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic  
for creating ports.
     An: x2go-dev@lists.x2go.org

Furthermore...

On  Mi 30 Dez 2015 10:21:20 CET, Mike Gabriel wrote:

>> +get_server_ip_address() {
>> +	# The provided IP address should be outside of any local network.
>> +	# We are only interested in how the kernel would try to reach the
>> +	# non-local IP address specified here. It is not actually contacted
>> +	# in any way.
>> +	typeset ip_output="$(ip route get 8.8.8.8)"

Since when does X2Go promote Google??? Or even depend on them?

As this patch is IPv6-flawed anyway, the next request is pointless...  
In case the patch is kept, please make this configurable and use the  
IP address of japsand.x2go.org or some other static IP on the internet  
that is more political correct, please.

Good candidates for this are the root DNS servers of the world:

IPv4:
192.228.79.201
192.33.4.12
199.7.91.13
192.203.230.10
192.5.5.241
192.112.36.4
128.63.2.53
192.36.148.17
192.58.128.30
193.0.14.129
199.7.83.42
202.12.27.33

IPv6:

2001:503:ba3e::2:30
2001:500:84::b
2001:500:2::c
2001:500:2d::d
2001:500:2f::f
2001:500:1::803f:235
2001:7fe::53
2001:503:c27::2:30
2001:7fd::1
2001:500:3::42
2001:dc3::35

Regarding IPv4/IPv6 flaw in the patch... There are also setup that are  
IPv6 only... Tststs...

Mike

----- Ende der weitergeleiteten Nachricht -----

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Message #38 received at 922@bugs.x2go.org (full text, mbox, reply):

From: Stefan Baur <X2Go-ML-1@baur-itcs.de>

To: 922@bugs.x2go.org

Subject: Fwd: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports.

Date: Wed, 30 Dec 2015 10:50:57 +0100

[Message part 1 (text/plain, inline)]

Forwarding this to the bugtracker so it doesn't get lost ...


-------- Weitergeleitete Nachricht --------
Betreff: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for
creating ports.
Datum: Wed, 30 Dec 2015 09:21:20 +0000
Von: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Organisation: DAS-NETZWERKTEAM
An: x2go-dev@lists.x2go.org

Hi guys,

On  So 23 Aug 2015 23:10:59 CEST, git-admin wrote:

> This is an automated email from the git hooks/post-receive script.
>
> x2go pushed a commit to branch master
> in repository x2goserver.
>
> commit bfe3ba761c1d3e9143285ca17edc87ac763ce35d
> Author: Mihai Moldovan <ionic@ionic.de>
> Date:   Sun Aug 23 23:08:45 2015 +0200
>
>     x2goserver/bin/x2gostartagent: changes to Robert Nowotny's  
> SSH_PORT patch. Fixes: #922.
>
>     Use default outgoing interface to determine IP address.
>
>     Use the whole range of ${RANDOM}'s pool.
>
>     Seed it for good measure.
>
>     Change the default method to randomization instead of IP-based
>     initialization.
>
>     If IP-based initialization was requested but the default outgoing IP
>     address unavailable, fall back to randomization.
>

Haven't looked at X2Go Server code for a while... Today I found the below...

> +# Get server IP address.
> +get_server_ip_address() {
> +	# The provided IP address should be outside of any local network.
> +	# We are only interested in how the kernel would try to reach the
> +	# non-local IP address specified here. It is not actually contacted
> +	# in any way.
> +	typeset ip_output="$(ip route get 8.8.8.8)"
> +
> +	# Remove newlines.
> +	ip_output="${ip_output//$'\n'}"
> +
> +	# Fetch source address.
> +	typeset src_address="$(grep -oe  
> 'src[[:space:]]\{1,\}\(\([[:digit:]]\{1,3\}\.\)\{3\}[[:digit:]]\{1,3\}\)'  
> <<< "${ip_output}" | sed -e 's/src[[:space:]]\{1,\}//')"
> +
> +	if [ -n "${src_address}" ]; then
> +		printf "${src_address}"
> +		return "0"
> +	fi
> +
> +	return "1"
> +}

Has anyone of you ever heard of IPv6? And has anyone ever seen setups
where the IPv6 traffic is routed via a different interface compared to
IPv4 traffic?

Furthermore, within the last years, I never had any problems with
server-side ports being the same on different servers. I mostly
connect through PyHoca. So if there is a problem in X2Go Client
regarding server-side SSH tunnel ports, why--the hack--do you fix that
in X2Go Server?

If the port allocation is a problem at all, it certainly is a problem
that requires fixing in X2Go Client, not X2Go Server.

Please consider reverting this flawed patch!!!

Scratching my head and wondering...

Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

[Nachrichtenteil als Anhang (text/plain, attachment)]

Message #43 received at 922@bugs.x2go.org (full text, mbox, reply):

From: Stefan Baur <X2Go-ML-1@baur-itcs.de>

To: 922@bugs.x2go.org

Subject: Fwd: Re: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports.

Date: Wed, 30 Dec 2015 10:51:28 +0100

[Message part 1 (text/plain, inline)]

Forwarding this to the bugtracker so it doesn't get lost ...


-------- Weitergeleitete Nachricht --------
Betreff: Re: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic
for creating ports.
Datum: Wed, 30 Dec 2015 09:40:19 +0000
Von: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Organisation: DAS-NETZWERKTEAM
An: x2go-dev@lists.x2go.org

Furthermore...

On  Mi 30 Dez 2015 10:21:20 CET, Mike Gabriel wrote:

>> +get_server_ip_address() {
>> +	# The provided IP address should be outside of any local network.
>> +	# We are only interested in how the kernel would try to reach the
>> +	# non-local IP address specified here. It is not actually contacted
>> +	# in any way.
>> +	typeset ip_output="$(ip route get 8.8.8.8)"

Since when does X2Go promote Google??? Or even depend on them?

As this patch is IPv6-flawed anyway, the next request is pointless...
In case the patch is kept, please make this configurable and use the
IP address of japsand.x2go.org or some other static IP on the internet
that is more political correct, please.

Good candidates for this are the root DNS servers of the world:

IPv4:
192.228.79.201
192.33.4.12
199.7.91.13
192.203.230.10
192.5.5.241
192.112.36.4
128.63.2.53
192.36.148.17
192.58.128.30
193.0.14.129
199.7.83.42
202.12.27.33

IPv6:

2001:503:ba3e::2:30
2001:500:84::b
2001:500:2::c
2001:500:2d::d
2001:500:2f::f
2001:500:1::803f:235
2001:7fe::53
2001:503:c27::2:30
2001:7fd::1
2001:500:3::42
2001:dc3::35

Regarding IPv4/IPv6 flaw in the patch... There are also setup that are
IPv6 only... Tststs...

Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

[Nachrichtenteil als Anhang (text/plain, attachment)]

Message #46 received at 922-submitter@bugs.x2go.org (full text, mbox, reply):

From: "FedEx 2Day A.M." <jerome.conner@gaertnereihuber.de>

To: 922-submitter@bugs.x2go.org

Subject: Unable to deliver your item, #00000284455

Date: Thu, 13 Oct 2016 07:28:04 +0200

[Message part 1 (text/plain, inline)]

Dear Customer,

Your parcel has arrived at October 10. Courier was unable to deliver the parcel to you.
Delivery Label is attached to this email.

Thanks and best regards,
Jerome Conner,
FedEx Station Manager.

[Label_00000284455.zip (application/zip, attachment)]

Message #51 received at 922@bugs.x2go.org (full text, mbox, reply):

From: "FedEx Standard Overnight" <freddie.hensley@buydemographics.com>

To: 922@bugs.x2go.org

Subject: Delivery Notification, ID 000230993

Date: Wed, 26 Oct 2016 09:16:19 +0000

[Message part 1 (text/plain, inline)]

Dear Customer,

Courier was unable to deliver the parcel to you.
Shipment Label is attached to this email.

Yours trully,
Freddie Hensley,
Operation Manager.

[FedEx_ID_000230993.zip (application/zip, attachment)]

Message #56 received at 922@bugs.x2go.org (full text, mbox, reply):

From: "FedEx International Next Flight" <milton.goldman@therockband.us>

To: 922@bugs.x2go.org

Subject: Problem with parcel shipping, ID:0000875347

Date: Sun, 6 Nov 2016 11:03:52 -0600

[Message part 1 (text/plain, inline)]

Dear Customer,

We could not deliver your item.
You can review complete details of your order in the find attached.

Yours trully,
Milton Goldman,
FedEx Station Manager.

[Label_0000875347.zip (application/zip, attachment)]

Message #61 received at 922@bugs.x2go.org (full text, mbox, reply):

From: X2Go Release Manager <git-admin@x2go.org>

To: 922-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 922@bugs.x2go.org

Subject: X2Go issue (in src:x2goserver) has been marked as closed

Date: Sun, 20 Nov 2016 12:42:59 +0100 (CET)

close #922
thanks

Hello,

we are very hopeful that X2Go issue #922 reported by you
has been resolved in the new release (4.0.1.20) of the
X2Go source project »src:x2goserver«.

You can view the complete changelog entry of src:x2goserver (4.0.1.20)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goserver.

    http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=71e1e82d82acc718da71301d2fbd67eb0a71ad44;hp=8a494e794402c1b124d861893d649726a9016eb7

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goserver.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goserver
Version: 4.0.1.20-0x2go1
Status: RELEASE
Date: Sun, 20 Nov 2016 12:39:36 +0100
Fixes: 799 812 888 889 903 922 923 985 1065 1068 1073
Changes: 
 x2goserver (4.0.1.20-0x2go1) RELEASED; urgency=low
 .
   [ Mike DePaulo ]
   * New upstream version (4.0.1.20):
     - TERMINAL Session: Add support for qterminal
       (Lightweight terminal emulator written in Qt)
     - TRINITY: Add support for Q4OS
 .
   [ Mihai Moldovan ]
   * New upstream version (4.0.1.20):
     - x2goserver/bin/x2gogetapps: respect NoDisplay and Hidden values, don't
       parse the full desktop file if there are non-Desktop Entries groups.
       Based on a patch submitted by Jason Alavaliant. Fixes: #812.
     - x2goserver/bin/x2gogetapps: do not print spurious newlines.
     - Change string "X2go" to "X2Go" where appropriate.
     - Add runcommand.d hooks to x2goserver-extensions Makefile.
     - x2goserver/bin/x2gosessionlimit: don't iterate over the whole groups
       file. Only check the primary and secondary groups as returned by
       getgid()/getgroups(). Fixes long delays in session startup on machines
       with a gazillion of groups.
     - x2goserver/sbin/x2gocleansessions: re-fetch the current sessions' status
       before handling it. Using the "cached" value from the initial
       x2golistsessions run may be desynchronized with the actual current
       value. Avoids a race condition logging users out after they attached to a
       session.
     - x2goserver/sbin/x2gocleansessions: rename %remembered_sessions_since to
       %remembered_sessions_status_since. That's what it really is. Add
       comments to further clarify what it's actually doing. Change it to
       include a timestamp instead of the "iteration count multiplied by two"
       value. Compare timestamps to see if killing hanging nxagent processes is
       necessary.
     - x2goserver/sbin/x2gocleansessions: rename
       %remembered_sessions_status_since to
       %remembered_sessions_status_since_time. Add
       %remembered_sessions_status_since_iterations that will come in handy for
       the next change.
     - x2goserver/sbin/x2gocleansessions: give suspended-but-running sessions a
       grace period of one iteration. Fixes: #888.
     - x2goserver/sbin/x2gocleansessions: fix ugly missing whitespace.
     - x2goserver/sbin/x2gocleansessions: move up session status sync a bit,
       don't update session state when session has been removed from the
       database.
     - x2goserver/sbin/x2gocleansessions: unify log messages. Move dangling
       line around.
     - x2goserver/sbin/x2gocleansessions: whitespace only.
     - x2goserver/sbin/x2gocleansessions: also delete entries in the other,
       overlooked hashes.
     - x2goserver/sbin/x2gocleansessions: move socket and lock file cleanup
       into time-based block for finished/failed sessions.
     - x2goserver/sbin/x2gocleansessions: add @remembered_finished_sessions
       array. Merge with session list as queried from the database (won't
       include finished/failed sessions) and remember F-state sessions via this
       array. Only delete elements once work on these has been finished.
     - x2goserver/sbin/x2gocleansessions: don't add failed/finished sessions to
       remembered list if that list already includes them.
     - x2goserver/sbin/x2gocleansessions: don't use gmtime (time ()) but merely
       time (). The former one returns a formatted date-time string, which
       can't be checked by forming a difference. The latter one returns an UNIX
       timestamp, which is what we really want... minus leap seconds. Let's
       hope this doesn't bite back some time or later...
     - x2goserver/sbin/x2gocleansessions: add debugging output to show the
       state change when updating the cached state result.
     - x2goserver/sbin/x2gocleansessions: only output status refreshing debug
       message if the old and new states actually differ. Prevents log spam.
     - x2goserver/bin/x2gostartagent: changes to Robert Nowotny's SSH_PORT
       patch. Fixes: #922. Use default outgoing interface to determine IP
       address. Use the whole range of ${RANDOM}'s pool. Seed it for good
       measure. Change the default method to randomization instead of IP-based
       initialization. If IP-based initialization was requested but the default
       outgoing IP address unavailable, fall back to randomization.
     - x2goserver/bin/x2goruncommand: whitespace and comment changes only.
     - x2goserver/bin/x2gocleansessions: replace system_capture_stdout_output()
       with actual implementation. We don't have that function on the release
       branch.
     - x2goserver-xsession/etc/Xsession: use /bin/bash explicitly on RedHat-,
       Gentoo- and SuSE-based systems. Users might change /bin/sh to point to a
       shell like mksh or dash, which do not support the -l or -c flags to
       exec. C.f., BGO #575022 (Gentoo.)
     - x2goserver/bin/x2gomountdirs: remove blowfish Cipher spec hardcoded for
       sshfs mounts. The speed improvement is probably mostly an illusion
       (unless talking about high-bandwidth links) and more importantly recent
       OpenSSH server versions seem to disable the Blowfish cipher by default,
       leading to errors like "Connection reset by peer."
     - x2goserver/bin/x2goruncommand: whitespace only.
     - x2goserver/sbin/x2gocleansessions: add Perl documentation and --help,
       -h, -? and --man options. Fixes: #1065. Also print a usage message on
       unknown options.
     - x2goserver/man/man8/x2gocleansessions.8: drop obsolete man page.
     - x2goserver-xsession/etc/Xsession: fix uname calls when (potentially)
       creating session log/error file and add uname call where necessary.
     - x2goserver-xsession/etc/Xsession: include hostname in
       xsession-x2go-errors file name. Part of #923.
     - x2goserver-xsession/etc/Xsession: rotate old log/error file before
       appending new data. Fixes: #923.
     - x2goserver-xsession/etc/Xsession: fix wrong variable usage.
       Fixes: #1073.
     - x2goserver/sbin/x2gocleansessions: move in-file POD to end of file,
       rather than "commenting" out all the remaining code. Fixes: #1068.
     - x2goserver/sbin/x2godbadmin: exit earlier when not finding the required
       "x2gouser" user.
   * x2goserver.spec:
     - Add sudo and logcheck as BuildRequires and Requires. Don't own
       directories that are owned by sudo and logcheck. Logcheck is not
       available on *SUSE, FC < 20 and RHEL, so for those distros still own the
       directories.
     - Typo fix in comment: Recommands -> Recommends.
     - Fix installation on OpenSUSE 12.3 and higher: has replaced pwdutils with
       shadow. Also affects SLE{S,D} 12.
     - Add workaround documentation for sudoers on *SUSE 11.
     - Add shadow/shadow-utils/pwdutils Requires to x2goserver-printing
       sub package.
     - Add new dependency on bash.
     - Add new dependency on xkeyboard-config to x2goserver. Fixes: #903.
     - Add new dependency on perl and the Cwd module to x2goserver-xsession.
       Part of #923.
   * debian/control:
     - Add new dependency on bash.
     - Add new dependency on xkb-data to x2goserver.
     - Maintainer change in package: X2Go Developers <x2go-dev@lists.x2go.org>.
     - Uploaders: add myself. Also, force a rebuild due to the changed
       versioning.
     - Add new dependency on perl-modules for Cwd. Part of #923.
 .
   [ Henning Heinold ]
   * New upstream version (4.0.1.20):
     - x2goserver/sbin/x2godbadmin: remove trailing whitespace.
     - x2goserver/sbin/x2godbadmin: revoke all PRIVILEGES before trying to
       delete a user on postgres. Fixes: #889.
 .
   [ Mike Gabriel ]
   * debian/x2goserver.preinst:
     + Use proper comment header explaining about preinst script argument
       calls (not postinst).
 .
   [ Robert Nowotny ]
   * New upstream version (4.0.1.20):
     - x2goserver/bin/x2gostartagent: original patch for SSH_PORT
       randomization/IP-based initialization. Submitted as #922.
 .
   [ Stefan Baur ]
   * New upstream version (4.0.1.20):
     - x2goserver/bin/x2goruncommand: add the other trinity launcher scripts in
       order from newest to oldest. Fixes: #985.
 .
   [ Tor Perkins ]
   * New upstream version (4.0.1.20):
     - x2goserver/bin/x2goruncommand: capture x2goruncommand debug output for
       x2gofeature X2GO_XSESSION.
 .
   [ Orion Poplawski ]
   * New upstream version (4.0.1.20):
     - x2goserver/bin/x2golistdesktops: drop -u parameter to ss. Fixes: #799.
       We would filter out UDP sockets later anyway and the combination -lxu is
       known to be broken with some versions of iproute2.

Send a report that this bug log contains spam.