#922 - Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)

X2Go Bug report logs - #922
Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)

Reported by: Robert Nowotny <rnowotny@rotek.at>

Date: Mon, 17 Aug 2015 14:05:02 UTC

Severity: normal

Tags: pending

Found in version 4.0.1.19

Fixed in version 4.0.1.20

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

X-Loop: owner@bugs.x2go.org
Subject: Bug#922: Fwd: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports.
Reply-To: Stefan Baur <X2Go-ML-1@baur-itcs.de>, 922@bugs.x2go.org
Resent-From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Wed, 30 Dec 2015 10:05:02 +0000
Resent-Message-ID: <handler.922.B922.145146982532073@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 922
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: pending
Received: via spool by 922-submit@bugs.x2go.org id=B922.145146982532073
          (code B ref 922); Wed, 30 Dec 2015 10:05:02 +0000
Received: (at 922) by bugs.x2go.org; 30 Dec 2015 10:03:45 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
X-Greylist: delayed 752 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Wed, 30 Dec 2015 11:03:43 CET
Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 674B63C574
	for <922@bugs.x2go.org>; Wed, 30 Dec 2015 11:03:43 +0100 (CET)
Received: from [192.168.0.171] ([109.192.26.232]) by mrelayeu.kundenserver.de
 (mreue103) with ESMTPSA (Nemesis) id 0LxLzO-1aBNFk4C7u-01713h for
 <922@bugs.x2go.org>; Wed, 30 Dec 2015 10:51:11 +0100
References: <20151230092120.Horde.lT9DmtPzVMys6M2vJN4D5K8@mail.das-netzwerkteam.de>
To: 922@bugs.x2go.org
From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
X-Forwarded-Message-Id: <20151230092120.Horde.lT9DmtPzVMys6M2vJN4D5K8@mail.das-netzwerkteam.de>
Message-ID: <5683A901.5060102@baur-itcs.de>
Date: Wed, 30 Dec 2015 10:50:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20151230092120.Horde.lT9DmtPzVMys6M2vJN4D5K8@mail.das-netzwerkteam.de>
Content-Type: multipart/mixed;
 boundary="------------000603090505050909020103"
X-Provags-ID: V03:K0:Jgb9yzeM6AyAgNx+NG1BdT1j7+ar/DYVkf2UpfU9hewh3cNyiyD
 wB7nQC2OcDBkWzFxqJ6G5HsNMwrHLICEUE+z99Ss8AxFu43xgJdEGOjsj1c+o3nwr9oRxxn
 XcBPX+fnTR7vEB9bcFKs2ekpXYg9JOwMQaoPdiXWg0IcqngBrwIOXLV4xXI+wBvxfWtQQLD
 XQkapIvEjFUUYOKmlBPOw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ovDHoc71RBQ=:3r5nskPzMukqQAsZ2agl7m
 HdQQ7A6QsLH5RYnhUvIPIvrT4iqCi6TYtphFMugftQGYvaUwP9JS49P+zA5BWiG5fEtz0o7Sm
 yAkxsYz+b2tG+CUrlSTomgKCJLNz4xXMhWWIebGR0Ig+LjFG2N/vKI63rnDqrrMuWcFLDQVG0
 XZGnF2EKjEQP1AC9b7gt6I/rBFq0lvqoQGkwUbpFQalkQl6H51q9ogjnpSvUsPhPEapUCJBZj
 1vw5QTH/UaOYB8q1e/YyPRm5h94qz1uhgH/uF0Ec43NDwycuKXP5e4WL20Z8r+mlmPtc+F0mo
 pYAVqoR2EVQ7tWuPnfz/6CBmkOr66eh/x/biOlXEOt0vR2KPpiHtTtsXHTgfz7fUT4GdNg9zn
 a+rZLHxtMFXMiZ6SZky8Iz6WFqZqEH/67dIZ12tMrATg2QV9tLPVr+NytzGHo3YQCmn6os8Br
 I3ubL/edE6yjJpiuXuoXnxkFhGwza681dVY42GAuekEA1zpFveDL6icASxxx+YvKNiWxGSa4C
 fXQ3OSPmLoqztBAYKwqgzBRscTUfcQdf2Kp++oVovGFKcghfMWRoiF3txbKb32uNXIcRBc+Fm
 I84l0vOJVKmc+9nIdwRW+Zh8XzlSZz3sNujFdfa78vL4FA0iZh9zpa/rSvfnjQn06OrhLideN
 d7CpFbNmr3nuCwY6YJMKuQ+XjN//IwEKTeceN2tXTlPFxrskzG0bGltIzdsf7QT94ycc=

[Message part 1 (text/plain, inline)]

Forwarding this to the bugtracker so it doesn't get lost ... -------- Weitergeleitete Nachricht -------- Betreff: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports. Datum: Wed, 30 Dec 2015 09:21:20 +0000 Von: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Organisation: DAS-NETZWERKTEAM An: x2go-dev@lists.x2go.org Hi guys, On So 23 Aug 2015 23:10:59 CEST, git-admin wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch master > in repository x2goserver. > > commit bfe3ba761c1d3e9143285ca17edc87ac763ce35d > Author: Mihai Moldovan <ionic@ionic.de> > Date: Sun Aug 23 23:08:45 2015 +0200 > > x2goserver/bin/x2gostartagent: changes to Robert Nowotny's > SSH_PORT patch. Fixes: #922. > > Use default outgoing interface to determine IP address. > > Use the whole range of ${RANDOM}'s pool. > > Seed it for good measure. > > Change the default method to randomization instead of IP-based > initialization. > > If IP-based initialization was requested but the default outgoing IP > address unavailable, fall back to randomization. > Haven't looked at X2Go Server code for a while... Today I found the below... > +# Get server IP address. > +get_server_ip_address() { > + # The provided IP address should be outside of any local network. > + # We are only interested in how the kernel would try to reach the > + # non-local IP address specified here. It is not actually contacted > + # in any way. > + typeset ip_output="$(ip route get 8.8.8.8)" > + > + # Remove newlines. > + ip_output="${ip_output//$'\n'}" > + > + # Fetch source address. > + typeset src_address="$(grep -oe > 'src[[:space:]]\{1,\}$\([[:digit:]]\{1,3\}\.$\{3\}[[:digit:]]\{1,3\}\)' > <<< "${ip_output}" | sed -e 's/src[[:space:]]\{1,\}//')" > + > + if [ -n "${src_address}" ]; then > + printf "${src_address}" > + return "0" > + fi > + > + return "1" > +} Has anyone of you ever heard of IPv6? And has anyone ever seen setups where the IPv6 traffic is routed via a different interface compared to IPv4 traffic? Furthermore, within the last years, I never had any problems with server-side ports being the same on different servers. I mostly connect through PyHoca. So if there is a problem in X2Go Client regarding server-side SSH tunnel ports, why--the hack--do you fix that in X2Go Server? If the port allocation is a problem at all, it certainly is a problem that requires fixing in X2Go Client, not X2Go Server. Please consider reverting this flawed patch!!! Scratching my head and wondering... Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu May 2 01:24:40 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #922 Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)

X2Go Bug report logs - #922
Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)