#1611 - [PATCH] x2goclient: Replace deprecated uses of QString::null

X2Go Bug report logs - #1611
[PATCH] x2goclient: Replace deprecated uses of QString::null

Reported by: Nico Roeser <nico@roeserundroeser.de>

Date: Tue, 15 Aug 2023 17:25:02 UTC

Severity: normal

Tags: patch

Found in version 4.1.2.3

Received: (at submit) by bugs.x2go.org; 15 Aug 2023 17:20:49 +0000
From nico@roeserundroeser.de  Tue Aug 15 19:20:37 2023
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,SPF_HELO_NONE,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2
Received: from chocoball.roeserundroeser.de (chocoball.roeserundroeser.de [46.38.233.219])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1D5035DAC0
	for <submit@bugs.x2go.org>; Tue, 15 Aug 2023 19:20:37 +0200 (CEST)
Received: from localhost (p5dc1a149.dip0.t-ipconnect.de [93.193.161.73])
	(using TLSv1.2 with cipher DHE-RSA-AES256-SHA256 (256/256 bits))
	(No client certificate requested)
	by chocoball.roeserundroeser.de (Postfix) with ESMTPSA id 679B0FF976
	for <submit@bugs.x2go.org>; Tue, 15 Aug 2023 19:20:36 +0200 (CEST)
Date: Tue, 15 Aug 2023 19:20:35 +0200
From: Nico Roeser <nico@roeserundroeser.de>
To: submit@bugs.x2go.org
Subject: [PATCH] x2goclient: Replace deprecated uses of QString::null
Message-ID: <ZNuz425XlxoJuikV@imap.roeserundroeser.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="FMG9Upt5TAt7LNIe"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

[Message part 1 (text/plain, inline)]

Package: x2goclient Version: 4.1.2.3 Tag: patch Related to: #864 On one of my Gentoo systems, x2goclient-4.1.2.3 did not build against qtcore-5.15.10. The attached patch changes deprecated occurrences of QString::null into isEmpty calls or construction of new null QStrings, which fixes the build problems. I have not verified whether everything still functions perfectly. However, the change follows the Qt recommendations, and looks good to me when peeking at the QString documentation. I know that there still are strange constructions in the code, which I have not changed. Reason is that I tried the change to be as minimal as possible. I do not intend to invest more time/work in this in the nearer future; if this patch is not sufficient, I hope someone else can pick it up and continue from there. Or just throw it away. ☺ Happy coding! Attachment: 0001-x2goclient-Replace-deprecated-uses-of-QString-null.patch Thanks -- Nico

X2Go Developers <owner@bugs.x2go.org>. Last modified: Mon May 13 04:29:16 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #1611 [PATCH] x2goclient: Replace deprecated uses of QString::null

X2Go Bug report logs - #1611
[PATCH] x2goclient: Replace deprecated uses of QString::null