X2Go Bug report logs - #1611
[PATCH] x2goclient: Replace deprecated uses of QString::null

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Nico Roeser <nico@roeserundroeser.de>

Date: Tue, 15 Aug 2023 17:25:02 UTC

Severity: normal

Tags: patch

Found in version 4.1.2.3

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1611; Package x2goclient. (Tue, 15 Aug 2023 17:25:02 GMT) (full text, mbox, link).


Acknowledgement sent to Nico Roeser <nico@roeserundroeser.de>:
New Bug report received and forwarded. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Tue, 15 Aug 2023 17:25:02 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Nico Roeser <nico@roeserundroeser.de>
To: submit@bugs.x2go.org
Subject: [PATCH] x2goclient: Replace deprecated uses of QString::null
Date: Tue, 15 Aug 2023 19:20:35 +0200
[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.1.2.3
Tag: patch

Related to: #864

On one of my Gentoo systems, x2goclient-4.1.2.3 did not build against qtcore-5.15.10. The attached patch changes deprecated occurrences of QString::null into isEmpty calls or construction of new null QStrings, which fixes the build problems.

I have not verified whether everything still functions perfectly. However, the change follows the Qt recommendations, and looks good to me when peeking at the QString documentation. I know that there still are strange constructions in the code, which I have not changed. Reason is that I tried the change to be as minimal as possible.

I do not intend to invest more time/work in this in the nearer future; if this patch is not sufficient, I hope someone else can pick it up and continue from there. Or just throw it away. ☺ Happy coding!

Attachment: 0001-x2goclient-Replace-deprecated-uses-of-QString-null.patch

Thanks
-- 
Nico
[0001-x2goclient-Replace-deprecated-uses-of-QString-null.patch (text/plain, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue May 28 01:30:37 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.