X2Go Bug report logs - #1601
Patch for x2goclient Qt5 build on Windows

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Orion Poplawski <orion@nwra.com>

Date: Tue, 9 May 2023 17:00:01 UTC

Severity: normal

Tags: patch

Found in version 4.1.2.2

Full log


Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 9 May 2023 16:56:18 +0000
From orion@nwra.com  Tue May  9 18:56:17 2023
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,SPF_HELO_PASS,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
	version=3.4.2
Received: from GCC02-DM3-obe.outbound.protection.outlook.com (mail-dm3gcc02on20709.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d04::709])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 4F1ED5DAED
	for <submit@bugs.x2go.org>; Tue,  9 May 2023 18:56:14 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U8ag6jsha8gn4wXKH2veM9rqyxuiQDphcuAC0CP8jIhre28USBBZDSUq8QMWlCXw3IjjKB4CdPW6cyQRdljAuj8JS9cJxmR0UCpdGosjlbHGGNNmO3QDYheuScm0aILRD7w3r5A3iG7DDHo2mkL8ARvo5VaYmZiqZYUPMhzVhDV7U+wCrHrMSyIPTAMZ1sGAPaMfGeDGdxglMI6Pj/5MQCYgsMURONRW9DHO4eou9wP1afl4o60Turnah1ensTuZLnmsgfI5yU8ybqrCW8zbkQE9olghxPACDgsbJBdT/vKpRd9LNgEz3E7+Nrf8VLOk/KmGqjpCEsXA2Kao6l4G5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vIRZTzpc2D1J+eA/SglQcbbaQeftNNlUqA4sELRNPvU=;
 b=EfMEjoL/45XMvtpgenfalnGwrnmeL4ngk4AHr+zwS+Jh7onajQsE7QAKX5GroiOgb6H1MUpD287RVq4tV2uxSfUPYh3kCmx6fuuZssOQEHnGG2IyCYBMtoHTyGGbqwUKdGVnm23Y9XcVpGNMetK8cPKnh/rcJEqmpGIoEJC4iA8XgNl628kyCzj5fUs3nK/a1hTSvwRkLKbxtiGLkcg8J+P31nShsMsDNxGHAwzymjNYUXHWcx/mz43RhAwbCqe/beMS3Ga19rw8NRcdm3kdReeZydKvJmGhyhbjBbHSgfcczoISo+oa2RMSCsA/HjFGIlBBkXO0JCfO5WUObQVkRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nwra.com; dmarc=pass action=none header.from=nwra.com;
 dkim=pass header.d=nwra.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nwra.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vIRZTzpc2D1J+eA/SglQcbbaQeftNNlUqA4sELRNPvU=;
 b=vnZZDrW1KRS2jB+ZN+VNHmqXKtJW6I5TvhQgwpAzplkdJEdLTar7JZDj1eG5TgPenPPIEXj0sMWIQpKCmBJ/jU3Q1h+W51jzIZBXbJampnHgKCSkMjlfxnAeJSmq5dc018GjlzRmZzLt8R3Thd7KY7I+b72uvrrW9/uUvytq+HsG9M+6ASNbF53lFUDcVszC8uSSVraK0P+CGQU9vrPW15ax5ggUNTfXnPgZmt/km8/RnKc+MXnZSK1oaV6J4AbbpLiruSaZF7cxHRlF9HFQZm+20lu+OOJT7v1isycODquYaHPeXZbYIlfkPHj4q6eRK0joUbouei3HnoaGXFiP+g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nwra.com;
Received: from SJ0PR09MB6318.namprd09.prod.outlook.com (2603:10b6:a03:26b::14)
 by SJ0PR09MB11493.namprd09.prod.outlook.com (2603:10b6:a03:50a::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18; Tue, 9 May
 2023 16:56:12 +0000
Received: from SJ0PR09MB6318.namprd09.prod.outlook.com
 ([fe80::21ee:67bb:7cac:af4e]) by SJ0PR09MB6318.namprd09.prod.outlook.com
 ([fe80::21ee:67bb:7cac:af4e%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023
 16:56:12 +0000
Message-ID: <04e068b1-91de-5d88-1e8f-e836cbbd028d@nwra.com>
Date: Tue, 9 May 2023 10:56:08 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Content-Language: en-US
To: "submit@bugs.x2go.org" <submit@bugs.x2go.org>
From: Orion Poplawski <orion@nwra.com>
Subject: Patch for x2goclient Qt5 build on Windows
Organization: NorthWest Research Associates
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms070805050901080702010608"
X-ClientProxiedBy: CY5PR15CA0183.namprd15.prod.outlook.com
 (2603:10b6:930:81::29) To SJ0PR09MB6318.namprd09.prod.outlook.com
 (2603:10b6:a03:26b::14)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR09MB6318:EE_|SJ0PR09MB11493:EE_
X-MS-Office365-Filtering-Correlation-Id: 22e8f055-0190-4e4e-bbc7-08db50ae4b2d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TIAsdp/zpFjAbScJGf1JkdrScbMxhjCPNMnsYwg+SzaMOJ36ctFEDKYmP89GjZrW1hyFngTgqr4WEdbLocSzGSpRu8n3Ma9pzNt9Ij3YkTfE/oFuWsRH42Gw0Vxo3zvNmxoJcQcYS9ohSyn+wbYmVKdwwLwbXSWehmO4ZjENrEMmpW0leO5pWN0jG5s51RqSiDVU96oufkrYOwM5WKw+xzH7PDUy7cd8oZg3/4CTxwYDedacHAINe4S9RGFMibA967B9bloeyvMb/BZLj706Mrj9XxO82QKwfznxKD47WMIhPP4aiyRlIQs/i9U6SXHHe12CuLh4rDp6WFZPP70x8QypPW9Vh0+jED/9OvhYMcX28wvS5CS7OmlLuP25kZkQtkr5V3sdsjYYc4F7kCzeEmN3dXukS943ABexsxHoaOylPjDQbOHFeTCDwa531rmLLK3GIs32eA3EUQAL8EZAPYl7VxtvyyVgZKQxvK/S6Bbh5r4Vq1CoOQkokCWqW0UhmzVXyYW5fZgroi6LWZEPwi4rkjmQNfplXx/DlwWl7aoQoAlO4VVBlc4z2VunTXkWopsukxiE9lnx2OSnvhxWZTj2ICUCPzI06mAD0N97WKVKyavb5UItolRaYHAF+bMfe9b75RfosFrC5wsxlm1l8A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR09MB6318.namprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(366004)(39830400003)(451199021)(26005)(186003)(6506007)(6512007)(6916009)(86362001)(31696002)(66476007)(66946007)(66556008)(508600001)(40140700001)(41320700001)(36756003)(36916002)(33964004)(6666004)(966005)(6486002)(5660300002)(38100700002)(2906002)(41300700001)(8676002)(8936002)(31686004)(235185007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	U1bp+mh71tqtUfw0LhGNxGckHBZUpoSVBcUzAX0+CmjXE3tX9wZoN3JY+r1e+SX0lFZZxGXFxcn/mx+pZ1JHT67l+iP+y4rjyYQRZrnuOHBaHAldeDUmkZ30KDRnPztLNDKVtL9FV33wpYBB23iTNEZ11p+o2fCAlZnm3JhoZVja3tosIDP0t95H1PjzIJjSIGh2TIgwOynrCiCCdWEMRNHF2VSvqjJIzDf8N+L0dypwIdqM1EyBcOJF0mJAcb+gtMEfJJGpc+bEL76gt9HbpTHlD3tXaVG8jI7Jo5JHbREcQkqKaNGsIUfxdk/N3TM5uLse/reoEZAxI3vyjNrCT45kKDEcA9DSNPr4+mMYYJKDRo0aO4VSHcqoEdQ+A2stgx08ojGq0ldpeN+tw5o8j2qBxRRz0OL4Ur2Tx5YG7WErdLVQXzv21hPguL0TXjO+DNuC8tVLZbWA0p+5xljwqYOAFuuHx4FFUNgsOQGd1OGn0XzgfyCvw7mM/0rtCVgkfxRXLyQ0PSfvPHmCGnLn/HYTW9Z8/oipTdSzpO67RfUcptP1BBpCtwCDJDwF6EJh+1D0xTAzRm9jz3w0k2G8NNp9aBVqnk2t9yjjQsjcdDiN4omPcTGTmTl48YGWW0obQbJYpkWK/WKZ0dh5iP/mBUqAQlA+CQ5CUsHDkbO9mk9/B8IimQl11GszLP/t0D5aqd/UZVoIEbilgXMaMvqYotRLNo4CjWdUruaGU8mioExPux/KgNGwCFtqzqvCqIGzB3/Bsd1jxHbVQKL1uVIuboLy9T05UD2gB+Fi3FkwNGzb3GqNoi1VZ+HIWuhgS/XEiMkJ7SCBxfbL7k3xK+RPDlcbM/pYQfhkBYbESm3EsTLpSCUqxwoP7Dp9QdyeeYQF4I8YvH6J3Dg/OTLshL6BKCulKOLH3hzIoYmFNdrs5lVJkZzJ9bEEbYV0ezCDNfiLvyEU0cFsE7xI2mypdDlMtpbKoHkxPCB3jGxijRCcW1/o/WaGHbUi1uOdTCxysREZD9cChfycBMfkKbQHoovdQIR6USSZI6Ok4aiDbJdJlEU5cIszXfxWezBSwdOqEX/CkwQr3T7KAfN3LQsPrKC8w1bB3PRVpqAoFmPbS0WY1TNvC2GM18gCUp2aT8O0MO2zl2MrGi4tInLqorlcg1VkECZkFdt3bHhuIq0Pdg4qe5NLjA4IO7vkuZXW76dDP3AzLxmnVVkC+7qZ2tFUdk4FuEo/ZknfURHqQ6idGOSfmehDR/Un2j4AaD/D6YUeG3ILKpQIqDCOGB83vwlbCZL2G4Is5JGC1W0CY4c0UYAXJT9u/Xx+6FcEEsBf9cvQLh86IsWUoc51QC1uE/BLkiykCBlajT/3O4LBlYth1xOdZLXTSPBcp1sss89Fww88Ho0MUlPBdqI69NNvjI14L92+EHWsHwDHsBB0op8GLhkeRvw+ax/NV0DPW/Ip0m7rhvqK9MlR+usp+utuo0oSb3nlUswawgtuRrQg2vnmumKZ9Xdt1iFEu2I5yv1Jdq+UfQOWO3rKXq+JZHuJw8MfbNDsSfNhtsl7nyWx7G9ItmVw6ALon9bFmo0gjiqzaVwTljqN
X-OriginatorOrg: nwra.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22e8f055-0190-4e4e-bbc7-08db50ae4b2d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR09MB6318.namprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 16:56:11.9901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 761303a3-2ec2-424e-8122-be8b689b4996
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR09MB11493
[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.1.2.2
Tag: patch


When compiling against Qt5 5.15.9 I get:

../src/wapi.cpp: In function 'void wapiSetWindowIcon(HWND, const QPixmap&)':
../src/wapi.cpp:224:88: error: 'class QPixmap' has no member named 
'toWinHICON'
  224 |     largeIcon=icon.scaled(iconx,icony, 
Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();
      |                        ^~~~~~~~~~
../src/wapi.cpp:225:90: error: 'class QPixmap' has no member named 
'toWinHICON'
  225 |     smallIcon=icon.scaled(smallx,smally, 
Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();
      |                          ^~~~~~~~~~

Now, the only call to wapiSetWindowIcon() is commented out, so I just 
commented out the wapiSetWindowIcon() code as we...  Looks like the 
current function to use is QImage::toHICON().

I'm also curious that you need to shift to a Windows API call - 
shouldn't we be able to do everything in Qt?



-- 
Orion Poplawski
he/him/his  - surely the least important thing about me
IT Systems Manager                         720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                 https://www.nwra.com/
[x2goclient-qt5.patch (text/x-patch, attachment)]
[smime.p7s (application/pkcs7-signature, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Apr 24 23:06:16 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.