#1296 - x2gobroker-ssh : wrong password after password change in interactive mode

X2Go Bug report logs - #1296
x2gobroker-ssh : wrong password after password change in interactive mode

Reported by: Walid MOGHRABI <w.moghrabi@servicemagic.eu>

Date: Wed, 9 May 2018 14:55:02 UTC

Severity: normal

Tags: patch

Received: (at 1296) by bugs.x2go.org; 7 Sep 2018 10:29:58 +0000
From mike.gabriel@das-netzwerkteam.de  Fri Sep  7 12:29:22 2018
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=3.0 tests=BAYES_00,RDNS_NONE,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 562255DAEE
	for <1296@bugs.x2go.org>; Fri,  7 Sep 2018 12:29:22 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id E8QfKliJ9-hA for <1296@bugs.x2go.org>;
	Fri,  7 Sep 2018 12:29:15 +0200 (CEST)
Received: from fregna.das-netzwerkteam.de (unknown [IPv6:2a01:4f8:202:1381::1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EEB7E5DA7A
	for <1296@bugs.x2go.org>; Fri,  7 Sep 2018 12:29:14 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [148.251.201.105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id D994560456;
	Fri,  7 Sep 2018 10:29:14 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id CBECEC2668;
	Fri,  7 Sep 2018 12:29:14 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TDVMRccfldNW; Fri,  7 Sep 2018 12:29:09 +0200 (CEST)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 1CC49C2644;
	Fri,  7 Sep 2018 12:29:09 +0200 (CEST)
Received: from [2001:470:6aa7:1f::b] ([2001:470:6aa7:1f::b]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Fri, 07 Sep 2018
 10:29:09 +0000
Date: Fri, 07 Sep 2018 10:29:09 +0000
Message-ID: <20180907102909.Horde.LY8z2TR8NXXvHJNOzzHVeIu@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 1296@bugs.x2go.org
Cc: Walid MOGHRABI <w.moghrabi@servicemagic.eu>
Subject: Re: [X2Go-Dev] Bug#1296: Bug#1296: x2gobroker-ssh : wrong password
 after password change in interactive mode
References: <1192975666.29026000.1525876455368.JavaMail.root@servicemagic.eu>
 <444301251.29030144.1525877413102.JavaMail.root@servicemagic.eu>
 <20180515121911.Horde.vRMMP4iN7ROEhOjVl9eVz5e@mail.das-netzwerkteam.de>
In-Reply-To: <20180515121911.Horde.vRMMP4iN7ROEhOjVl9eVz5e@mail.das-netzwerkteam.de>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 2001:470:6aa7:1f::b
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0
Content-Type: multipart/signed; boundary="=_a0r7RI88a_TaeI2JN4GJ43A";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

Control: reassign -1 x2goclient HI Walid, On Di 15 Mai 2018 14:19:11 CEST, Mike Gabriel wrote: > Control: tags -1 patch > > Hi Walid, > > On Mi 09 Mai 2018 16:50:13 CEST, Walid MOGHRABI wrote: > >> package: x2gobroker-ssh >> version: 0.0.4.0-0~1022~ubuntu16.04.1 >> priority: bug >> >> >> x2gobroker-ssh supports interactive mode which means that it can >> reports login interactions to the user such as password changes >> requests. >> Let's say that my user's password has expired, when I login to the >> broker with x2goclient in broker mode, I'll see a new form asking >> for my old password and I must type/confirm my new password. >> Once done, I'll be granted access to the broker and I'll get my >> session profiles list on the right sidebar of the client. >> Since I'm using --use-broker-pass, I don't have to re-type my >> password when connecting to a session but in that specific use >> case, I get an auth error while connecting because of wrong password. >> >> In fact, it appears that the client keeps the first password that >> has been entered at the broker login prompt (the one that expired) >> when passing it to the session profile. >> Once you get the auth error, you'll be prompted with user/pass for >> the session profile, if you enter the new password, then it works. > > Can you please test, if the below patch fixes your issue? > > ``` > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index eca9451..5ab1dc4 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -1142,6 +1142,7 @@ void ONMainWindow::slotChangeBrokerPass() > return; > } > broker->changePassword(passDlg.newPass()); > + config.brokerPass = passDlg.newPass(); > setStatStatus ( tr ( "Connecting to broker" ) ); > stInfo->insertPlainText ( "broker url: "+config.brokerurl ); > setEnabled ( false ); > ``` I haven't had feedback on the above patch, yet. Can you please test it? Thanks. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:44:58 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #1296 x2gobroker-ssh : wrong password after password change in interactive mode

X2Go Bug report logs - #1296
x2gobroker-ssh : wrong password after password change in interactive mode