From mike.gabriel@das-netzwerkteam.de Fri Sep 7 12:29:22 2018 Received: (at 1296) by bugs.x2go.org; 7 Sep 2018 10:29:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=BAYES_00,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 562255DAEE for <1296@bugs.x2go.org>; Fri, 7 Sep 2018 12:29:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E8QfKliJ9-hA for <1296@bugs.x2go.org>; Fri, 7 Sep 2018 12:29:15 +0200 (CEST) Received: from fregna.das-netzwerkteam.de (unknown [IPv6:2a01:4f8:202:1381::1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EEB7E5DA7A for <1296@bugs.x2go.org>; Fri, 7 Sep 2018 12:29:14 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [148.251.201.105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id D994560456; Fri, 7 Sep 2018 10:29:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id CBECEC2668; Fri, 7 Sep 2018 12:29:14 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TDVMRccfldNW; Fri, 7 Sep 2018 12:29:09 +0200 (CEST) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 1CC49C2644; Fri, 7 Sep 2018 12:29:09 +0200 (CEST) Received: from [2001:470:6aa7:1f::b] ([2001:470:6aa7:1f::b]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Fri, 07 Sep 2018 10:29:09 +0000 Date: Fri, 07 Sep 2018 10:29:09 +0000 Message-ID: <20180907102909.Horde.LY8z2TR8NXXvHJNOzzHVeIu@mail.das-netzwerkteam.de> From: Mike Gabriel To: 1296@bugs.x2go.org Cc: Walid MOGHRABI Subject: Re: [X2Go-Dev] Bug#1296: Bug#1296: x2gobroker-ssh : wrong password after password change in interactive mode References: <1192975666.29026000.1525876455368.JavaMail.root@servicemagic.eu> <444301251.29030144.1525877413102.JavaMail.root@servicemagic.eu> <20180515121911.Horde.vRMMP4iN7ROEhOjVl9eVz5e@mail.das-netzwerkteam.de> In-Reply-To: <20180515121911.Horde.vRMMP4iN7ROEhOjVl9eVz5e@mail.das-netzwerkteam.de> User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 2001:470:6aa7:1f::b X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Content-Type: multipart/signed; boundary="=_a0r7RI88a_TaeI2JN4GJ43A"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_a0r7RI88a_TaeI2JN4GJ43A Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: reassign -1 x2goclient HI Walid, On Di 15 Mai 2018 14:19:11 CEST, Mike Gabriel wrote: > Control: tags -1 patch > > Hi Walid, > > On Mi 09 Mai 2018 16:50:13 CEST, Walid MOGHRABI wrote: > >> package: x2gobroker-ssh >> version: 0.0.4.0-0~1022~ubuntu16.04.1 >> priority: bug >> >> >> x2gobroker-ssh supports interactive mode which means that it can=20=20 >>=20reports login interactions to the user such as password changes=20=20 >>=20requests. >> Let's say that my user's password has expired, when I login to the=20=20 >>=20broker with x2goclient in broker mode, I'll see a new form asking=20= =20 >>=20for my old password and I must type/confirm my new password. >> Once done, I'll be granted access to the broker and I'll get my=20=20 >>=20session profiles list on the right sidebar of the client. >> Since I'm using --use-broker-pass, I don't have to re-type my=20=20 >>=20password when connecting to a session but in that specific use=20=20 >>=20case, I get an auth error while connecting because of wrong password. >> >> In fact, it appears that the client keeps the first password that=20=20 >>=20has been entered at the broker login prompt (the one that expired)=20= =20 >>=20when passing it to the session profile. >> Once you get the auth error, you'll be prompted with user/pass for=20=20 >>=20the session profile, if you enter the new password, then it works. > > Can you please test, if the below patch fixes your issue? > > ``` > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index eca9451..5ab1dc4 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -1142,6 +1142,7 @@ void ONMainWindow::slotChangeBrokerPass() > return; > } > broker->changePassword(passDlg.newPass()); > + config.brokerPass =3D passDlg.newPass(); > setStatStatus ( tr ( "Connecting to broker" ) ); > stInfo->insertPlainText ( "broker url: "+config.brokerurl ); > setEnabled ( false ); > ``` I haven't had feedback on the above patch, yet. Can you please test=20=20 it?=20Thanks. Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_a0r7RI88a_TaeI2JN4GJ43A Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAluSUvQACgkQmvRrMCV3 GzHloA//YHRcL484Tgf49YKC9nrxiXJ/wVlhp9ex8bq1g2qJmys5LbyCzCZyDo9D NM5YMJ8FOPvVAa5cHFcv3sM2RBImkO+DcDyErgjrV3F1aki0ZUKn3NoLB28tg3yW CedozvyF/K6GxXCAsW/eJRl3qola52W5LqaEwgfbNtJnQHnYLLMYDDNkjkND/cY9 VeUe+QDmefSbFfclz+pR050Gvd2rCbjgWQM9oiL/d0Lod7KeVZ/sgAbm3uhksYJK VbiKBHEQw3SQN0xE6vJ+X1e1x6R0e6p7thoknZFzPDyAIWtEZFEwyC5wzcaALmu2 TG8NpEcDRjSCZId/ChYCa3dJuyPKbRZWSEWhDNIfSPitkgsuuNaHdZ4hz13OccRT oNo1BoxBfxxyICXikK4w2u/git9gmyvhhDAs7uOfBZjNQHlhaOGp5hcsCo9upxTH gsRaJLi2FcJEt7y+vHuXdhLnd+BDhNQ6/DGm9J8T6hRz+2hJImR0MWEKanGWOegW kCJxzQwG/jMTMi/SrUAyhAbzX3ScaG+82Wxu80J7OJAehi+GOqdv9+mKHdX0/RkS U8yKAo2ai+NOwXUPTce1gJcUS2y+GoymH19EVlYxwya4j2lH1DbZ0UG9tRNnnTZ4 TEaH35BlWIUzG7tVbibUfpC2UOH8UARziWZxtZ0hyYjabt4W7kA= =s0W3 -----END PGP SIGNATURE----- --=_a0r7RI88a_TaeI2JN4GJ43A--