X2Go Bug report logs - #928
x2goclient overwrites user's shell

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Orion Poplawski <orion@cora.nwra.com>

Date: Tue, 25 Aug 2015 17:30:02 UTC

Severity: normal

Tags: patch, pending

Found in version

Fixed in version

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 25 Aug 2015 17:28:15 +0000
From orion@cora.nwra.com  Tue Aug 25 19:28:13 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from mail.nwra.com (mail.nwra.com [])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 334B05DA80
	for <submit@bugs.x2go.org>; Tue, 25 Aug 2015 19:28:12 +0200 (CEST)
Received: from [] (NORTHWEST-R.edge3.Denver1.Level3.net [])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.nwra.com (Postfix) with ESMTPSA id 24C3134046D
	for <submit@bugs.x2go.org>; Tue, 25 Aug 2015 10:28:10 -0700 (PDT)
To: submit@bugs.x2go.org
From: Orion Poplawski <orion@cora.nwra.com>
Subject: x2goclient overwrites user's shell
Message-ID: <55DCA5A2.2010802@cora.nwra.com>
Date: Tue, 25 Aug 2015 11:28:02 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
MIME-Version: 1.0
Content-Type: multipart/mixed;
[Message part 1 (text/plain, inline)]
Package: x2goclient
Tags: patch

See https://bugzilla.redhat.com/show_bug.cgi?id=1256799

Description of problem:
After upgrading x2goclient my system assigned shell of /bin/zsh is ignored and
forcefully set to /bin/bash

The shift to running everything under /bin/bash had the side effect of setting
SHELL to /bin/bash, which is then what terminal emulators and others use for
spawning shells.

If we specify -l to bash it runs as a login shell, sources the proper startup
files and sets SHELL to whatever getpwent() returns for the login shell.

However, this also opens the door for things like ~/.bash_logout to get run
which executes "clear", which emits:

TERM environment variable not set.

when TERM is empty as it is here.  So we also set TERM=dumb to work around that.

It might be nice to add the ability to distinguish between a session startup
command and other utility commands (x2gomountdirs, etc.) and only add -l to
the session startup commands.  This is probably more appropriate.

Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com
[x2goclient-shell.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Feb 18 15:13:19 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.