X2Go Bug report logs - #922
Avoiding X2GO Servers all using the same SSH_PORT - what conflicts when try to connect to different servers from one windows terminal (multiple sessions of x2go client)

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#922: Fwd: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for creating ports.
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 922@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Wed, 30 Dec 2015 09:55:01 +0000
Resent-Message-ID: <handler.922.B922.145146906130426@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 922
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: pending
Received: via spool by 922-submit@bugs.x2go.org id=B922.145146906130426
          (code B ref 922); Wed, 30 Dec 2015 09:55:01 +0000
Received: (at 922) by bugs.x2go.org; 30 Dec 2015 09:51:01 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2E0605DA4F
	for <922@bugs.x2go.org>; Wed, 30 Dec 2015 10:50:58 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 158909EC
	for <922@bugs.x2go.org>; Wed, 30 Dec 2015 10:50:58 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 98BE33BBBC
	for <922@bugs.x2go.org>; Wed, 30 Dec 2015 10:50:56 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gWmlmiIB+4nB for <922@bugs.x2go.org>;
	Wed, 30 Dec 2015 10:50:56 +0100 (CET)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 27B483BA36
	for <922@bugs.x2go.org>; Wed, 30 Dec 2015 10:50:56 +0100 (CET)
Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de
 [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Wed, 30 Dec 2015 09:50:56 +0000
Date: Wed, 30 Dec 2015 09:50:56 +0000
Message-ID: <20151230095056.Horde.a1sbxA-0fTDMUp2FwXMZcpR@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 922@bugs.x2go.org
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 178.62.101.154
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Firefox/38.0 Iceweasel/38.4.0
Content-Type: multipart/signed; boundary="=_TwxPewhTKQ_BudiNDmUUBuw";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

----- Weitergeleitete Nachricht von Mike Gabriel  
<mike.gabriel@das-netzwerkteam.de> -----
  Datum: Wed, 30 Dec 2015 09:21:20 +0000
    Von: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Betreff: [X2Go-Dev] X2Go Server contains some IPv4/non-IPv6 logic for  
creating ports.
     An: x2go-dev@lists.x2go.org

Hi guys,

On  So 23 Aug 2015 23:10:59 CEST, git-admin wrote:

> This is an automated email from the git hooks/post-receive script.
>
> x2go pushed a commit to branch master
> in repository x2goserver.
>
> commit bfe3ba761c1d3e9143285ca17edc87ac763ce35d
> Author: Mihai Moldovan <ionic@ionic.de>
> Date:   Sun Aug 23 23:08:45 2015 +0200
>
>    x2goserver/bin/x2gostartagent: changes to Robert Nowotny's  
> SSH_PORT patch. Fixes: #922.
>
>    Use default outgoing interface to determine IP address.
>
>    Use the whole range of ${RANDOM}'s pool.
>
>    Seed it for good measure.
>
>    Change the default method to randomization instead of IP-based
>    initialization.
>
>    If IP-based initialization was requested but the default outgoing IP
>    address unavailable, fall back to randomization.
>

Haven't looked at X2Go Server code for a while... Today I found the below...

> +# Get server IP address.
> +get_server_ip_address() {
> +	# The provided IP address should be outside of any local network.
> +	# We are only interested in how the kernel would try to reach the
> +	# non-local IP address specified here. It is not actually contacted
> +	# in any way.
> +	typeset ip_output="$(ip route get 8.8.8.8)"
> +
> +	# Remove newlines.
> +	ip_output="${ip_output//$'\n'}"
> +
> +	# Fetch source address.
> +	typeset src_address="$(grep -oe  
> 'src[[:space:]]\{1,\}\(\([[:digit:]]\{1,3\}\.\)\{3\}[[:digit:]]\{1,3\}\)'  
> <<< "${ip_output}" | sed -e 's/src[[:space:]]\{1,\}//')"
> +
> +	if [ -n "${src_address}" ]; then
> +		printf "${src_address}"
> +		return "0"
> +	fi
> +
> +	return "1"
> +}

Has anyone of you ever heard of IPv6? And has anyone ever seen setups  
where the IPv6 traffic is routed via a different interface compared to  
IPv4 traffic?

Furthermore, within the last years, I never had any problems with  
server-side ports being the same on different servers. I mostly  
connect through PyHoca. So if there is a problem in X2Go Client  
regarding server-side SSH tunnel ports, why--the hack--do you fix that  
in X2Go Server?

If the port allocation is a problem at all, it certainly is a problem  
that requires fixing in X2Go Client, not X2Go Server.

Please consider reverting this flawed patch!!!

Scratching my head and wondering...

Mike

----- Ende der weitergeleiteten Nachricht -----

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.