X2Go Bug report logs - #883
Window Decorations gone when resuming on smaller screen

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#883: [X2Go-Dev] Bug#883: Bug#883: Can be fixed by reverting winmultiwindow.patch
Reply-To: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>, 883@bugs.x2go.org
Resent-From: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 29 Jun 2015 09:40:02 +0000
Resent-Message-ID: <handler.883.B883.143557059310064@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 883
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 883-submit@bugs.x2go.org id=B883.143557059310064
          (code B ref 883); Mon, 29 Jun 2015 09:40:02 +0000
Received: (at 883) by bugs.x2go.org; 29 Jun 2015 09:36:33 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from mail.cowic.de (mx1.cowic.de [80.190.97.241])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 88E005DA85
	for <883@bugs.x2go.org>; Mon, 29 Jun 2015 11:36:31 +0200 (CEST)
Received: from [192.168.0.108] (unknown [95.90.222.39])
	by mail.cowic.de (Postfix) with ESMTP id 5052238075C7;
	Mon, 29 Jun 2015 11:36:31 +0200 (CEST)
Message-ID: <55911193.1090006@phoca-gmbh.de>
Date: Mon, 29 Jun 2015 11:36:19 +0200
From: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Mihai Moldovan <ionic@ionic.de>, 883@bugs.x2go.org
References: <20150623105115.Horde.cJ1xTsfQZTDIgaforyinLQ1@mail.das-netzwerkteam.de> <5589B201.2070208@phoca-gmbh.de> <558A103B.1030709@ionic.de>
In-Reply-To: <558A103B.1030709@ionic.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="Sv8cfUkinDoFnpPStqMuuRqpcCrI3855t"

[Message part 1 (text/plain, inline)]

Hello,

I'll try to explain why I wrote this patch. In x2go client you have
possibility to run x2go session in "full screen" mode on only one of
physical displays. It has nothing to do with xinerama. It is very useful
if you have a client with several monitors and you want to have the
native session on one monitor and  full screen remote session on second
monitor. It's also not a full screen mode, because you are using only a
part of virtual display, so you are not running a vcxsrv in full screen
mode. This scenario widely used in enterprise environments.

To create a full screen window on only one physical display you need to
 maximize the window on this display and remove the window decorations.
Unfortunately on some setups it was not possible to maximize an
X-window. As soon as you tried it, vcsrv resized a window with a size
that was bigger then physical display and reseted a window decorations.
After some investigation I figured out that it's only happening on the
displays with negative coordinates, for example if a secondary display
is left of or on the top of primary display. So I assumed that vcxsrv
doesn't work properly with negative coordinates. Unfortunately I didn't
manage to find a bug in vcxsrv, so I wrote a workaround that checking if
the windows size is bigger than a physical display and in this case
resizing a window on a screen size. Usually it is no ways to create a
windows that are bigger then a physical display, so that workaround
worked well. Unfortunately in the case described in this bug report,
nxagent creating window that is bigger then screen size, because screen
was resized. This is why a firefox or whatever window will be maximized
and window decorations will be erased by a workaround.

I don't think that we can remove this workaround, because it will brake
many productive x2go setups. At least as long as we won't find a bug
handling negative screen sizes in vcxsrv and now I have not sufficient
resources to do it.

I suggest to check in workaround if screen has negative coordinates and
omit any window that placed on the displays with positive coordinates.

Also in x2go client I'll check a window size and decoration flags and
reset it in the case if x2go session is not a multi window session.
This fill fix #883 and won't brake a multi monitor setups.
I'll do it today or tomorrow.

regards,
Alex


Am 24.06.2015 um 04:04 schrieb Mihai Moldovan:
> On 23.06.2015 09:22 PM, Oleksandr Shneyder wrote:
>> I'll look on it on Thursday-Monday,
> 
> I've had a look myself and played around with it, assisted by Mike#2.
> 
> I don't see any benefit in applying this patch and suggest dropping it.
> 
> As far as I've gathered, it's supposed to create a "fake" fullscreen window by
> removing the borders and title bar IFF the window extents are greater or equal
> the monitor's size, with "monitor" being the monitor that holds most of the
> window's contents.
> 
> 
> It doesn't make sense to do something like this in multiwindow mode. It *does*
> make sense to do something like this in fullscreen mode, but the patch targets
> multiwindow mode.
> 
> For this mode, it's plain wrong and only causing trouble. You can't fix it
> either, because you're missing a crucial bit of information: when *do* you want
> to have a "fake" fullscreen window?
> 
> 
> Why did you write the original patch exactly? What was the use case that this
> patch fixed?
> 
> 
> 
> Mihai
> 


-- 
-----------------------------------------------------------
Oleksandr Shneyder        | Email: o.shneyder@phoca-gmbh.de
phoca GmbH                | Tel. : 0911 - 14870374 0
Ludwig-Feuerbach-str. 18  | Fax. : 0911 - 14870374 9
D-90489 Nürnberg          | Mobil: 0163 - 49 64 461

Geschäftsführung:
Dipl.-Inf. Oleksandr Shneyder

Amtsgericht München | http://www.phoca-gmbh.de
HRB 196 658         | http://www.x2go.org
USt-IdNr.: DE281977973
-----------------------------------------------------------

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.