X2Go Bug report logs - #883
Window Decorations gone when resuming on smaller screen

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Thu, 28 May 2015 19:40:01 UTC

Severity: normal

Merged with 886

Fixed in version 4.0.5.0

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#883: [X2Go-Dev] Bug#883: Bug#883: Can be fixed by reverting winmultiwindow.patch
Reply-To: Mihai Moldovan <ionic@ionic.de>, 883@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Wed, 24 Jun 2015 02:05:01 +0000
Resent-Message-ID: <handler.883.B883.143511149014108@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 883
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 883-submit@bugs.x2go.org id=B883.143511149014108
          (code B ref 883); Wed, 24 Jun 2015 02:05:01 +0000
Received: (at 883) by bugs.x2go.org; 24 Jun 2015 02:04:50 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A563D5DA85
	for <883@bugs.x2go.org>; Wed, 24 Jun 2015 04:04:48 +0200 (CEST)
Received: from nopileos.local (home.ionic.de [217.92.117.31])
	by mail.ionic.de (Postfix) with ESMTPSA id 2B16C4F04FA9;
	Wed, 24 Jun 2015 04:04:48 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1435111488; bh=DRxHwFMZNHqLcB4suR04QjCC3Tp0XDBRJ72rlIinuv0=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=WlgGrZPH7d27fWSHOlAmb7MdG/2eduMwb44/l0YibLismYw+8E2+cxSj472UUP2q5
	 mu47Dc1tzrihcVOdCY3QmpBMet1m0o906sys6fvvIpSzOPKAUgv6NmbnE3wPqXcqEy
	 oQQ7P/sx0GbMHvxeAzuCje3z1Kdiuy23vFlKzE9Y=
To: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>, 883@bugs.x2go.org
References: <20150623105115.Horde.cJ1xTsfQZTDIgaforyinLQ1@mail.das-netzwerkteam.de>
 <5589B201.2070208@phoca-gmbh.de>
From: Mihai Moldovan <ionic@ionic.de>
X-Enigmail-Draft-Status: N1110
Message-ID: <558A103B.1030709@ionic.de>
Date: Wed, 24 Jun 2015 04:04:43 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <5589B201.2070208@phoca-gmbh.de>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="76J1jwR1XHM22GV7OVxNmCuSVo80Tu3BW"

[Message part 1 (text/plain, inline)]
On 23.06.2015 09:22 PM, Oleksandr Shneyder wrote:
> I'll look on it on Thursday-Monday,

I've had a look myself and played around with it, assisted by Mike#2.

I don't see any benefit in applying this patch and suggest dropping it.

As far as I've gathered, it's supposed to create a "fake" fullscreen window by
removing the borders and title bar IFF the window extents are greater or equal
the monitor's size, with "monitor" being the monitor that holds most of the
window's contents.


It doesn't make sense to do something like this in multiwindow mode. It *does*
make sense to do something like this in fullscreen mode, but the patch targets
multiwindow mode.

For this mode, it's plain wrong and only causing trouble. You can't fix it
either, because you're missing a crucial bit of information: when *do* you want
to have a "fake" fullscreen window?


Why did you write the original patch exactly? What was the use case that this
patch fixed?



Mihai


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 23 10:17:40 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.