X2Go Bug report logs - #836
defaults.py X2GOBROKER_SESSIONPROFILE_DEFAULTS height/width/fullscreen values prevents client from setting initial geometry on startup

version graph

Package: python-x2gobroker; Maintainer for python-x2gobroker is (unknown); Source for python-x2gobroker is src:x2gobroker.

Reported by: Jason Alavaliant <alavaliant@ra09.com>

Date: Sat, 4 Apr 2015 09:05:01 UTC

Severity: normal

Tags: pending

Found in version 0.0.3.0

Fixed in version 0.0.3.0

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 4 Apr 2015 09:01:34 +0000
From alavaliant@ra09.com  Sat Apr  4 11:01:32 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from thetower.ra09.com (ra09.com [202.124.104.240])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id BBA0D5DAD5
	for <submit@bugs.x2go.org>; Sat,  4 Apr 2015 11:01:31 +0200 (CEST)
Received: from localhost ([127.0.0.1] helo=private.ra09.com)
	by thetower.ra09.com with esmtp (Exim 4.80)
	(envelope-from <alavaliant@ra09.com>)
	id 1YeJxH-00060a-GO
	for submit@bugs.x2go.org; Sat, 04 Apr 2015 22:01:28 +1300
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Sat, 04 Apr 2015 22:01:27 +1300
From: Jason Alavaliant <alavaliant@ra09.com>
To: submit@bugs.x2go.org
Subject: defaults.py X2GOBROKER_SESSIONPROFILE_DEFAULTS height/width/fullscreen values prevents client from setting initial geometry on startup
Message-ID: <c1614e6a1f30fa2b157d04298bd56cd8@private.ra09.com>
X-Sender: alavaliant@ra09.com
User-Agent: Roundcube Webmail/1.0.5
Package: python-x2gobroker
Version: 0.0.3.0

In the same vein as the dpi issue noted in bug #834 the presence of 
default values for height, width and fullscreen in the 
/usr/lib/python2.7/dist-packages/x2gobroker/defaults.py   file under 
theX2GOBROKER_SESSIONPROFILE_DEFAULTS    section prevent the x2goclient 
--geometry option being used to set what default geometry size (or if to 
use fullscreen) to be set by the client even if the admin of the 
x2gobroker setup hasn't defined those values in the 
x2gobroker-sessionprofiles.conf file.

I'd suggest updating the 
/usr/lib/python2.7/dist-packages/x2gobroker/defaults.py file to remove 
the lines
"u'height': 600,"
"u'fullscreen': False,"
"u'width': 800,"
from the X2GOBROKER_SESSIONPROFILE_DEFAULTS section.

In my testing with those default value gone;

* If a height/width/fullscreen values are set in 
x2gobroker-sessionprofiles.conf (which is the default provided in the 
sample config file), then those values are used by the session 
overriding whatever the client has set as it's geometry option.
* If the values aren't set in x2gobroker-sessionprofiles.conf  and a 
--geometry command line argument ISN'T provided to the client then the 
x2goclient defaults of height=600, width=800, fullscreen=False are used 
resulting in the same behaviour as if the defaults previously defined in 
defaults.py were still present.
*  If the values aren't set in x2gobroker-sessionprofiles.conf  and a 
--geometry command line argument IS provided to the client it is then 
used and the user running the x2goclient can pick their own initial 
geometry to start with.

So in default cases having that default value removed shouldn't change 
behavior and it would allow people to configure their starting geometry 
if the x2gobroker admin has permitted it by not providing overriding 
values in the x2gobroker-sessionprofiles.conf file.

Thanks
Jason


Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Fri Dec 6 13:12:03 2019; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.