X2Go Bug report logs - #789
Kerberos 5 auth. reset putty sessions list

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Jozsef Kozo <kojraai@gmail.com>

To: submit@bugs.x2go.org

Subject: Kerberos 5 auth. reset putty sessions list

Date: Mon, 16 Feb 2015 15:11:18 +0100

[Message part 1 (text/plain, inline)]

Package: X2Go Client
Version:  4.0.3.1( Qt-4.8.6 )
OS:        Windows 8.1 Enterprise x64

Dear Dev. Team,

I switched  on "Kerberos 5 (GSSAPI) authentication" on X2Go client and all
my saved Putty sessions are gone. So Saved session list is empty. I tried
to recover from registry but can't.

You can reproduce like this:

1. Save a session to Putty
2. Set  Kerberos 5 (GSSAPI) authentication
3. Connect to X2Go server

Any idea how can i recover my list?

Best,

Jozsef Kozo

[Message part 2 (text/html, inline)]

Message #10 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Michael DePaulo <mikedep333@gmail.com>

To: 789@bugs.x2go.org

Subject: This sounds grave

Date: Tue, 3 Mar 2015 07:35:50 -0500

Control: severity -1 grave
Control: affects -1 = x2goclient
Control: tag -1 build-win32

HI Jozsef,

Sorry to hear that you ran into this bug.

I will look into it ASAP.

Message #21 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Michael DePaulo <mikedep333@gmail.com>

To: 789@bugs.x2go.org

Cc: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>

Subject: I reproduced it

Date: Tue, 3 Mar 2015 07:59:24 -0500

[Message part 1 (text/plain, inline)]

I reproduced this bug on my system:

X2Go Client for Windows 4.0.3.2-20150301-debug
Windows 10 64-bit (build 9926 with latest patches)

I've CC'd the developer who added Windows Kerberos support, Alex.

I've attached the "Sessions" registry key before and after. The test
session I created, uss-phoenix, was clearly deleted.
HKEY_CURRENT_USER\Software\SimonTatham\PuTTY\Sessions\uss-phoenix\

However, there is no indication in the debug log (attached) that the
Sessions key or its subkey was touched.

I'll take a look at the x2goclient source code to figure out what is going on.

-Mike#2

[789-debug-log.txt (text/plain, attachment)]

[789-before.reg (application/octet-stream, attachment)]

[789-after.reg (application/octet-stream, attachment)]

Message #26 received at 789-quiet@bugs.x2go.org (full text, mbox, reply):

From: Michael DePaulo <mikedep333@gmail.com>

To: 789-quiet@bugs.x2go.org

Subject: reassign correctly

Date: Tue, 3 Mar 2015 08:00:01 -0500

Control: reassign -1 x2goclient

Message #33 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Earl Tom <earl_tom@yahoo.com>

To: "789@bugs.x2go.org" <789@bugs.x2go.org>

Subject: Kerberos 5 auth. reset putty sessions list

Date: Wed, 4 Mar 2015 02:35:30 +0000 (UTC)

I think this is a duplicate of bug #625.
There's a snippet of code attached to that bug that looks suspicious.  I think it's trying to delete one session but ends up deleting them all.

This hits me, too, so it would be nice to have it fixed.
My workaround is that I've exported a .reg file of the sessions and import that after starting x2goclient.


Thanks,

-- 

Earl

Message #38 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Michael DePaulo <mikedep333@gmail.com>

To: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>

Cc: 789@bugs.x2go.org

Subject: Re: I reproduced it

Date: Thu, 5 Mar 2015 07:32:53 -0500

On Thu, Mar 5, 2015 at 7:18 AM, Oleksandr Shneyder
<o.shneyder@phoca-gmbh.de> wrote:
> Hm, I think something has changed in Putty since I developed this
> feature. I didn't see this behavior earlier, when I used x2go client
> parallel to putty on my Windows machine. I'll check this.

I think we have always been using PuTTY 0.63 for this feature.

0.64 just came out, but I have not switched the X2Go Client for
Windows builds over to it. Nor have I tested it with X2Go Client for
Windows.

> There is no
> need to use plink any more anyway, since libssh used in Windows client
> has native GSSAPI support.

Are you sure? Windows uses Microsoft SSPI, not GSSAPI.

https://encrypted.google.com/search?hl=en&q=microsoft%20sspi%20vs%20gssapi

> regards,
> Alex

If you want to rebuild libssh:

1. I have my settings for building libssh here:
http://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=blob;f=libssh/0.6.4-x2go1-mingw482_bin/CMake-Show-My-Changes.txt;h=66391e0cfebf4542938dcd71ab1b87dd9c03eca2;hb=HEAD

2. Rather than building 0.6.4 itself, you need to build 0.6.4 with
these patches. 3 of the patches are the 3 commits made immediately
after 0.6.4 released:
http://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=tree;f=libssh/0.6.4-x2go1-mingw482_src;h=a778703ad4118245b33e759d59b2fcb4fd370c37;hb=HEAD

3. The libssh developers recommend using the HEAD of the 0.6.x branch.
You would still apply the pageant patch from #2. I got the MinGW 4.8.2
patch upstreamed on this branch, so no need to apply that:
https://git.libssh.org/projects/libssh.git/log/?h=v0-6

4. #libssh on FreeNode has multiple developers who are very helpful.

-Mike#2

> Am 03.03.2015 um 13:59 schrieb Michael DePaulo:
>> I reproduced this bug on my system:
>>
>> X2Go Client for Windows 4.0.3.2-20150301-debug
>> Windows 10 64-bit (build 9926 with latest patches)
>>
>> I've CC'd the developer who added Windows Kerberos support, Alex.
>>
>> I've attached the "Sessions" registry key before and after. The test
>> session I created, uss-phoenix, was clearly deleted.
>> HKEY_CURRENT_USER\Software\SimonTatham\PuTTY\Sessions\uss-phoenix\
>>
>> However, there is no indication in the debug log (attached) that the
>> Sessions key or its subkey was touched.
>>
>> I'll take a look at the x2goclient source code to figure out what is going on.
>>
>> -Mike#2
[...]

Message #43 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>

To: Michael DePaulo <mikedep333@gmail.com>, 789@bugs.x2go.org

Subject: Re: I reproduced it

Date: Thu, 05 Mar 2015 13:18:01 +0100

[Message part 1 (text/plain, inline)]

Hm, I think something has changed in Putty since I developed this
feature. I didn't see this behavior earlier, when I used x2go client
parallel to putty on my Windows machine. I'll check this. There is no
need to use plink any more anyway, since libssh used in Windows client
has native GSSAPI support.

regards,
Alex

Am 03.03.2015 um 13:59 schrieb Michael DePaulo:
> I reproduced this bug on my system:
> 
> X2Go Client for Windows 4.0.3.2-20150301-debug
> Windows 10 64-bit (build 9926 with latest patches)
> 
> I've CC'd the developer who added Windows Kerberos support, Alex.
> 
> I've attached the "Sessions" registry key before and after. The test
> session I created, uss-phoenix, was clearly deleted.
> HKEY_CURRENT_USER\Software\SimonTatham\PuTTY\Sessions\uss-phoenix\
> 
> However, there is no indication in the debug log (attached) that the
> Sessions key or its subkey was touched.
> 
> I'll take a look at the x2goclient source code to figure out what is going on.
> 
> -Mike#2
> 


-- 
-----------------------------------------------------------
Oleksandr Shneyder        | Email: o.shneyder@phoca-gmbh.de
phoca GmbH                | Tel. : 0911 - 14870374 0
Ludwig-Feuerbach-str. 18  | Fax. : 0911 - 14870374 9
D-90489 Nürnberg          | Mobil: 0163 - 49 64 461

Geschäftsführung:
Dipl.-Inf. Oleksandr Shneyder

Amtsgericht München | http://www.phoca-gmbh.de
HRB 196 658         | http://www.x2go.org
USt-IdNr.: DE281977973
-----------------------------------------------------------

[signature.asc (application/pgp-signature, attachment)]

Message #48 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Michael DePaulo <mikedep333@gmail.com>

To: 789@bugs.x2go.org

Subject: Merging this with #625

Date: Thu, 5 Mar 2015 07:42:27 -0500

Control: forcemerge 625 -1

I just noticed the email about this being a duplicate. Thank you for
help with bug triaging.

Message #63 received at 789@bugs.x2go.org (full text, mbox, reply):

From: Michael DePaulo <mikedep333@gmail.com>

To: 789@bugs.x2go.org

Subject: I fixed this: more info

Date: Sun, 10 May 2015 11:14:15 -0400

This will be fixed in the 1st release of X2Go Client for Windows 4.0.4.0-x.

The bug appeared to be caused by the fact that for at least 1 of the
SSH Processes, procUuid/uuidStr is null.
Thus HKEY_CURRENT_USER\\Software\\SimonTatham\\PuTTY\\Sessions would
be deleted (recursively) instead of only the uuidStr subkey being
deleted.

I fixed it by simply adding a check to SshProcess::rmPuttyReg(). It
now does nothing if uuidStr is empty or null. This is the safest
solution IMHO.

-Mike

Send a report that this bug log contains spam.