X2Go Bug report logs - #783
RPM Pre Script fail on Upgrade (Nightly)

Full log

Message #10 received at 783@bugs.x2go.org (full text, mbox, reply):

Received: (at 783) by bugs.x2go.org; 9 Feb 2015 13:07:56 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Feb  9 14:07:54 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8CEC35DBCA
	for <783@bugs.x2go.org>; Mon,  9 Feb 2015 14:07:54 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 44F9BA3E;
	Mon,  9 Feb 2015 14:07:54 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 35C6C3C278;
	Mon,  9 Feb 2015 14:07:54 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 9pQpJtamVJOt; Mon,  9 Feb 2015 14:07:54 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 0765B3C071;
	Mon,  9 Feb 2015 14:07:54 +0100 (CET)
Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de
 [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 09 Feb 2015 13:07:53 +0000
Date: Mon, 09 Feb 2015 13:07:53 +0000
Message-ID: <20150209130753.Horde.L19M7fVjVKN39pdqOKW9-w1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Schlomo Schapiro <schlomo.schapiro@immobilienscout24.de>,
 783@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#783: RPM Pre Script fail on Upgrade (Nightly)
In-Reply-To: <54D89EBC.9050602@immobilienscout24.de>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 178.62.101.154
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_P9VEr0CFoaheyPZ2puFxUw2";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

Hi Schlomo.

On  Mo 09 Feb 2015 12:49:16 CET, Schlomo Schapiro wrote:

> Package: x2goserver
> Version: 4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6
>
> RPM Upgrades of existing installations fail because of a broken %pre
> script in the x2goserver-common RPM:
>
> Resolving Dependencies
> --> Running transaction check
> ---> Package x2goserver-common.x86_64
> 0:4.1.0.0-0.0x2go1.0.git20150113.1214.heuler.el6 will be updated
> ---> Package x2goserver-common.x86_64
> 0:4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6 will be an update
> --> Finished Dependency Resolution
>
> Dependencies Resolved
>
> ==============================================================================================================================================
>  Package                      Arch
> Version
> Repository                    Size
> ==============================================================================================================================================
> Updating:
>  x2goserver-common            x86_64
> 4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6
> is24-x2go-nightly            7.2 k
>
> Transaction Summary
> ==============================================================================================================================================
> Upgrade       1 Package(s)
>
> Total download size: 7.2 k
> Is this ok [y/N]: y
> Downloading Packages:
> x2goserver-common-4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6.x86_64.rpm
> | 7.2 kB     00:00
> Running rpm_check_debug
> Running Transaction Test
> Transaction Test Succeeded
> Running Transaction
> Error in PREIN scriptlet in rpm package
> x2goserver-common-4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6.x86_64
> groupadd: group 'x2gouser' already exists
> useradd: user 'x2gouser' already exists
> error:
> %pre(x2goserver-common-4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6.x86_64)
> scriptlet failed, exit status 9
> error:   install: %pre scriptlet failed (2), skipping
> x2goserver-common-4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6
> Running post transaction command: report-yum-to-graphite.sh
> x2goserver-common-4.1.0.0-0.0x2go1.0.git20150113.1214.heuler.el6.x86_64
> was supposed to be removed but is not!
>   Verifying  :
> x2goserver-common-4.1.0.0-0.0x2go1.0.git20150113.1214.heuler.el6.x86_64
> 1/2
>   Verifying  :
> x2goserver-common-4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6.x86_64
> 2/2
>
> Failed:
>   x2goserver-common.x86_64
> 0:4.1.0.0-0.0x2go1.0.git20150113.1214.heuler.el6
>
>   x2goserver-common.x86_64
> 0:4.1.0.0-0.0x2go1.0.git20150201.1236.heuler.el6
>
>
> Complete!
>
> The bad script is this:
>
> if getent group x2gouser 1>/dev/null; then
>     groupadd -r x2gouser
> fi
> if getent passwd x2gouser >/dev/null; then
>     useradd -r -g x2gouser -d /var/lib/x2go -s /sbin/nologin \
>             -c "x2go" x2gouser
> fi
>
> It should have a ! in the if clause to only call groupadd / useradd  
> if the group or user DO NOT EXIST!!

Yep, should already have been fixed for several days by [1].

> Don't you test upgrades???

Nope, not always.

/me wonders, if your nightly builds are not obtained from  
packages.x2go.org but from a non-up-to-date repo. Possibly we may have  
a problem in the EPEL-6 nightly builds archive.

Mike


[1]  
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=0838f4686fc0dd15c66840fecd665e38a7ea1bca
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.