X2Go Bug report logs - #757
Segfault of QDialog in a PyQt application

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: PAILLAT Olivier SOPRA GROUP <olivier.paillat@cea.fr>

To: "'submit@bugs.x2go.org'" <submit@bugs.x2go.org>

Subject: RE: Segfault of QDialog in a PyQt application

Date: Thu, 22 Jan 2015 10:07:26 +0000

[Message part 1 (text/plain, inline)]

Package: client
Version: 4.0.3.0
Qt 4.8.6

When we run our PyQt application on our Debian Wheezy computer with an ssh -X connection it work fine
But when we use X2Go to access the computer and we run our application we've got a segmentation fault at the first QDialog opening. (when we run QDialog.exec_).
We recently update the X2Go version and before that update it was working fine.
We found at least one post that describe the same problem in January 2014 on your bug report site :
X2Go Bug report logs - #410
Segfault of _X11TransWritev in libNX_X11.so.6 with libQtGui

Like suggested in this report  if we run a simple application to test an opening of a dialog box it work fine with X2Go

From your experience of this bugs is there any way to solve this problem ?

Sincerely,


Olivier PAILLAT
Agence STIE Sud-Est

[Sopra Steria]

Sopra Steria
780 rue Guillibert de la Lauzière
Pichaury 2 - CS 40496
13593 Aix-en-Provence Cedex 3 - France
Phone: +33 (0)4 42 25 71 46
olivier.paillat@cea.fr<mailto:olivier.paillat@cea.fr> - www.soprasteria.com<http://www.soprasteria.com>

Le contenu de cet e-mail est susceptible d'être confidentiel, soumis au secret professionnel ou protégé par la loi. L'utilisation, la copie et la divulgation non autorisées d'une partie ou de l'intégralité de ce message sont susceptibles d'être illégales. Si vous avez reçu ce message par erreur, supprimez-le après avoir averti l'expéditeur. Les pièces jointes du présent e-mail ont fait l'objet d'un contrôle antivirus. Néanmoins, nous déclinons toute responsabilité concernant les dommages causés par d'éventuels virus.
Pensez à l'environnement avant d'imprimer.

[Message part 2 (text/html, inline)]

[image001.png (image/png, inline)]

Message #10 received at 757@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: PAILLAT Olivier SOPRA GROUP <olivier.paillat@cea.fr>, 757@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#757: Segfault of QDialog in a PyQt application

Date: Thu, 22 Jan 2015 12:52:55 +0000

[Message part 1 (text/plain, inline)]

Control: reassign -1 x2goclient
Control: reassign #758 x2goclient
Control: reassign #760 x2goclient
Control: merge -1 #758
Control: merge -1 #760
Control: tag -1 build-win32
Control: tag -1 moreinfo

Hi Olivier,

On  Do 22 Jan 2015 11:07:26 CET, PAILLAT Olivier SOPRA GROUP wrote:

> Package: client
> Version: 4.0.3.0
> Qt 4.8.6
>
> When we run our PyQt application on our Debian Wheezy computer with  
> an ssh -X connection it work fine
> But when we use X2Go to access the computer and we run our  
> application we've got a segmentation fault at the first QDialog  
> opening. (when we run QDialog.exec_).
> We recently update the X2Go version and before that update it was  
> working fine.
> We found at least one post that describe the same problem in January  
> 2014 on your bug report site :
> X2Go Bug report logs - #410
> Segfault of _X11TransWritev in libNX_X11.so.6 with libQtGui
>
> Like suggested in this report  if we run a simple application to  
> test an opening of a dialog box it work fine with X2Go
>
> From your experience of this bugs is there any way to solve this problem ?

Please send us a little Python snippet that lets your PyQt application crash.

I am currently working on the NX code tree, so your timing for  
submitting this bug is quite good, right now.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #27 received at 757@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: PAILLAT Olivier SOPRA GROUP <olivier.paillat@cea.fr>, 757@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#757: Segfault of QDialog in a PyQt application

Date: Thu, 22 Jan 2015 12:56:16 +0000

[Message part 1 (text/plain, inline)]

Control: reassign -1 nxagent

On  Do 22 Jan 2015 11:07:26 CET, PAILLAT Olivier SOPRA GROUP wrote:

> Package: client
> Version: 4.0.3.0
> Qt 4.8.6

> [ ... ]

> X2Go Bug report logs - #410
> Segfault of _X11TransWritev in libNX_X11.so.6 with libQtGui

This is actually an issue in nxagent (aka x2goagent), not X2Go Client.  
So reassigning.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #34 received at 757@bugs.x2go.org (full text, mbox, reply):

From: PAILLAT Olivier SOPRA GROUP <olivier.paillat@cea.fr>

To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, "757@bugs.x2go.org" <757@bugs.x2go.org>

Subject: RE: [X2Go-Dev] Bug#757: Segfault of QDialog in a PyQt application

Date: Thu, 22 Jan 2015 14:47:12 +0000

[Message part 1 (text/plain, inline)]

Hello,

Thank you for your answer.
I have made a simple python application (see the tar.gz attached) that reproduce the problem
You will need PyQt4 to run it

The command is simple 
python gui.py

if it work it open a QDialog nearly empty
If you reproduce the bug you will end with a segmentation fault with a very brief QDialog opening

Actually we have some doubts about our environment and we won't be surprised if you don't reproduce the bug with your PyQt4
But we want to close some of the paths of explanation of our bug and since it occurs only with X2Go we submit it to you

Regards




Olivier PAILLAT
Agence STIE Sud-Est

Sopra Steria
780 rue Guillibert de la Lauzière
Pichaury 2 - CS 40496
13593 Aix-en-Provence Cedex 3
France
Phone: +33 (0)4 42 25 71 46
olivier.paillat@cea.fr - www.soprasteria.com

Le contenu de cet e-mail est susceptible d'être confidentiel, soumis au secret professionnel ou protégé par la loi. L'utilisation, la copie et la divulgation non autorisées d'une partie ou de l'intégralité de ce message sont susceptibles d'être illégales. Si vous avez reçu ce message par erreur, supprimez-le après avoir averti l'expéditeur. Les pièces jointes du présent e-mail ont fait l'objet d'un contrôle antivirus. Néanmoins, nous déclinons toute responsabilité concernant les dommages causés par d'éventuels virus.
Pensez à l'environnement avant d'imprimer.


-----Message d'origine-----
De : Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de] 
Envoyé : jeudi 22 janvier 2015 13:53
À : PAILLAT Olivier SOPRA GROUP; 757@bugs.x2go.org
Objet : Re: [X2Go-Dev] Bug#757: Segfault of QDialog in a PyQt application

Control: reassign -1 x2goclient
Control: reassign #758 x2goclient
Control: reassign #760 x2goclient
Control: merge -1 #758
Control: merge -1 #760
Control: tag -1 build-win32
Control: tag -1 moreinfo

Hi Olivier,

On  Do 22 Jan 2015 11:07:26 CET, PAILLAT Olivier SOPRA GROUP wrote:

> Package: client
> Version: 4.0.3.0
> Qt 4.8.6
>
> When we run our PyQt application on our Debian Wheezy computer with an 
> ssh -X connection it work fine But when we use X2Go to access the 
> computer and we run our application we've got a segmentation fault at 
> the first QDialog opening. (when we run QDialog.exec_).
> We recently update the X2Go version and before that update it was 
> working fine.
> We found at least one post that describe the same problem in January
> 2014 on your bug report site :
> X2Go Bug report logs - #410
> Segfault of _X11TransWritev in libNX_X11.so.6 with libQtGui
>
> Like suggested in this report  if we run a simple application to test 
> an opening of a dialog box it work fine with X2Go
>
> From your experience of this bugs is there any way to solve this problem ?

Please send us a little Python snippet that lets your PyQt application crash.

I am currently working on the NX code tree, so your timing for submitting this bug is quite good, right now.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[BUG_757_QDialog.tar.gz (application/x-gzip, attachment)]

Message #39 received at 757@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: PAILLAT Olivier SOPRA GROUP <olivier.paillat@cea.fr>

Cc: 757@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#757: Segfault of QDialog in a PyQt application

Date: Fri, 15 May 2015 13:33:26 +0000

[Message part 1 (text/plain, inline)]

Control: forcemerge #875 -1

Hi Olivier,

On  Do 22 Jan 2015 15:47:12 CET, PAILLAT Olivier SOPRA GROUP wrote:

> Hello,
>
> Thank you for your answer.
> I have made a simple python application (see the tar.gz attached)  
> that reproduce the problem
> You will need PyQt4 to run it
>
> The command is simple
> python gui.py
>
> if it work it open a QDialog nearly empty
> If you reproduce the bug you will end with a segmentation fault with  
> a very brief QDialog opening
>
> Actually we have some doubts about our environment and we won't be  
> surprised if you don't reproduce the bug with your PyQt4
> But we want to close some of the paths of explanation of our bug and  
> since it occurs only with X2Go we submit it to you
>
> Regards

Sorry for getting back so late. We are currently working on the  
nx-libs 3.6.x release and I have just tested your GUI example under  
the development version of nx-libs.

The issue seems to be fixed there. I will merge this bug into #875  
which is the tracking bug for the nx-libs 3.6.x upgrade in X2Go.

Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #58 received at 875@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 875@bugs.x2go.org

Subject: disconnecting #875 from #757, #758, #760 and closing

Date: Sat, 20 Feb 2016 20:29:00 +0000

[Message part 1 (text/plain, inline)]

Control: unmerge -1
Control: close -1

The original idea for #875 was to use one bug to track all issues that  
will be fixed in nx-libs 3.6.x. This is not really practical by  
various reasons, so the idea got dropped.

Thus closing this "tracking" bug...

Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Message #63 received at 757@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 757-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 757@bugs.x2go.org

Subject: X2Go issue (in src:nx-libs) has been marked as pending for release

Date: Sat, 20 Feb 2016 21:37:06 +0100 (CET)

tag #757 pending
fixed #757 2:3.5.0.33
thanks

Hello,

X2Go issue #757 (src:nx-libs) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=45a7989

The issue will most likely be fixed in src:nx-libs (2:3.5.0.33).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 45a7989c51e128839455635fb4949b2fbfc2b995
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Sat Feb 20 21:35:27 2016 +0100

    debian/changelog: Add closures for #757, #758, #760. The issue occurred earlier (#410) and was resolved by properly setting up Xinerama symlinks

diff --git a/debian/changelog b/debian/changelog
index efb0200..df8092d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,7 @@ nx-libs (2:3.5.0.33-0x2go1) UNRELEASED; urgency=low
     + Revert 5a9f829. Make sure libnx-Xinerama1 based Xinerama works
       again with X2Go on Debian based systems. 
     + Enforce symlink creation for Xinerama et al. library symlinks.
+      (Fixes: #757, #758, #760).
   * Xinerama symlinking: Attach Xinerama symlinking to nxagent bin:package (and
     not libnx-xinerama1).
     Backported from Arctica GH 3.6.x branch.

Message #75 received at 757@bugs.x2go.org (full text, mbox, reply):

From: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

To: 757-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 757@bugs.x2go.org

Subject: X2Go issue (in src:nx-libs) has been marked as closed

Date: Wed, 8 Nov 2017 09:01:39 +0100 (CET)

close #757
thanks

Hello,

we are very hopeful that X2Go issue #757 reported by you
has been resolved in the new release (2:3.5.0.33) of the
X2Go source project »src:nx-libs«.

You can view the complete changelog entry of src:nx-libs (2:3.5.0.33)
below, and you can use the following link to view all the code changes
between this and the last release of src:nx-libs.

    http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=4767b533a81ddb6456188ef765615ca3169e1145;hp=023bc5a6217fb0cdd9c98a81c106abc8438c0b6c

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:nx-libs.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:nx-libs
Version: 2:3.5.0.33-0x2go1
Status: RELEASE
Date: Wed, 08 Nov 2017 08:07:54 +0100
Fixes: 757 758 760 1160
Changes:
 nx-libs (2:3.5.0.33-0x2go1) RELEASED; urgency=low
 .
   [ Mihai Moldovan ]
   * debian/control:
     - Add xkb-data to nxagent's Recommends.
     - Uploaders: add myself. Also, force a rebuild due to the changed
       versioning.
     - Add Breaks statement on pre-4.1.0.0 x2goserver to x2goagent package.
     - Change Breaks statement to pre-4.0.1.21 x2goserver and add a Replaces:
       x2goserver << 4.0.1.21 section to x2goagent package. We'll do the
       /etc/x2go/x2goagent.options file move for x2goserver 4.0.1.21 and
       nx-libs 3.5.0.33 already.
   * nx-libs.spec:
     - Add xkeyboard-config to nxagent's Requires. Should be a weak dependency,
       but RPM doesn't support that too well yet.
     - Copy new debian/x2goagent.options file into build environment, analogous
       to what debian/roll-tarballs.sh does.
     - Add new x2goagent.options file to installed file list of x2goagent
       package.
     - Let x2goagent package satisfy x2goagent-virtual.
     - Add -mno-vxs to general C(XX)FLAGS on ppc64le.
       Hopefully just a temporary workaround until
       https://bugzilla.redhat.com/show_bug.cgi?id=1489712 /
       https://bugs.centos.org/view.php?id=13779 are resolved.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     - Drop ugly sed hack to push optflags to build system.
     - Pass CDEBUGSFLAGS and friends directly to the make command in %build.
     - Let x2goagent conflict with pre-4.0.1.21 x2goserver versions. Needed for
       x2goagent.options file move.
   * debian/:
     - Add x2goagent.options file for compatibility with x2goserver nightly.
   * debian/roll-tarballs.sh:
     - Copy new debian/x2goagent.options file into real tarball environment.
   * debian/Makefile.nx-libs:
     - Install/destroot new x2goagent.options file.
   * debian/rules:
     - Symlink and remove new debian/x2goagent.options file into/from build
       environment.
   * debian/x2goagent.install:
     - Add new x2goagent.options file.
   * Refresh:
     - 0016_nx-X11_install-location.debian.patch
     - 9900-dxpc-license-history.full+lite.patch
   * nx-X11: use the "old", non-NX header location.
     Affects:
     - 1270_nx-X11_CVE-2017-2624-Use-timingsafe_memcmp-to-c.full.patch
   * {debian/control,nx-libs.spec}:
     - Add proper dependencies upon xkbcomp for RPM and DEB packages.
       Fixes: #1160.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
   * debian/patches:
     - Refresh all patches. Removes some fuzziness and adds the -p diff option
       to show the C function name in hunk headers.
     - Fixup series file to include previous patch.
   * nxcomp: Handle launchd sockets in DISPLAY variable correctly when fetching
     X cookie.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
       - debian/patches/1600_nxcomp-handle-launchd-socket-in-Auth.full+lite.patch
   * nxcomp: Hardcode X11 and (legacy/xfs) font UNIX paths.
     Fixes: ArcticaProject/nx-libs#536
     Allowing overrides via NX_TEMP and TEMP breaks system using
     pam_tmpdir.so and most server infrastructure expects the location to be
     fixed anyway.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
       - debian/patches/1610_nxcomp-harcode-some-UNIX-socket-path.full+lite.patch
   * Mid-release fixup:
     - Rename
       debian/patches/1400_nx-X11_Render.c-Improve-situation-fo.full+lite.patch
       to
       debian/patches/1400_nx-X11_Render.c-Improve-situation-fo.full.patch.
     - Split up
       debian/patches/1500_all_propagate-optflags-to-subcompone.full+lite.patch.
       Put server changes into
       debian/patches/1500_all_propagate-optflags-to-subcompone.full.patch
       and keep client changes local to
       debian/patches/1510_all_propagate-optflags-to-subcompone.full+lite.patch.
 .
   [ Mike Gabriel ]
   * debian/libxinerama1.postinst.in:
     + Revert 5a9f829. Make sure libnx-Xinerama1 based Xinerama works
       again with X2Go on Debian based systems.
     + Enforce symlink creation for Xinerama et al. library symlinks.
       (Fixes: #757, #758, #760).
   * Xinerama symlinking: Attach Xinerama symlinking to nxagent bin:package (and
     not libnx-xinerama1).
     Backported from Arctica GH 3.6.x branch.
   * debian/Makefile.nx-libs:
     + Make sure that 'make all' only calls 'make build' and _not_ the global
       '%:' ruleset afterwards.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
   * buildsystem:
     - OPTFLAGS: Properly propagate build option flags to nxcomp{,ext,shad} and
       the nx-X11 build scripts.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
       Adds:
       - debian/patches/1500_all_propagate-optflags-to-subcompone.full+lite.patch
 .
   [ Ulrich Sibiller ]
   * nx-X11: Backport CVE-2017-2624 (timingsafe_memcmp)
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.6.x (Ulrich Sibiller)
     v3: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - 1270_nx-X11_CVE-2017-2624-Use-timingsafe_memcmp-to-c.full.patch
 .
   [ Oleksandr Shneyder ]
   * nxcomp: Set TokenSize to 1536 for link type ADSL and WAN.
     Improving non-xrender based browser scrolling behaviour when link type is
     set to ADSL or WAN.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - debian/patches/1300_nxcomp_Set-TokenSize-to-1536-for-lin.full+lite.patch
   * nx-X11: Render.c: Improve situation for multiple trapezoid requests.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - debian/patches/1400_nx-X11_Render.c-Improve-situation-fo.full+lite.patch
 .
   [ Simon Matter ]
   * nxcomp: Reduce control->TokenSize slightly again in order to fix
     fragmentation of packages when on VPN (or otherwise encapsulated)
     connections.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - debian/patches/1301_nxcomp_Reduce-TokenSize-slightly-for.full+lite.patch

Message #80 received at 757@bugs.x2go.org (full text, mbox, reply):

From: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

To: 757-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 757@bugs.x2go.org

Subject: X2Go issue (in src:nx-libs) has been marked as closed

Date: Wed, 8 Nov 2017 09:01:21 +0100 (CET)

close #757
thanks

Hello,

we are very hopeful that X2Go issue #757 reported by you
has been resolved in the new release (2:3.5.0.33) of the
X2Go source project »src:nx-libs«.

You can view the complete changelog entry of src:nx-libs (2:3.5.0.33)
below, and you can use the following link to view all the code changes
between this and the last release of src:nx-libs.

    http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=6b3ec7c5f8de7496584fa2601bb404efa32a1296;hp=7dacd79938801af11cd1f3a8026ff073c38697b1

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:nx-libs.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:nx-libs
Version: 2:3.5.0.33-0x2go1
Status: RELEASE
Date: Wed, 08 Nov 2017 08:07:54 +0100
Fixes: 757 758 760 1160
Changes:
 nx-libs (2:3.5.0.33-0x2go1) RELEASED; urgency=low
 .
   [ Mihai Moldovan ]
   * debian/control:
     - Add xkb-data to nxagent's Recommends.
     - Uploaders: add myself. Also, force a rebuild due to the changed
       versioning.
     - Add Breaks statement on pre-4.1.0.0 x2goserver to x2goagent package.
     - Change Breaks statement to pre-4.0.1.21 x2goserver and add a Replaces:
       x2goserver << 4.0.1.21 section to x2goagent package. We'll do the
       /etc/x2go/x2goagent.options file move for x2goserver 4.0.1.21 and
       nx-libs 3.5.0.33 already.
   * nx-libs.spec:
     - Add xkeyboard-config to nxagent's Requires. Should be a weak dependency,
       but RPM doesn't support that too well yet.
     - Copy new debian/x2goagent.options file into build environment, analogous
       to what debian/roll-tarballs.sh does.
     - Add new x2goagent.options file to installed file list of x2goagent
       package.
     - Let x2goagent package satisfy x2goagent-virtual.
     - Add -mno-vxs to general C(XX)FLAGS on ppc64le.
       Hopefully just a temporary workaround until
       https://bugzilla.redhat.com/show_bug.cgi?id=1489712 /
       https://bugs.centos.org/view.php?id=13779 are resolved.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     - Drop ugly sed hack to push optflags to build system.
     - Pass CDEBUGSFLAGS and friends directly to the make command in %build.
     - Let x2goagent conflict with pre-4.0.1.21 x2goserver versions. Needed for
       x2goagent.options file move.
   * debian/:
     - Add x2goagent.options file for compatibility with x2goserver nightly.
   * debian/roll-tarballs.sh:
     - Copy new debian/x2goagent.options file into real tarball environment.
   * debian/Makefile.nx-libs:
     - Install/destroot new x2goagent.options file.
   * debian/rules:
     - Symlink and remove new debian/x2goagent.options file into/from build
       environment.
   * debian/x2goagent.install:
     - Add new x2goagent.options file.
   * Refresh:
     - 0016_nx-X11_install-location.debian.patch
     - 9900-dxpc-license-history.full+lite.patch
   * nx-X11: use the "old", non-NX header location.
     Affects:
     - 1270_nx-X11_CVE-2017-2624-Use-timingsafe_memcmp-to-c.full.patch
   * {debian/control,nx-libs.spec}:
     - Add proper dependencies upon xkbcomp for RPM and DEB packages.
       Fixes: #1160.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
   * debian/patches:
     - Refresh all patches. Removes some fuzziness and adds the -p diff option
       to show the C function name in hunk headers.
     - Fixup series file to include previous patch.
   * nxcomp: Handle launchd sockets in DISPLAY variable correctly when fetching
     X cookie.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
       - debian/patches/1600_nxcomp-handle-launchd-socket-in-Auth.full+lite.patch
   * nxcomp: Hardcode X11 and (legacy/xfs) font UNIX paths.
     Fixes: ArcticaProject/nx-libs#536
     Allowing overrides via NX_TEMP and TEMP breaks system using
     pam_tmpdir.so and most server infrastructure expects the location to be
     fixed anyway.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
       - debian/patches/1610_nxcomp-harcode-some-UNIX-socket-path.full+lite.patch
   * Mid-release fixup:
     - Rename
       debian/patches/1400_nx-X11_Render.c-Improve-situation-fo.full+lite.patch
       to
       debian/patches/1400_nx-X11_Render.c-Improve-situation-fo.full.patch.
     - Split up
       debian/patches/1500_all_propagate-optflags-to-subcompone.full+lite.patch.
       Put server changes into
       debian/patches/1500_all_propagate-optflags-to-subcompone.full.patch
       and keep client changes local to
       debian/patches/1510_all_propagate-optflags-to-subcompone.full+lite.patch.
 .
   [ Mike Gabriel ]
   * debian/libxinerama1.postinst.in:
     + Revert 5a9f829. Make sure libnx-Xinerama1 based Xinerama works
       again with X2Go on Debian based systems.
     + Enforce symlink creation for Xinerama et al. library symlinks.
       (Fixes: #757, #758, #760).
   * Xinerama symlinking: Attach Xinerama symlinking to nxagent bin:package (and
     not libnx-xinerama1).
     Backported from Arctica GH 3.6.x branch.
   * debian/Makefile.nx-libs:
     + Make sure that 'make all' only calls 'make build' and _not_ the global
       '%:' ruleset afterwards.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
   * buildsystem:
     - OPTFLAGS: Properly propagate build option flags to nxcomp{,ext,shad} and
       the nx-X11 build scripts.
       Backported from Arctica GH 3.6.x branch.
       v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
       Adds:
       - debian/patches/1500_all_propagate-optflags-to-subcompone.full+lite.patch
 .
   [ Ulrich Sibiller ]
   * nx-X11: Backport CVE-2017-2624 (timingsafe_memcmp)
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.6.x (Ulrich Sibiller)
     v3: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - 1270_nx-X11_CVE-2017-2624-Use-timingsafe_memcmp-to-c.full.patch
 .
   [ Oleksandr Shneyder ]
   * nxcomp: Set TokenSize to 1536 for link type ADSL and WAN.
     Improving non-xrender based browser scrolling behaviour when link type is
     set to ADSL or WAN.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - debian/patches/1300_nxcomp_Set-TokenSize-to-1536-for-lin.full+lite.patch
   * nx-X11: Render.c: Improve situation for multiple trapezoid requests.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - debian/patches/1400_nx-X11_Render.c-Improve-situation-fo.full+lite.patch
 .
   [ Simon Matter ]
   * nxcomp: Reduce control->TokenSize slightly again in order to fix
     fragmentation of packages when on VPN (or otherwise encapsulated)
     connections.
     Backported from Arctica GH 3.6.x branch.
     v2: backport to nx-libs 3.5.0.x (Mihai Moldovan)
     Adds:
     - debian/patches/1301_nxcomp_Reduce-TokenSize-slightly-for.full+lite.patch

Send a report that this bug log contains spam.