X2Go Bug report logs - #722
add sanity checks when processing stdout of X2Go

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 7 Jan 2015 17:56:46 +0000
From orion@cora.nwra.com  Wed Jan  7 18:56:44 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from mail.nwra.com (mail.nwra.com [192.163.220.161])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 39F275DB53
	for <submit@bugs.x2go.org>; Wed,  7 Jan 2015 18:56:43 +0100 (CET)
Received: from [10.10.20.7] (NORTHWEST-R.edge3.Denver1.Level3.net [4.28.99.98])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.nwra.com (Postfix) with ESMTPSA id 3757060445
	for <submit@bugs.x2go.org>; Wed,  7 Jan 2015 17:56:37 +0000 (UTC)
Message-ID: <54AD7354.2010500@cora.nwra.com>
Date: Wed, 07 Jan 2015 10:56:36 -0700
From: Orion Poplawski <orion@cora.nwra.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: submit@bugs.x2go.org
Subject: Fwd: [Bug 1179869] New: [abrt] x2goclient: ref(): x2goclient killed
 by SIGSEGV
References: <bug-1179869-140047@bugzilla.redhat.com>
In-Reply-To: <bug-1179869-140047@bugzilla.redhat.com>
X-Forwarded-Message-Id: <bug-1179869-140047@bugzilla.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Package: x2goclient
Version: 4.0.2.1

This crashing here:
x2goSession ONMainWindow::getSessionFromString ( const QString& string )
{
    QStringList lst=string.split ( '|' );
    x2goSession s;
    s.agentPid=lst[0];
    s.sessionId=lst[1];

looks like the session string is corrupted and doesn't have the expected
number of elements.  Need some error checking here.


-------- Forwarded Message --------
Subject: [Bug 1179869] New: [abrt] x2goclient: ref(): x2goclient killed by SIGSEGV
Date: Wed, 07 Jan 2015 17:05:11 +0000
From: bugzilla@redhat.com
To: orion@cora.nwra.com

https://bugzilla.redhat.com/show_bug.cgi?id=1179869

            Bug ID: 1179869
           Summary: [abrt] x2goclient: ref(): x2goclient killed by SIGSEGV
           Product: Fedora
           Version: 20
         Component: x2goclient
          Assignee: orion@cora.nwra.com
          Reporter: livyathan@gmail.com
        QA Contact: extras-qa@fedoraproject.org
                CC: orion@cora.nwra.com



Version-Release number of selected component:
x2goclient-4.0.2.1-1.fc20

Additional info:
reporter:       libreport-2.2.3
backtrace_rating: 4
cmdline:        x2goclient
crash_function: ref
executable:     /usr/bin/x2goclient
kernel:         3.16.6-203.fc20.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 ref at ../../src/corelib/arch/qatomic_x86_64.h:121
 #1 QString::operator= at tools/qstring.cpp:1410
 #2 ONMainWindow::getSessionFromString at ../onmainwindow.cpp:3657
 #3 ONMainWindow::selectSession at ../onmainwindow.cpp:4364
 #4 ONMainWindow::slotListSessions at ../onmainwindow.cpp:3629
 #5 ONMainWindow::qt_static_metacall at moc_onmainwindow.cpp:385
 #6 QMetaObject::activate at kernel/qobject.cpp:3567
 #7 SshProcess::sshFinished at moc_sshprocess.cpp:140
 #8 SshProcess::slotChannelClosed at ../sshprocess.cpp:443
 #9 SshProcess::qt_static_metacall at moc_sshprocess.cpp:84

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

Send a report that this bug log contains spam.