X2Go Bug report logs - #642
Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: "George Trakatelis" <trakatelis@uom.edu.gr>

Date: Wed, 15 Oct 2014 14:50:01 UTC

Severity: wishlist

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.2

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


Message #40 received at 642@bugs.x2go.org (full text, mbox, reply):

Received: (at 642) by bugs.x2go.org; 28 Oct 2014 07:55:12 +0000
From mike.gabriel@das-netzwerkteam.de  Tue Oct 28 08:55:10 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 3C9D95DB3B
	for <642@bugs.x2go.org>; Tue, 28 Oct 2014 08:55:10 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id AEB8D1D44;
	Tue, 28 Oct 2014 08:55:09 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 9C8BD3BB5F;
	Tue, 28 Oct 2014 08:55:09 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id HmCvKxK-g+H8; Tue, 28 Oct 2014 08:55:09 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 1A5703BB45;
	Tue, 28 Oct 2014 08:55:09 +0100 (CET)
Received: from 212.51.14.250 ([212.51.14.250]) by mail.das-netzwerkteam.de
 (Horde Framework) with HTTP; Tue, 28 Oct 2014 07:55:09 +0000
Date: Tue, 28 Oct 2014 07:55:09 +0000
Message-ID: <20141028075509.Horde.alDesymTpPfVMqGsvA6MeQ1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: George Trakatelis <trakatelis@uom.edu.gr>, 642@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows
 to enable it conform to Visual Studio's stricter type checking
References: <20141015203358.Horde.KocdhaNWJNwyU7IDPf0Pug5@mail.das-netzwerkteam.de>
 <543F84ED.6030207@phoca-gmbh.de>
 <CAMKht8ggkVX2zF8wf5AFrNqGODAB+10EcX9VW0SN4K_XCaaSpg@mail.gmail.com>
 <20141016143029.Horde.DtEVLqASiFwRgVFw5c35nw1@mail.das-netzwerkteam.de>
 <000301cff26e$40b79090$c226b1b0$@edu.gr>
In-Reply-To: <000301cff26e$40b79090$c226b1b0$@edu.gr>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 212.51.14.250
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_JrZbhxHiiYQ-NAibwDKp_A1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Hi George,

On  Di 28 Okt 2014 06:15:54 CET, George Trakatelis wrote:

> Hi Michael,
>
> Now that release 4.0.3.0 of x2goclient is out,
> I attach my proposed changes and comment on each one:
>
> 1. conform-to-stricter-type-checking-mingw482.patch
>
> Even mingw's debug build complains about this char *
> not having been declared as ought to be (const char *)
> and suggests using -fpermissive (not recommended).
>
> 2. conform-to-stricter-type-checking-VS2010.patch
>
> a. A type-cast to match one of pow's declarations {float pow(float  
> x, int y);}
> b. In pure Windows there's no close() function to close a socket.
>    So you have to use closesocket() instead.
> c. Include winsock2.h just before windows.h (also recommended by mingw).
>
> 3. add-libraries-to-build-with-VS2010.patch
>
> a. A new batch file to configure x2goclient for VS2010 build  
> (config_win_vs.bat).
> I have just substituted nmake for mingw32-make.
> Please remember to also use 'nmake' or 'nmake debug' when building.
> b. Added necessary win32 libraries.
>
> George

Thanks a lot for providing those patches.

Will applying all those patches provide enough reason/solution to  
close this bug (#642)?

Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 28 07:31:26 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.