X2Go Bug report logs - #642
Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: "George Trakatelis" <trakatelis@uom.edu.gr>

Date: Wed, 15 Oct 2014 14:50:01 UTC

Severity: wishlist

Tags: pending

Found in version

Fixed in version

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #35 received at 642@bugs.x2go.org (full text, mbox, reply):

Received: (at 642) by bugs.x2go.org; 28 Oct 2014 05:16:00 +0000
From trakatelis@uom.edu.gr  Tue Oct 28 06:15:59 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id D2C2E5DB3B
	for <642@bugs.x2go.org>; Tue, 28 Oct 2014 06:15:58 +0100 (CET)
Received: by mail-wg0-f52.google.com with SMTP id y10so4608148wgg.11
        for <642@bugs.x2go.org>; Mon, 27 Oct 2014 22:15:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
X-Gm-Message-State: ALoCoQmExwKVr/Wflt7/vgwPyqXQ7FRwnUbWlnpLewWQu7aie8B+7TDmSDiwjZnwc/yq1KVz7wbm
X-Received: by with SMTP id f4mr24912505wiz.10.1414473358366;
        Mon, 27 Oct 2014 22:15:58 -0700 (PDT)
Received: from HomePC ([])
        by mx.google.com with ESMTPSA id hk9sm448323wjb.46.2014.
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Mon, 27 Oct 2014 22:15:57 -0700 (PDT)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: <642@bugs.x2go.org>
Cc: "'Mike DePaulo'" <mikedep333@gmail.com>
References: <20141015203358.Horde.KocdhaNWJNwyU7IDPf0Pug5@mail.das-netzwerkteam.de> <543F84ED.6030207@phoca-gmbh.de> <CAMKht8ggkVX2zF8wf5AFrNqGODAB+10EcX9VW0SN4K_XCaaSpg@mail.gmail.com> <20141016143029.Horde.DtEVLqASiFwRgVFw5c35nw1@mail.das-netzwerkteam.de>
In-Reply-To: <20141016143029.Horde.DtEVLqASiFwRgVFw5c35nw1@mail.das-netzwerkteam.de>
Subject: RE: [X2Go-Dev] Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Date: Tue, 28 Oct 2014 07:15:54 +0200
Message-ID: <000301cff26e$40b79090$c226b1b0$@edu.gr>
MIME-Version: 1.0
Content-Type: multipart/mixed;
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: Ac/pTb0EfPGmi37oQp2CkCYXZA8JywJEqGzQ
Content-Language: el
[Message part 1 (text/plain, inline)]
Hi Michael,

Now that release of x2goclient is out, 
I attach my proposed changes and comment on each one:

1. conform-to-stricter-type-checking-mingw482.patch

Even mingw's debug build complains about this char * 
not having been declared as ought to be (const char *) 
and suggests using -fpermissive (not recommended).

2. conform-to-stricter-type-checking-VS2010.patch

a. A type-cast to match one of pow's declarations {float pow(float x, int y);}
b. In pure Windows there's no close() function to close a socket. 
   So you have to use closesocket() instead.
c. Include winsock2.h just before windows.h (also recommended by mingw).

3. add-libraries-to-build-with-VS2010.patch

a. A new batch file to configure x2goclient for VS2010 build (config_win_vs.bat). 
I have just substituted nmake for mingw32-make. 
Please remember to also use 'nmake' or 'nmake debug' when building.
b. Added necessary win32 libraries.


> -----Original Message-----
> From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de]
> Sent: Thursday, October 16, 2014 5:30 PM
> To: Michael DePaulo
> Cc: 642@bugs.x2go.org; Oleksandr Shneyder; o.schneyder@phoca-gmbh.de;
> George Trakatelis
> Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for
> Windows to enable it conform to Visual Studio's stricter type checking
> Hi Mike#2
> On  Do 16 Okt 2014 16:16:16 CEST, Michael DePaulo wrote:
> > I can merge it this evening. But should we merge it right before we
> > release
> >
> No, please wait till is out.
> Mike
> --
> mike gabriel, herweg 7, 24357 fleckeby
> fon: +49 (1520) 1976 148
> GnuPG Key ID 0x25771B31
> mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
> freeBusy:
> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-
> netzwerkteam.de.xfb
[conform-to-stricter-type-checking-mingw482.patch (application/octet-stream, attachment)]
[conform-to-stricter-type-checking-VS2010.patch (application/octet-stream, attachment)]
[add-libraries-to-build-with-VS2010.patch (application/octet-stream, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 28 08:25:43 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.