#611 - X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has characters from languages other than the system locale

X2Go Bug report logs - #611
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has characters from languages other than the system locale

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: normal

Found in version 4.0.2.1

Subject: Bug#566: [X2Go-Dev] Bug#566: Bug#566: X2Go Client for Windows 4.0.2.1 cannon create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-English characters
Reply-To: Michael DePaulo <mikedep333@gmail.com>, 566@bugs.x2go.org
Resent-From: Michael DePaulo <mikedep333@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
Resent-Date: Sun, 07 Sep 2014 04:45:01 +0000
Resent-Message-ID: <handler.566.B566.14100650689530@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
MIME-Version: 1.0
In-Reply-To: <CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
	<handler.566.B.140775428816658.ack@bugs.x2go.org>
	<000001cfc60a$32831de0$978959a0$@gr>
	<20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
	<CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
Date: Sun, 7 Sep 2014 00:44:25 -0400
Message-ID: <CAMKht8jxisag8A9F3yFBSg3BQ+PODLzrayu90S0G8OaQKZXtfQ@mail.gmail.com>
From: Michael DePaulo <mikedep333@gmail.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 566@bugs.x2go.org
Cc: trakatelis@uom.gr, George Trakatelis <trakatelis@uom.edu.gr>
Content-Type: multipart/mixed; boundary=047d7bb0398c6f50e90502725b88

[Message part 1 (text/plain, inline)]

Hi George, 1st, please use either "diff -c" or "git diff" to prepare the patch. You can even use "git diff" on a files/folders that are outisde of a git source tree. 2nd, I tried what I think was your patch. I've attached the change I used, it is outputted with "git diff". I used the x2goclient master branch (4.0.3.0.) Unfortunately, it failed to fix the bug. I did not experience any regressions though. I tested it on both a Windows XP 32-bit SP3 machine and a Windows 8.1 64-bit machine (with the latest required updates & optional updates from MS.) 3rd, the username I used was "δοκιμαστικό χρήστη". That is how Google Translate translated "test user" into Greek. Because it is not easy for me to type that name into the Windows login prompt, I simply ran commands like the following to test it: runas "/user:δοκιμαστικό χρήστη" "c:\x2gobuilds\x2goclient\dist\x2goclient.exe" -Mike On Mon, Sep 1, 2014 at 7:23 PM, Michael DePaulo <mikedep333@gmail.com> wrote: > On Mon, Sep 1, 2014 at 3:51 PM, Mike Gabriel > <mike.gabriel@das-netzwerkteam.de> wrote: >> Hi Mike#2, >> >> On Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote: >> >>> A suggested patch is to substitute the Qt4 toAscii() function with >>> toLocal8Bit() >>> in two specific places of SshMasterConnection::run(). >>> A git diff is as follows: >>> >>> $ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp >>> 521c521 >>> < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>> (mainWnd->getHomeDirectory()+"/ssh").toAscii()); >>> --- >>>> >>>> ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit()); >>> >>> 630c630 >>> < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>> (mainWnd->getHomeDirectory()+"/ssh").toAscii()); >>> --- >>>> >>>> ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit()); >>> >>> >>> The change affects only Windows builds and was tested in Windows 8.1 Pro >>> and Windows 7 Professional. >>> >>> G. Trakatelis >> >> >> Can you review these changes and if appropriate commit them to the master >> branch of x2goclient.git? >> >> Thanks! >> Mike >> >> [...] > > Sure. I'm busy today, but I'll do so within the next few/several days. > > -Mike

[bug566.test.patch (application/octet-stream, attachment)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sun Nov 24 00:14:33 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #611 X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has characters from languages other than the system locale

X2Go Bug report logs - #611
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has characters from languages other than the system locale