X2Go Bug report logs - #611
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has characters from languages other than the system locale

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: normal

Found in version 4.0.2.1

Full log

Message #10 received at 566@bugs.x2go.org (full text, mbox, reply):

Received: (at 566) by bugs.x2go.org; 1 Sep 2014 17:28:57 +0000
From trakatelis@uom.edu.gr  Mon Sep  1 19:28:55 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID
	autolearn=ham version=3.3.2
Received: from mail-we0-f196.google.com (mail-we0-f196.google.com [74.125.82.196])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 745625DCA4
	for <566@bugs.x2go.org>; Mon,  1 Sep 2014 19:28:55 +0200 (CEST)
Received: by mail-we0-f196.google.com with SMTP id w61so2333700wes.3
        for <566@bugs.x2go.org>; Mon, 01 Sep 2014 10:28:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
        h=from:reply-to:to:references:in-reply-to:subject:date:message-id
         :mime-version:content-type:content-transfer-encoding:thread-index
         :content-language;
        bh=i2HT3pmdZubhw7wPfH73gwOavde6h2hmDbVn4J8dzPA=;
        b=RnDDb4Z40zoWYLDxyZX1Ygylgvrrf3dsLkFBXyP7cu4S452r859w0UDsLcf1RDEcp8
         2am/zr8ooK52FacFcY5EAwaol64vnw3nPy6NNBnFNJM8OdvHMKeqPP2pLY/7pw+SSnRR
         XogoINpCufr5ANnzf44mACnfRUZBElJRLKInY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:reply-to:to:references:in-reply-to:subject
         :date:message-id:mime-version:content-type:content-transfer-encoding
         :thread-index:content-language;
        bh=i2HT3pmdZubhw7wPfH73gwOavde6h2hmDbVn4J8dzPA=;
        b=Z1r17WpieNmtlIuutjQCOCgSbj45mQsT/MTbWuXOiaxwse4lR2Ai35COvpdaK5FWQ2
         s96poca5YC6bMG59jTaLbOw+XssK52QwP8RMTkUIt3b9ttPyRLXdxT+IY1sgFoHfUu7Q
         Uwx0rW1jCbXtr2g6fMBgT296otUZDATy3M4hhPKXlBoCoGgGa8n5HTMDHGa+GPhlxA7c
         Z4wfRV9Ac2lT5VF0EcTBb+Y5yffCDy3xQ/7193CJHWuOH2oTo/eFud9R3gKVlastflFD
         ZCT5Rkh1gtpUH7oF1jTshreTYr/+l7IyK1y4LB5dyEWmH8PwMPIB+OrGAPBnf1Q87A+2
         TsUQ==
X-Gm-Message-State: ALoCoQkR9Y7AwZPg2D4weyf/F+3UUAEr9U9vkdzMNHmixt84Sg2Ah4q8ZpBHM8Ozz5tSiZzMJouY
X-Received: by 10.194.71.74 with SMTP id s10mr4418521wju.116.1409592534981;
        Mon, 01 Sep 2014 10:28:54 -0700 (PDT)
Received: from HomePC (46-4-59.adsl.cyta.gr. [46.103.4.59])
        by mx.google.com with ESMTPSA id a5sm3507195wje.17.2014.09.01.10.28.54
        for <566@bugs.x2go.org>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Mon, 01 Sep 2014 10:28:54 -0700 (PDT)
From: George Trakatelis <trakatelis@uom.edu.gr>
X-Google-Original-From: "George Trakatelis" <trakatelis@uom.gr>
Reply-To: <trakatelis@uom.gr>
To: <566@bugs.x2go.org>
References: <000001cfb552$3193a8a0$94baf9e0$@gr> <handler.566.B.140775428816658.ack@bugs.x2go.org>
In-Reply-To: <handler.566.B.140775428816658.ack@bugs.x2go.org>
Subject: RE: Bug#566: Acknowledgement (X2Go Client for Windows 4.0.2.1 cannon create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-English characters)
Date: Mon, 1 Sep 2014 20:28:50 +0300
Message-ID: <000001cfc60a$32831de0$978959a0$@gr>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: Ac+1UrVCBM6afGVKRWGl97ZaDrOjRQQtRJXQ
Content-Language: el

A suggested patch is to substitute the Qt4 toAscii() function with toLocal8Bit() 
in two specific places of SshMasterConnection::run().
A git diff is as follows:

$ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp
521c521
<     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, (mainWnd->getHomeDirectory()+"/ssh").toAscii());
---
>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
630c630
<     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, (mainWnd->getHomeDirectory()+"/ssh").toAscii());
---
>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());

The change affects only Windows builds and was tested in Windows 8.1 Pro and Windows 7 Professional.

G. Trakatelis


-----Original Message-----
From: X2Go Bug Tracking System [mailto:owner@bugs.x2go.org] 
Sent: Monday, August 11, 2014 1:55 PM
To: trakatelis@uom.gr
Subject: Bug#566: Acknowledgement (X2Go Client for Windows 4.0.2.1 cannon create C:\Users\<username>\ssh\known_hosts file 
when the local Windows account username has non-English characters)

...

--
566: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=566
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 16:54:21 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.