#566 - X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

X2Go Bug report logs - #566
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: grave

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Received: (at 566) by bugs.x2go.org; 8 Sep 2014 08:58:35 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Sep  8 10:58:33 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id DBFAC3D375
	for <566@bugs.x2go.org>; Mon,  8 Sep 2014 10:58:33 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id A3EBC3DC;
	Mon,  8 Sep 2014 10:58:33 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 88B6F3BBAE;
	Mon,  8 Sep 2014 10:58:33 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Y+B62V2-KOgL; Mon,  8 Sep 2014 10:58:33 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 39DDF3BB24;
	Mon,  8 Sep 2014 10:58:33 +0200 (CEST)
Received: from m-031.informatik.uni-kiel.de (m-031.informatik.uni-kiel.de
 [134.245.254.31]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 08 Sep 2014 08:58:33 +0000
Date: Mon, 08 Sep 2014 08:58:33 +0000
Message-ID: <20140908085833.Horde.1KVN9LjgQ3GOkz4EX-JZjA1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Michael DePaulo <mikedep333@gmail.com>
Cc: George Trakatelis <trakatelis@uom.edu.gr>, 566@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannot
 create C:\Users\<username>\ssh\known_hosts file when the local Windows
 account username has non-Ascii characters
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
 <handler.566.B.140775428816658.ack@bugs.x2go.org>
 <000001cfc60a$32831de0$978959a0$@gr>
 <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
 <CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
 <CAMKht8jxisag8A9F3yFBSg3BQ+PODLzrayu90S0G8OaQKZXtfQ@mail.gmail.com>
 <000001cfca83$2b11d830$81358890$@edu.gr>
 <CAMKht8hMDouAZr0zh0jQ8HhA_COJOfC-d0BKY4u6hTcCDEoQmQ@mail.gmail.com>
In-Reply-To: <CAMKht8hMDouAZr0zh0jQ8HhA_COJOfC-d0BKY4u6hTcCDEoQmQ@mail.gmail.com>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.0)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.31
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_djrjbal-WzPlSm072x5kgA1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

Hi Mike#2, On So 07 Sep 2014 15:23:22 CEST, Michael DePaulo wrote: > On Sun, Sep 7, 2014 at 6:04 AM, George Trakatelis > <trakatelis@uom.edu.gr> wrote: > [...] >> >> a. Installed German keyboard. Hit ';' to produce an accented letter >> and -to my surprise- got ö. So I thought ölexandr was the right >> name to test for username. >> >> b. Created user ölexandr and logged in as that user. >> The patch did not work, as you mentioned. >> >> c. As toLocal8Bit() returns the local 8-bit representation of a string, >> I changed the system locale for non-unicode programs to German. >> Now the patch worked! >> >> I think the patch solves the problem for the Windows users who use English >> as a foreign language and prefer having (non-Ascii) usernames in >> their native language. >> >> -George >> >> PS. A better title for the bug would be >> >> X2Go Client for Windows 4.0.2.1 cannot create >> C:\Users\<username>\ssh\known_hosts file when the local Windows >> account username has non-Ascii characters > > Hi Mike#1 and George, > > 1. What do you think of using toUtf8() instead? I am hoping that will > fix the bug regardless of the locale. > > I tried changing it to that (bug566.utf8.test.patch), but it still did > not fix this bug with the greek username on my system with the locale > set to English. It did not introduce a regression for my ASCII user > account at least. > > If libssh needs to be recompiled for Unicode, I can do that. I just > recompiled it for bug #590. > > FYI: This is the API we are calling: > http://api.libssh.org/stable/group__libssh__session.html#ga7a801b85800baa3f4e16f5b47db0a73d I am getting the suspicion, that this is a libssh issue. X2Go Client and libssh should communicate via UTF-8 (because it is _the_ encoding that applications use internally, nowadays) and libssh should handle whatever conversion (probably to UTF-16 wide string?) is necessary for creating files, being aware of usernames, etc. > 2. in sshmasterconnection.cpp, we also set "SSH_OPTIONS_USER" . I > think that we should also change its value from to.Ascii() to > toLocal8Bit() or toUtf8(). bug566.test.v2.patch has this change for > toLocal8Bit(), and bug566.utf8.test.patch has it for toUtf8(). Same thing. SSH_OPTIONS_USER should be set as UTF-8 and libssh should convert to whatever encoding is needed. Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 18:16:07 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #566 X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

X2Go Bug report logs - #566
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters