X2Go Bug report logs - #566
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: grave

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

Message #50 received at 566@bugs.x2go.org (full text, mbox, reply):

Received: (at 566) by bugs.x2go.org; 8 Sep 2014 08:52:33 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Sep  8 10:52:32 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 4369C3D375
	for <566@bugs.x2go.org>; Mon,  8 Sep 2014 10:52:32 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id E8139165E;
	Mon,  8 Sep 2014 10:52:31 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id D54743BBAE;
	Mon,  8 Sep 2014 10:52:31 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id UqSUNbIpuYPg; Mon,  8 Sep 2014 10:52:31 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 9B4E83BA88;
	Mon,  8 Sep 2014 10:52:31 +0200 (CEST)
Received: from m-031.informatik.uni-kiel.de (m-031.informatik.uni-kiel.de
 [134.245.254.31]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 08 Sep 2014 08:52:31 +0000
Date: Mon, 08 Sep 2014 08:52:31 +0000
Message-ID: <20140908085231.Horde.tZmtZ8e1eNb9skDTZ2wjQg1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: George Trakatelis <trakatelis@uom.edu.gr>, 566@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#566: Bug#566: X2Go Client for Windows 4.0.2.1
 cannot create C:\Users\<username>\ssh\known_hosts file when the local
 Windows account username has non-Ascii characters
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
 <handler.566.B.140775428816658.ack@bugs.x2go.org>
 <000001cfc60a$32831de0$978959a0$@gr>
 <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
 <CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
 <CAMKht8jxisag8A9F3yFBSg3BQ+PODLzrayu90S0G8OaQKZXtfQ@mail.gmail.com>
 <000001cfca83$2b11d830$81358890$@edu.gr>
In-Reply-To: <000001cfca83$2b11d830$81358890$@edu.gr>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.0)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.31
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_ouvvwToruixnckrMAGByeQ2";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Mike#2, hi George,

On  So 07 Sep 2014 12:04:51 CEST, George Trakatelis wrote:

> c. As toLocal8Bit() returns the local 8-bit representation of a string,
> I changed the system locale for non-unicode programs to German.
> Now the patch worked!
>
> I think the patch solves the problem for the Windows users who use English
> as a foreign language and prefer having (non-Ascii) usernames in  
> their native language.
>
> -George
>
> PS. A better title for the bug would be
>
> X2Go Client for Windows 4.0.2.1 cannot create  
> C:\Users\<username>\ssh\known_hosts file when the local Windows  
> account username has non-Ascii characters

Now that I think of it more thoroughly... Shouldn't we do a proper  
encode/decode here so that we convert UTF-8 to Windows-CP1251 encoding  
[1]?

Alternatively, one could work with filenames in UTF-16 as shown in  
this [2] example.

I am not sure about the exact position in the code that bugs this up,  
but I fear, the solution is non-trivial.

Either you need to detect the client-side encoding and convert between  
UTF-8 and that encoding, or we may consider addressing file names in  
UTF-16 (if that is possible in Qt).

Unfortunately, it seems that Windows uses different encodings at  
different places (e.g. command.exe vs. Windows Explorer).

Just guessing after a little bit of internet research on this,
Mike#1


[1] http://comments.gmane.org/gmane.comp.lib.qt.general/39868
[2] https://www.mail-archive.com/subsurface@hohndel.org/msg00099.html


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sun Nov 24 07:05:54 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.