X2Go Bug report logs - #566
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: grave

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#566: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannot create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-Ascii characters
Reply-To: Michael DePaulo <mikedep333@gmail.com>, 566@bugs.x2go.org
Resent-From: Michael DePaulo <mikedep333@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 08 Sep 2014 03:00:02 +0000
Resent-Message-ID: <handler.566.B566.141014491525798@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 566
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 566-submit@bugs.x2go.org id=B566.141014491525798
          (code B ref 566); Mon, 08 Sep 2014 03:00:02 +0000
Received: (at 566) by bugs.x2go.org; 8 Sep 2014 02:55:15 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 29EE45DEA7
	for <566@bugs.x2go.org>; Mon,  8 Sep 2014 04:55:14 +0200 (CEST)
Received: by mail-wi0-f181.google.com with SMTP id e4so1887175wiv.8
        for <566@bugs.x2go.org>; Sun, 07 Sep 2014 19:55:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=EYnWCDyW7ZhnR+5VAmFnWOixLsjW3aOPw8IdXzSjIEo=;
        b=Cw192SISRjWBMBeph3wFnkq95Z8T44GH6cW0MziNwgAAIqfHnDTB1kROS+A2HMgXU4
         lTmizg/FVLMaS7coKpkc+o5yS0+hcOIlen1qkfkG469N/oaUhLIXVo9YRw9zvyHbHWSd
         YGbiHaOChcFoouPlRu5rjdahuh42l7Yawf5BzsnXRbKyT67cDBR5UuhAoqG/K5R3vclm
         IPy8lmH3B/poyuIB3hQ7MDQ28U+JfxoReu9TRgjFwtfOBorZotJePHS2h4gY/zxakPAG
         Pzol6O1WQFuKdzar30b1q0k0Q7Fr9v5Q+iJHwio5O7vCk58g1EMFYgOgVbiEUj71mpmU
         4+0Q==
MIME-Version: 1.0
X-Received: by 10.194.95.8 with SMTP id dg8mr31756005wjb.1.1410144913764; Sun,
 07 Sep 2014 19:55:13 -0700 (PDT)
Received: by 10.180.238.66 with HTTP; Sun, 7 Sep 2014 19:55:13 -0700 (PDT)
In-Reply-To: <000001cfcaf9$c4160a80$4c421f80$@edu.gr>
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
	<handler.566.B.140775428816658.ack@bugs.x2go.org>
	<000001cfc60a$32831de0$978959a0$@gr>
	<20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
	<CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
	<CAMKht8jxisag8A9F3yFBSg3BQ+PODLzrayu90S0G8OaQKZXtfQ@mail.gmail.com>
	<000001cfca83$2b11d830$81358890$@edu.gr>
	<CAMKht8hMDouAZr0zh0jQ8HhA_COJOfC-d0BKY4u6hTcCDEoQmQ@mail.gmail.com>
	<000001cfcaf9$c4160a80$4c421f80$@edu.gr>
Date: Sun, 7 Sep 2014 22:55:13 -0400
Message-ID: <CAMKht8haCVM3Nc4VaZa++SDk4iXAg7VaJXaWoN2C9OU7m6-Zgg@mail.gmail.com>
From: Michael DePaulo <mikedep333@gmail.com>
To: George Trakatelis <trakatelis@uom.edu.gr>
Cc: 566@bugs.x2go.org, Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Content-Type: text/plain; charset=UTF-8

Yeah. I think that libssh isn't being compiled with Unicode support,
or at least not under MingW 4.4. It's not 100% clear how to compile a
C library with Unicode support under MinGW and CMake. For example,
recent versions of MinGW let you specify the linker option -municode.
But I cannot find a single release note that states when exactly that
feature was added. I do not know if 4.4 has it or not.

I'm going to try to compile it with MinGW 4.8. I've been meaning to
upgrade to X2Go to MinGW 4.8 and QT 4.8.6 anyway. (bug: #474)

On Sun, Sep 7, 2014 at 8:13 PM, George Trakatelis <trakatelis@uom.edu.gr> wrote:
> Hi Mike,
>
> 1. If you recompile libssh 0.6.3 with Unicode support and provide me with a download link,
> I will happily test it on all Windows platforms (namely Windows 8, 7, and XP).
>
> 2. I agree.
>
> -George
>
> -----Original Message-----
> From: Michael DePaulo [mailto:mikedep333@gmail.com]
> Sent: Sunday, September 7, 2014 4:23 PM
> To: George Trakatelis; 566@bugs.x2go.org; Mike Gabriel
> Subject: Re: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannot create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-Ascii characters
>
> [...]
>
> Hi Mike#1 and George,
>
> 1. What do you think of using toUtf8() instead? I am hoping that will fix the bug regardless of the locale.
>
> I tried changing it to that (bug566.utf8.test.patch), but it still did not fix this bug with the greek username on my system with the locale set to English. It did not introduce a regression for my ASCII user account at least.
>
> If libssh needs to be recompiled for Unicode, I can do that. I just recompiled it for bug #590.
>
> FYI: This is the API we are calling:
> http://api.libssh.org/stable/group__libssh__session.html#ga7a801b85800baa3f4e16f5b47db0a73d
>
> 2. in sshmasterconnection.cpp, we also set "SSH_OPTIONS_USER" . I think that we should also change its value from to.Ascii() to
> toLocal8Bit() or toUtf8(). bug566.test.v2.patch has this change for toLocal8Bit(), and bug566.utf8.test.patch has it for toUtf8().
>
> -Mike#2
>

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 18:23:55 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.