X2Go Bug report logs - #566
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: grave

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

Message #20 received at 566@bugs.x2go.org (full text, mbox, reply):

Received: (at 566) by bugs.x2go.org; 1 Sep 2014 23:23:14 +0000
From mikedep333@gmail.com  Tue Sep  2 01:23:13 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EE3885DCA4
	for <566@bugs.x2go.org>; Tue,  2 Sep 2014 01:23:12 +0200 (CEST)
Received: by mail-wi0-f179.google.com with SMTP id q5so6853965wiv.12
        for <566@bugs.x2go.org>; Mon, 01 Sep 2014 16:23:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=FUeHm+NITukD4vHVGgqEgyYXdvWDJoGWHA6yVwpZakg=;
        b=dJs1xvDp/iGtyEoyHX2MUz+IGxNxEkVlKfviTl4rWtDjPR0E5OrC0xI6Waif8mzjVD
         zABwclS9lUgnfHJu6lJkpbR+GTEehOQzzqAVfEU6MeTJlbefDc8atIk2M1Sy3w5tbA4L
         oPXGx7ob5O6FdtAc30K00liA0/Ta23WYRAWxHTSbbvZhH2M7kuIamSpXq8h61fX2fyAd
         xnUUBPdoLQPen9KMPaqz6OGSSYdsSyQYxn2rSPVXMISxGXUT8LywVaB+peQS6F6wA1eD
         3IcCai+dkg+0/h50VV1kdHVgeaBAQjjbJ1A6HVB/Agx2f9PbrowUChgfN0WgNiekd2lY
         hSsQ==
MIME-Version: 1.0
X-Received: by 10.180.37.77 with SMTP id w13mr24295472wij.78.1409613792601;
 Mon, 01 Sep 2014 16:23:12 -0700 (PDT)
Received: by 10.180.238.66 with HTTP; Mon, 1 Sep 2014 16:23:12 -0700 (PDT)
In-Reply-To: <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
	<handler.566.B.140775428816658.ack@bugs.x2go.org>
	<000001cfc60a$32831de0$978959a0$@gr>
	<20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
Date: Mon, 1 Sep 2014 19:23:12 -0400
Message-ID: <CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
Subject: Re: [X2Go-Dev] Bug#566: Bug#566: X2Go Client for Windows 4.0.2.1
 cannon create C:\Users\<username>\ssh\known_hosts file when the local Windows
 account username has non-English characters
From: Michael DePaulo <mikedep333@gmail.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 566@bugs.x2go.org
Cc: trakatelis@uom.gr, George Trakatelis <trakatelis@uom.edu.gr>
Content-Type: text/plain; charset=UTF-8

On Mon, Sep 1, 2014 at 3:51 PM, Mike Gabriel
<mike.gabriel@das-netzwerkteam.de> wrote:
> Hi Mike#2,
>
> On  Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote:
>
>> A suggested patch is to substitute the Qt4 toAscii() function with
>> toLocal8Bit()
>> in two specific places of SshMasterConnection::run().
>> A git diff is as follows:
>>
>> $ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp
>> 521c521
>> <     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>> (mainWnd->getHomeDirectory()+"/ssh").toAscii());
>> ---
>>>
>>>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
>>
>> 630c630
>> <     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>> (mainWnd->getHomeDirectory()+"/ssh").toAscii());
>> ---
>>>
>>>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
>>
>>
>> The change affects only Windows builds and was tested in Windows 8.1 Pro
>> and Windows 7 Professional.
>>
>> G. Trakatelis
>
>
> Can you review these changes and if appropriate commit them to the master
> branch of x2goclient.git?
>
> Thanks!
> Mike
>
> [...]

Sure. I'm busy today, but I'll do so within the next few/several days.

-Mike

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 19:04:03 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.