X2Go Bug report logs - #448
x2goclient won't connect with ssh agent (Q: Who was so afraid of the NSA that he disabled agent communication in x2go?)

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 6 Mar 2014 17:50:25 +0000
From newsgroups.mail2@stefanbaur.de  Thu Mar  6 18:50:25 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS
	autolearn=ham version=3.3.2
X-Greylist: delayed 303 seconds by postgrey-1.34 at ymir; Thu, 06 Mar 2014 18:50:24 CET
Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10])
	by ymir (Postfix) with ESMTP id CCD885DA6C
	for <submit@bugs.x2go.org>; Thu,  6 Mar 2014 18:50:24 +0100 (CET)
Received: from [192.168.0.3] (dslb-188-105-124-090.pools.arcor-ip.net [188.105.124.90])
	by mrelayeu.kundenserver.de (node=mreue102) with ESMTP (Nemesis)
	id 0MarjW-1Wbe8p0ISw-00KSkW; Thu, 06 Mar 2014 18:45:21 +0100
Message-ID: <5318B431.3080404@stefanbaur.de>
Date: Thu, 06 Mar 2014 18:45:21 +0100
From: Stefan Baur <newsgroups.mail2@stefanbaur.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: submit@bugs.x2go.org, Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 
 Michael DePaulo <mikedep333@gmail.com>
Subject: x2goclient won't connect with ssh agent (Q: Who was so afraid of
 the NSA that he disabled agent communication in x2go?)
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:Ohg+YoE8U+PF2LHtFW7J3xBIatsYillyHU53DoIkFIh
 SlKhwey2P6nngMFEJc3HYrbprtVloFS3Vc6TUynVCjZrgxjp/y
 kJhxFc55LHeBY17leEl02gJ2ScvdvqH5VGWcAr60ZhtErobjsR
 5zx80doesrnIQrtYODQee8S0iGaZzkJpFH541F6GUBFYsfmRTR
 AyKUMEzAT6Bv8b90EKl8lwEhl8b7ThWXLQ3caDL/8YaCsZ+1Bm
 ojqQXXl3d1+niuKrCX65aTZ2dqymuBJ+zcmEV7/2wlZnbTY4Vj
 ItKi1pbPmn87jW4wzcJNYjtx5UTyARFqMG7xz0q/lQH2qfVa5Y
 wAbxwJ67oHo1jGwbuK21VZpVgFJ3qdexZWLKSVRfJ

Package: x2goclient
Version: 4.0.2.0

(I'm filing this against 4.0.2.0 b/c it's still present there. If bugs
should be filed against the version they initially appeared in, please
let me know)

not affected: 4.0.0.3 with PulseAudio 0.9.6
not affected: 4.0.1.2 with PulseAudio 0.9.6
possibly affected (untested) 4.0.1.3 with PulseAudio 0.9.6
affected: 4.0.1.3+build2 with PulseAudio 0.9.6
affected: 4.0.2.0

Preface:
The followin issue has been observed on Windows; whoever takes care of
this should also check if the same issue occurs on Linux and Mac when
using the ssh agents shipped with these operating systems.

Situation:
4.0.1.2 with PulseAudio 0.9.6 and older clients allowed the use of an
external SSH agent that loads and memorizes SSH private keys (so you
don't have to re-enter your private key's passphrase whenever you try to
connect).
In my case, this SSH agent was "Pageant" from the PuTTY package.

With 4.0.1.3+build2/PA0.9.6, using the same (registry-stored) settings
as before, x2goclient.exe pops up a dialog box asking me for my private
key's password. Which it does over and over again, without ever connecting.
To me, it looks like it's asking for the password for a non-existant
private key, the key with the file name "", thus it always fails.

Assumption:
Someone tried to add/fix code regarding ssh public key authentication
(maybe something to do with bug #322?), took care of whatever issue
there was with private key file handling by x2goclient itself, but
overlooked the possibility that an external ssh agent might be involved.

Net Result:
SSH public key login using an SSH agent is effectively broken in
4.0.1.3+build2 (and possibly 4.0.1.3), up to 4.0.2.0-2014-03-06 (nightly
build), and probably still broken in the current source.

Sounds like a case for one of our two Mikes ...

-Stefan

Send a report that this bug log contains spam.