X2Go Bug report logs - #1476
x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>

Date: Sun, 7 Jun 2020 15:55:01 UTC

Severity: wishlist

Found in version 4.1.2.3

Full log

đź”— View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1476: [X2Go-Dev] Bug#1476: x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 1476@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 08 Jun 2020 07:55:02 +0000
Resent-Message-ID: <handler.1476.B1476.159160289110087@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1476
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
References: <CAL4gekBJSL8f_uv8pHNNrsHiWvy_31YCvi+tzG4XzJ76n6Gc6A@mail.gmail.com>
Received: via spool by 1476-submit@bugs.x2go.org id=B1476.159160289110087
          (code B ref 1476); Mon, 08 Jun 2020 07:55:02 +0000
Received: (at 1476) by bugs.x2go.org; 8 Jun 2020 07:54:51 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,SPF_HELO_NONE,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2
Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 608A25DAE7
	for <1476@bugs.x2go.org>; Mon,  8 Jun 2020 09:54:47 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 7E9DD605B5;
	Mon,  8 Jun 2020 07:54:46 +0000 (UTC)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 76D20C0247;
	Mon,  8 Jun 2020 09:54:46 +0200 (CEST)
Received: from business-90-187-115-117.pool2.vodafone-ip.de
 (business-90-187-115-117.pool2.vodafone-ip.de [90.187.115.117]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Mon, 08 Jun 2020
 07:54:46 +0000
Date: Mon, 08 Jun 2020 07:54:46 +0000
Message-ID: <20200608075446.Horde.GCbByAWEYdCZIPr7R8dhv9L@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>, 1476@bugs.x2go.org
In-Reply-To: <CAL4gekBJSL8f_uv8pHNNrsHiWvy_31YCvi+tzG4XzJ76n6Gc6A@mail.gmail.com>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 90.187.115.117
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Firefox/68.0
Content-Type: multipart/signed; boundary="=_RgkLdzCXQvZ9WKjluT-oZBw";
 protocol="application/pgp-signature"; micalg=pgp-sha512
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Dave,

On  So 07 Jun 2020 17:49:21 CEST, Dave Chamberlin-Kidd wrote:

> Package: x2goclient
> Version: 4.1.2.3
> Severity: wishlist
> Tag: patch
>
> There are a number of minor issues, oddities and limitations with the
> current x2goclient gui which would be good to fix, resolve and improve on.
> Like all projects however the core team have more important issues to
> resolve. The code in its current state is difficult to understand and amend
> and as it has no tests it is risky for developers to make functional
> changes unless they spend a lot of time getting to know the code and doing
> extensive manual testing.
>
> Attached are 10 small refactorings which start extracting out some of the
> code into smaller functions. As the code is separated out it becomes easier
> to understand and change.
>
> There are no functional changes in these patches, nor do they attempt or
> claim to fix any known issues. On their own the benefit of these patches is
> limited however the hope is that over time I will be able to submit more
> refactorings as I learn more and then start fixing issues and improving the
> UI. Extracting out functions is just one of many techniques that can be
> used to make code cleaner but in my experience it's a good one to start
> with. It should also be noted that sometimes code is extracted "as is" even
> when it is clear further refactoring can be done to improve things, this is
> by design in order to keep risk and size of patches to a minimum.
>
> Cheers
> Dave

Thanks for your patches. As the GitLab server for X2Go is in reach,  
I'd like to postpone patch review until its there. I'd be happy if you  
could file a merge request then and we dive into your proposals.

Thanks+Greets,
Mike
-- 

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de


[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Dec 18 00:28:42 2025; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.