X2Go Bug report logs - #1476
x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>

Date: Sun, 7 Jun 2020 15:55:01 UTC

Severity: wishlist

Found in version 4.1.2.3

Full log

đź”— View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1476: [X2Go-Dev] Bug#1476: x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test
Reply-To: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>, 1476@bugs.x2go.org
Resent-From: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 03 Sep 2020 06:40:02 +0000
Resent-Message-ID: <handler.1476.B1476.159911493710666@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1476
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
References: <CAL4gekBJSL8f_uv8pHNNrsHiWvy_31YCvi+tzG4XzJ76n6Gc6A@mail.gmail.com> <20200608075446.Horde.GCbByAWEYdCZIPr7R8dhv9L@mail.das-netzwerkteam.de> <CAL4gekBEPEEODTNvOQxfMy0+C7K3BarTxYRUCOoLLhAyqcjULA@mail.gmail.com> <CAL4gekBJSL8f_uv8pHNNrsHiWvy_31YCvi+tzG4XzJ76n6Gc6A@mail.gmail.com>
Received: via spool by 1476-submit@bugs.x2go.org id=B1476.159911493710666
          (code B ref 1476); Thu, 03 Sep 2020 06:40:02 +0000
Received: (at 1476) by bugs.x2go.org; 3 Sep 2020 06:35:37 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,HTML_MESSAGE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E4FA55DAFA
	for <1476@bugs.x2go.org>; Thu,  3 Sep 2020 08:35:34 +0200 (CEST)
Received: by mail-il1-f177.google.com with SMTP id y2so1499562ilp.7
        for <1476@bugs.x2go.org>; Wed, 02 Sep 2020 23:35:34 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=ZiWwtEnmaIRl76HNvrgsZo721yblQN014kZZONT+4so=;
        b=ujhooOqLZfB9VABM1j5kRkxWfafcwRiJbkQgqgFxyXgj3Odr27NF0p792xzymbrGZx
         AAYJJVLaHEi1lCIYbYkTIcnbwh6RARpqFd37AeUBim50pA9etlU/X02fy+96XsrDSUMK
         n9kVFozWlzAuoSNHsL5Xl48T4rQrrlrEYdzcfq5+2gTA1k0fOv+SwMW/Ea60mYXwAdQj
         p+P/bA0jI9a/FHhSqtu+e3cL6ilR3eegxqmQZtUw5kgb7+SOxJ6OJclImYWMRfOmlgY3
         MHIez4ASaNdIHEUGrBQBFgcyjZUVUektNHYnoMpJWo6qHofCvoJq/7AHlszGQXZvS+3R
         Usiw==
X-Gm-Message-State: AOAM533a+Pdj9ph3gHAgdBFHbWLi9uYUPTbljuGwbQGSGr6wRPTC4JiE
	fGqYy8P8R/e+Iqas0QLePc1EMwCvCL2lZYaNAKA=
X-Google-Smtp-Source: ABdhPJx3gP9MGQbICBSOYpygg8wFZ9f56vUSulPDUo+WyiJq8Wwxu2xLgD4RXNvi3r68WbaRCsQJavaJxxNr78o/V6M=
X-Received: by 2002:a92:aa86:: with SMTP id p6mr1763881ill.188.1599114903356;
 Wed, 02 Sep 2020 23:35:03 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAL4gekBEPEEODTNvOQxfMy0+C7K3BarTxYRUCOoLLhAyqcjULA@mail.gmail.com>
From: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>
Date: Thu, 3 Sep 2020 07:34:51 +0100
Message-ID: <CAL4gekB8+GmZ78K6YVVi4qTE3EYjdmiTKCBWJPxCJ9pE6demYw@mail.gmail.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Cc: 1476@bugs.x2go.org
Content-Type: multipart/alternative; boundary="000000000000c50a5305ae62f372"

[Message part 1 (text/plain, inline)]
Hi Mike,

It's been a while and I'm not clear what, if anything, is happening with
gitlab. Is there any way to proceed despite this?

Cheers


On Tue, 9 Jun 2020, 00:20 Dave Chamberlin-Kidd, <dave@flamangoes.co.uk>
wrote:

> Cheers Mike. No problem.
>
> On Mon, 8 Jun 2020, 08:54 Mike Gabriel, <mike.gabriel@das-netzwerkteam.de>
> wrote:
>
>> Hi Dave,
>>
>> On  So 07 Jun 2020 17:49:21 CEST, Dave Chamberlin-Kidd wrote:
>>
>> > Package: x2goclient
>> > Version: 4.1.2.3
>> > Severity: wishlist
>> > Tag: patch
>> >
>> > There are a number of minor issues, oddities and limitations with the
>> > current x2goclient gui which would be good to fix, resolve and improve
>> on.
>> > Like all projects however the core team have more important issues to
>> > resolve. The code in its current state is difficult to understand and
>> amend
>> > and as it has no tests it is risky for developers to make functional
>> > changes unless they spend a lot of time getting to know the code and
>> doing
>> > extensive manual testing.
>> >
>> > Attached are 10 small refactorings which start extracting out some of
>> the
>> > code into smaller functions. As the code is separated out it becomes
>> easier
>> > to understand and change.
>> >
>> > There are no functional changes in these patches, nor do they attempt or
>> > claim to fix any known issues. On their own the benefit of these
>> patches is
>> > limited however the hope is that over time I will be able to submit more
>> > refactorings as I learn more and then start fixing issues and improving
>> the
>> > UI. Extracting out functions is just one of many techniques that can my
>> experience it's a good one to start
>> > with. It should also be noted that sometimes code is extracted "as is"
>> even
>> > when it is clear further refactoring can be done to improve things,
>> this is
>> > by design in order to keep risk and size of patches to a minimum.
>> >
>> > Cheers
>> > Dave
>>
>> Thanks for your patches. As the GitLab server for X2Go is in reach,
>> I'd like to postpone patch review until its there. I'd be happy if you
>> could file a merge request then and we dive into your proposals.
>>
>> Thanks+Greets,
>> Mike
>> --
>>
>> DAS-NETZWERKTEAM
>> c\o Technik- und Ökologiezentrum Eckernförde
>> Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
>> mobile: +49 (1520) 1976 148
>> landline: +49 (4351) 850 8940
>>
>> GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
>> mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
>>
>>

[Message part 2 (text/html, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Dec 18 00:33:10 2025; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.