X2Go Bug report logs - #1476
x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>

Date: Sun, 7 Jun 2020 15:55:01 UTC

Severity: wishlist

Found in version 4.1.2.3

Full log

Message #15 received at 1476@bugs.x2go.org (full text, mbox, reply):

Received: (at 1476) by bugs.x2go.org; 8 Jun 2020 23:21:02 +0000
From dave.flamangoes@gmail.com  Tue Jun  9 01:20:58 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,HTML_MESSAGE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id BF19A5DAE7
	for <1476@bugs.x2go.org>; Tue,  9 Jun 2020 01:20:57 +0200 (CEST)
Received: by mail-il1-f175.google.com with SMTP id i1so17341628ils.11
        for <1476@bugs.x2go.org>; Mon, 08 Jun 2020 16:20:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=YvoZtpggoPmhDVDuj1tkjpy3ZTJLsHUtkpwlDJZb8mQ=;
        b=SWVlydCtF4XLZlZmbI9HAi9MZKh6qBPC+BuRJNGhrT91n+hOpSkd1ysTNNJrAI5F6M
         tKi4AFe2TWLJA2QUTow5HLAXScDcynrF4SmUlBb0D+W/dqKAPggn9SnWT8KFdNSElF9I
         AzipZdlbMgi3URrBYe8OT6eSnhxktHLgl3EsJJaNz1oaP5k3zhrV+6N4AKfSvgYX4aLH
         tiRKoxNsjVFO1FBCrZsUrTsa3mK7uopTmKUmNguuKlmMvnT97klzcCM4/YD9H7X+PcBR
         9GtVb/n4+LF/NzlEUOwbmfCBX41A8vvCjrw1p5XKeMRQhXH7UePqffKgLGHxDA1xY0c1
         ffPw==
X-Gm-Message-State: AOAM5321z4hn5MpmkWlXbap2YTuQhOzI4q7WRudlKp500GJMujLiOwvL
	pWn90phih8xTPls6TKkTH0h1fwvB59TsX+yjsGo=
X-Google-Smtp-Source: ABdhPJwRvPB8apaJwv7kdd5Ln9XVHqMNm3F3OPFHhiWe4Y14BLxi9RAeZ3LTBwa039Q0bovUSVRxpwpAgnR67uIWhjU=
X-Received: by 2002:a92:bad1:: with SMTP id t78mr24950165ill.146.1591658456290;
 Mon, 08 Jun 2020 16:20:56 -0700 (PDT)
MIME-Version: 1.0
References: <CAL4gekBJSL8f_uv8pHNNrsHiWvy_31YCvi+tzG4XzJ76n6Gc6A@mail.gmail.com>
 <20200608075446.Horde.GCbByAWEYdCZIPr7R8dhv9L@mail.das-netzwerkteam.de>
In-Reply-To: <20200608075446.Horde.GCbByAWEYdCZIPr7R8dhv9L@mail.das-netzwerkteam.de>
From: Dave Chamberlin-Kidd <dave@flamangoes.co.uk>
Date: Tue, 9 Jun 2020 00:20:44 +0100
Message-ID: <CAL4gekBEPEEODTNvOQxfMy0+C7K3BarTxYRUCOoLLhAyqcjULA@mail.gmail.com>
Subject: Re: [X2Go-Dev] Bug#1476: x2goclient interface code needs refactoring
 to make it more accessible and make improvements easier to implement and test
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Cc: 1476@bugs.x2go.org
Content-Type: multipart/alternative; boundary="000000000000e419f805a79adcb5"

[Message part 1 (text/plain, inline)]
Cheers Mike. No problem.

On Mon, 8 Jun 2020, 08:54 Mike Gabriel, <mike.gabriel@das-netzwerkteam.de>
wrote:

> Hi Dave,
>
> On  So 07 Jun 2020 17:49:21 CEST, Dave Chamberlin-Kidd wrote:
>
> > Package: x2goclient
> > Version: 4.1.2.3
> > Severity: wishlist
> > Tag: patch
> >
> > There are a number of minor issues, oddities and limitations with the
> > current x2goclient gui which would be good to fix, resolve and improve
> on.
> > Like all projects however the core team have more important issues to
> > resolve. The code in its current state is difficult to understand and
> amend
> > and as it has no tests it is risky for developers to make functional
> > changes unless they spend a lot of time getting to know the code and
> doing
> > extensive manual testing.
> >
> > Attached are 10 small refactorings which start extracting out some of the
> > code into smaller functions. As the code is separated out it becomes
> easier
> > to understand and change.
> >
> > There are no functional changes in these patches, nor do they attempt or
> > claim to fix any known issues. On their own the benefit of these patches
> is
> > limited however the hope is that over time I will be able to submit more
> > refactorings as I learn more and then start fixing issues and improving
> the
> > UI. Extracting out functions is just one of many techniques that can my
> experience it's a good one to start
> > with. It should also be noted that sometimes code is extracted "as is"
> even
> > when it is clear further refactoring can be done to improve things, this
> is
> > by design in order to keep risk and size of patches to a minimum.
> >
> > Cheers
> > Dave
>
> Thanks for your patches. As the GitLab server for X2Go is in reach,
> I'd like to postpone patch review until its there. I'd be happy if you
> could file a merge request then and we dive into your proposals.
>
> Thanks+Greets,
> Mike
> --
>
> DAS-NETZWERKTEAM
> c\o Technik- und Ökologiezentrum Eckernförde
> Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
> mobile: +49 (1520) 1976 148
> landline: +49 (4351) 850 8940
>
> GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
> mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
>
>

[Message part 2 (text/html, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:42:48 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.