X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)

Full log

Message #62 received at 1469@bugs.x2go.org (full text, mbox, reply):

Received: (at 1469) by bugs.x2go.org; 20 May 2020 15:06:36 +0000
From melroy89@protonmail.com  Wed May 20 17:04:32 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=1.0 required=3.0 tests=BAYES_50,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,
	HTML_MESSAGE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.2
Received: from mail-40140.protonmail.ch (mail-40140.protonmail.ch [185.70.40.140])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 626755DAF8
	for <1469@bugs.x2go.org>; Wed, 20 May 2020 17:04:26 +0200 (CEST)
Date: Wed, 20 May 2020 15:04:17 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
	s=protonmail; t=1589987065;
	bh=AmLdDkqrcW1uvS9HobWfYoy78fRrR5nqAHt6Uz2nzZQ=;
	h=Date:To:From:Reply-To:Subject:From;
	b=DelDzePipKUBVoQ6OgOp+MgT9XVN6indUUTb9BIgJlICdtQxrkX56c0NinJEbPp35
	 /dMbiT11Xv/YJUAl4ZCbCExTSozkWhM5RAO8J+BxY9NYUtyX5Z2LkCf0xgB3HpBpdj
	 1NjQqX7dIU9WebXIljQU3zS9nVoTozDv7k1O8VkM=
To: "1469@bugs.x2go.org" <1469@bugs.x2go.org>
From: Melroy van den Berg <melroy89@protonmail.com>
Reply-To: Melroy van den Berg <melroy89@protonmail.com>
Subject: Re: Re: [X2Go-Dev] Bug#1469: But wait; there is more... patches!
Message-ID: <aXzJi4lDef700vOhX28Gr5WC1lkeYFfZHXswy-JpFf0RXhTBanWTn-cU43ol4szfw8U_d_u2utTEewcEarBUGbOUN_BXSlZtsWyO8mcSjc8=@protonmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="b1_11cf3dce7a98bf001db7f11ea287db30"

[Message part 1 (text/plain, inline)]

Hi Mike,

Thanks for your reply. Are are my thoughts.

> Using (std::)endl is actually a bug

Ah, thanks for the heads-up! I think in that case we should in fact remove all the endl instead of adding it :).

> Strictly speaking, though, this should not cause any issues

Why was I getting socket error then? I really hope everything got merged correctly now. Including my changes in the separate function.

Since all the changes together made my socket error from libssh disappear now.

> This code path is for old libssh versions only (pre-0.8) and still works there,
> so I don't see any reason to change it.

I got deprecation warnings on this function/line while compiling. Why not merge it and remove build warnings?

The change in within the #else, maybe if you think it should be in the #if you can apply the change in that section (but I think in my case the else part got compiled).

Nevertheless, it's a deprecation that needs to be solved anyway.

> Not changing return (...) vs. return ..., the actual change
> looks good though.

Why not changing the return(). This is wrong code, it's just a boolean! Bad practice, please don't it. Don't be afraid to change it.

A generic remark: I think X2Go is missing a good pipeline with testcases and other quality checks. Which also hopefully increases your *trust in the code* and enables refactoring as well.

I'm not afraid to refactor the code and clean-up the formatting, splitting functions and even into multiple files. If this all improve readability, debuggability and test-ability long-term.

That is why I raise a request to create a decent pipeline to allow the necessary changes in further improve code maturity and the needed changes to do so.

And maybe even a better diff tool to perform refactoring changes during review.

Any ideas or suggestions? I'm running a GitLab instance myself for example; which enables DevOps and CI/CD within all my projects.

Thanks once more!

Kind regards,
Melroy van den Berg

[Message part 2 (text/html, inline)]

Send a report that this bug log contains spam.