X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Melroy van den Berg <melroy89@protonmail.com>

Date: Mon, 18 May 2020 18:55:02 UTC

Severity: normal

Tags: pending

Found in version 4.1.2.2

Fixed in version 4.1.2.3

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #57 received at 1469@bugs.x2go.org (full text, mbox, reply):

Received: (at 1469) by bugs.x2go.org; 20 May 2020 07:53:35 +0000
From ionic@ionic.de  Wed May 20 09:53:24 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail.ionic.de (ionic.de [87.98.244.45])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 6C3A25DC9B
	for <1469@bugs.x2go.org>; Wed, 20 May 2020 09:53:08 +0200 (CEST)
Received: from [10.20.44.8] (178.162.222.163.adsl.inet-telecom.org [178.162.222.163])
	by mail.ionic.de (Postfix) with ESMTPSA id CDC614F0B7B8;
	Wed, 20 May 2020 07:53:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1589961188; bh=s7bODzZH/nSwb+3QtyVmf24M8pVH4pB/uyQ/QKTN9tQ=;
	h=To:References:From:Subject:Date:In-Reply-To:From;
	b=qSY2M41ulkF4oYk5rFC8pl6gp37corrIEC6Bh0FkUR4emPYCKMEilRAfRxlEqB9Or
	 yrQnSQ88VnZ4P5do4vFT3SuifjAK0I0UqumEcLF+YQG8h/JoW7hrnVUJa2vJq3zVs6
	 C9O/LCLYlEgBT0cUIKcub9SMRRRLhs3ZwYNs+bdk=
To: Melroy van den Berg <melroy89@protonmail.com>, 1469@bugs.x2go.org,
 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
References: <vq79NxFEEt8Pcp8OgUNEMq3mjc-pTXr2Am-M5IFBFEQ3Z2QlGHllLVmhjXXGe6fRM_hIfq91T7Y419CPz62rBb9Yn0GQL6Fc2s1kdrffjlY=@protonmail.com>
 <VnStfHqOfEV696XWKKjeMSuahU9XjhK2Txgit7J8BASDxM9h7eFulrhhTX481UZ4QDaWEvDllKfWhjB1nhYCeZfXEgVGQ0jo-T87qRzFgBU=@protonmail.com>
From: Mihai Moldovan <ionic@ionic.de>
Autocrypt: addr=ionic@ionic.de; prefer-encrypt=mutual; keydata=
 mQINBEjok5sBEADlDP0MwtucH6BJN2pUuvLLuRgVo2rBG2TsE/Ijht8/C4QZ6v91pXEs02m0
 y/q3L/FzDSdcKddY6mWqplOiCAbT6F83e08ioF5+AqBs9PsI5XwohW9DPjtRApYlUiQgofe9
 0t9F/77hPTafypycks9buJHvWKRy7NZ+ZtYv3bQMPFXVmDG7FXJqI65uZh2jH9jeJ+YyGnBX
 j82XHHtiRoR7+2XVnDZiFNYPhFVBEML7X0IGICMbtWUd/jECMJ6g8V7KMyi321GP3ijC9ygh
 3SeT+Z+mJNkMmq2ii6Q2OkE12gelw1p0wzf7XF4Pl014pDp/j+A99/VLGyJK52VoNc8OMO5o
 gZE0DldJzzEmf+xX7fopNVE3NYtldJWG6QV+tZr3DN5KcHIOQ7JRAFlYuROywQAFrQb7TG0M
 S/iVEngg2DssRQ0sq9HkHahxCFyelBYKGAaljBJ4A4T8DcP2DoPVG5cm9qe4jKlJMmM1JtZz
 jNlEH4qp6ZzdpYT/FSWQWg57S6ISDryf6Cn+YAg14VWm0saE8NkJXTaOZjA+7qI/uOLLTUaa
 aGjSEsXFE7po6KDjx+BkyOrp3i/LBWcyClfY/OUvpyKT5+mDE5H0x074MTBcH9p7Zdy8DatA
 Jryb0vt2YeEe3vE4e1+M0kn8QfDlB9/VAAOmUKUvGTdvVlRNdwARAQABtB9NaWhhaSBNb2xk
 b3ZhbiA8aW9uaWNAaW9uaWMuZGU+iQJfBBMBCABJAhsjAh4BAheAAhkBCwsKDQkMCAsHAQMC
 BxUKCQgLAwIFFgIDAQAWIQRuEdCPdTOBx0TxyDwf1i7ZbiU6hwUCXXpwdAUJFobW2QAKCRAf
 1i7ZbiU6h1jEEACbB5FC6bqrLEWwqG2du2md+OoJQkTiuBaC4iv+CtiB5dJclteJWEszryVx
 zAeHmegCQH5JXgZB7KQiZs1V+tH2KFF9z1dUArnL8dygD8wvDWUbhVbRx3HdU25qfHOmmCdH
 xy5GKBqLXAiwYowIEudJiPwKm59OzsLBj6aDHLq2GmPdgs0f270g2lvUY0rNTYfUh7NAw0Zg
 DyVvknhekOgL4cPX9U43cqVcE6nNa5mcSSCSeBwSQGIdpcIGQK+msShXVQ1FjoEQbYUPCkpg
 R+M6qpsTTv18CiMCyoA2bGMthGcX2zy+CY1W5/UgRNcgzb1mS5uzWV7QCU17qo9d+3LsFYhI
 2PHHoE3LjZYUMI03nAmcJxqmg6l2frdzukn5B+Pn5Xwc0+3Q5AEoab0mY9j0AlcZoODoBoqr
 lrgjls4pMlB4Ye+sUx7NVU3kFOprRv8vA/P3LsuJfSm9TniDN/BN+dOo1K2miNBnEErEO3D2
 iFeFPihpSirv5Yf+qN8ClixJMGFHrvB/gxlNTz4GfvdgQjTjxzoeeIPwT8F4FwVm6wSFFlvc
 LsVprvPktqr+zEJU+5FIUXvBluKToCPVtazab3LKYi6JGUjVBUUrqsJAUwnxCe3ClIxl43w9
 FGiGVzo70ZL3lAfSCoI3TR91EUMs90Ct7zQaTxCzHuhR//SgrbQWSW9uaWMgPGlvbmljQGlv
 bmljLmRlPokCXAQTAQgARgIbIwIeAQIXgAsLCg0JDAgLBwEDAgcVCgkICwMCBRYCAwEAFiEE
 bhHQj3UzgcdE8cg8H9Yu2W4lOocFAl16cHUFCRaG1tkACgkQH9Yu2W4lOofrQQ/9EnYF6/ug
 GYMdBbz4DDQmL07N0rEFjPu0XyhNjEKBNkvh8YuoIOWdPZ92xUDuiIMA1rTGEBWQAjKK0khs
 eV/c0boiojBp4LvELhbYEZCVKYl2gW/NnRF/ifLf6IZ0i6mOCe6A1UE+tn64JLzE36N9Rxaa
 VNgnnAVJdIWehR7iJ3RnPC7ryDp4I69qHnpPpPh5ga/kGaBGrbQRkk8FqNGSxVrO7dq9rr3q
 BGFPe3r08mE0d9MehOok5efogjSxIubKYJT4M7vz+m/D5d9Dze1RCKMs6BCh2028d7BYXcr2
 Xk0j2JUxrDwe9zk0LR7P17l59l6Msyinf1F7j5gRysaE0ncVcA6JL7T638db4Z/4oJefXZPF
 4bdqclCscADcT8L7gCtW3F8GR7KCyUWReS243E3sdL/jqFnlcKb5Rs2I8G4Vebfx3N1DuvdM
 v+DOy/XJvUTviWxBFyLkgwrfiFRJwGhOAgFm3aeSwelnZBiAdDwosvjx4rW6wxoMA9lKwKFr
 92uTiH1A/X3JhUXpGU7EOjnf+ynXuL3bwsS1jQGS22jmPiKbudwHUQ5ZqJXkHYvtBUP5rWCT
 S8cqQNLC2pHdQR2ruAwtkfDpp00FcnGcrxYDy/CewiOXnIem53r4dzHk34CjeVwqdjfGyDnB
 YgrCp8gKjCRIq+vzlLYxUtX5NxC5Ag0ESOiTmwEQAPD65JnvgT8EampZZpjVLlgvGLfiel42
 AB/lH9JPx+jCwO2fmS/AB0PtDd9Oq/2BVZ8Nko4Wgzg8IUaDL3TiraCHCWfS9C0ALYs4WTGx
 wm/gjLXHsxmV2pl16ZNdE862yPYJ0Ts9cQZ05M6bjpIKONx0cexrmMvopjOC8Yf4X4ETOjBY
 0JXCLFHdFBkQsbqvEJsUakKUaLoAsD3l43znjEZGkFCOwPJCye205ks4wfX0gb+t2+22o4RR
 4ndQjmBntxGTmEYtUU825U56thXb/gTf73v/QXWYAKX0Ul/EJLi7LmRfTlh8SLN8MKb6haMg
 V0dvQqoK3EBRQPy5t4v3Xt5BblyVFRU2DOLS8FfOSfchrSup1LAP7+i13Gkxq0PT96yd4lT2
 CrshdsPCDKrxU5x7uvpwrwScS8pjrGCRTeFv+U2HVpNYXSGJpjZTPzx/kVi/M/tVlmYGTgTx
 SdBUEGw70zD+ptPxmU9WRVFaARvxQIiEPVA5fIEbBn3tMEuoM5Nnr13gGUMmQootw54uw4ti
 o2j6Z5f9Re2Xpbnm+1W4HaD0ZjQ/axYsSOmxQuMo5Upy+YsCIlCw5CwyTeZXERyORTv+m88F
 UoB5iPnjJTQP4crHU7afQIxO1ZFcXgvUyfpBGQ7+VVE0sVKTbFo/dtj5F/u/BGDzxkzhuMce
 zzKnABEBAAGJAjwEGAEIACYCGwwWIQRuEdCPdTOBx0TxyDwf1i7ZbiU6hwUCXXpwzgUJFobX
 MwAKCRAf1i7ZbiU6hyjNEADVXKjr9oeRgKlizeeflbqXb8rNzNFnB9bDYiFWwC1j49ACI46H
 OXaattvEAKlfYOMMyhbsYsICwat0jTFifXbXe65/BEWe7LHyRNj8d5k0fxUq5IicRmxvmMOC
 Ov2pwk1uIMdOD1KFpIK73vB2EIC1EJVBenFyz2WOW1saelfnL5dwhDMAck2yVIppXe+QKfVH
 zEIfyun9MaRBoBG3eqA3mSE+nyuJvbaIa6/VMXUCgkEzbAzzTts9sc6+3AAjmy7ruwE5q58i
 72uWq2P0x/hf12c4MbISCxGz1kDBH1xSdy4Gu5JrIdlMbnB5m+s/25/DJUTFHKBadHKjyVCW
 2py32fsgW06XJWrxFU9YIvgtkqpPILgNP+ey9Leuw85ugxFDNooaloDRHhoZ01B6HxbVmnoO
 wRv9oh9tohIbgg0EjEfCiismsysWeXdQh6QIMrMQbmjrfPtBpCApy5kYjtOBs16EOfBVJwno
 E11rVGq34LsEGx1fqJMr82awMI6u50tz7F1MQcVMvWoLDnkwyE5YviKHy1xmV793ByprMcbH
 z4/sc61J4EHABPxM+OTjrD1tniaMkLHVa5daJJoxVwKetu7voqhS1WKYUiYYezUUzQNoV7lQ
 O3CFNqnsEZNUM2wyub2f02n0pdzJazBP2zbdJHjTAP14TT9s/dPH9VNQ7bkCDQRI6JObARAA
 8Prkme+BPwRqallmmNUuWC8Yt+J6XjYAH+Uf0k/H6MLA7Z+ZL8AHQ+0N306r/YFVnw2SjhaD
 ODwhRoMvdOKtoIcJZ9L0LQAtizhZMbHCb+CMtcezGZXamXXpk10TzrbI9gnROz1xBnTkzpuO
 kgo43HRx7GuYy+imM4Lxh/hfgRM6MFjQlcIsUd0UGRCxuq8QmxRqQpRougCwPeXjfOeMRkaQ
 UI7A8kLJ7bTmSzjB9fSBv63b7bajhFHid1COYGe3EZOYRi1RTzblTnq2Fdv+BN/ve/9BdZgA
 pfRSX8QkuLsuZF9OWHxIs3wwpvqFoyBXR29CqgrcQFFA/Lm3i/de3kFuXJUVFTYM4tLwV85J
 9yGtK6nUsA/v6LXcaTGrQ9P3rJ3iVPYKuyF2w8IMqvFTnHu6+nCvBJxLymOsYJFN4W/5TYdW
 k1hdIYmmNlM/PH+RWL8z+1WWZgZOBPFJ0FQQbDvTMP6m0/GZT1ZFUVoBG/FAiIQ9UDl8gRsG
 fe0wS6gzk2evXeAZQyZCii3Dni7Di2KjaPpnl/1F7Zelueb7VbgdoPRmND9rFixI6bFC4yjl
 SnL5iwIiULDkLDJN5lcRHI5FO/6bzwVSgHmI+eMlNA/hysdTtp9AjE7VkVxeC9TJ+kEZDv5V
 UTSxUpNsWj922PkX+78EYPPGTOG4xx7PMqcAEQEAAYkCPAQYAQgAJgIbDBYhBG4R0I91M4HH
 RPHIPB/WLtluJTqHBQJdenDOBQkWhtczAAoJEB/WLtluJTqHKM0QANVcqOv2h5GAqWLN55+V
 updvys3M0WcH1sNiIVbALWPj0AIjjoc5dpq228QAqV9g4wzKFuxiwgLBq3SNMWJ9dtd7rn8E
 RZ7ssfJE2Px3mTR/FSrkiJxGbG+Yw4I6/anCTW4gx04PUoWkgrve8HYQgLUQlUF6cXLPZY5b
 Wxp6V+cvl3CEMwByTbJUimld75Ap9UfMQh/K6f0xpEGgEbd6oDeZIT6fK4m9tohrr9UxdQKC
 QTNsDPNO2z2xzr7cACObLuu7ATmrnyLva5arY/TH+F/XZzgxshILEbPWQMEfXFJ3Lga7kmsh
 2UxucHmb6z/bn8MlRMUcoFp0cqPJUJbanLfZ+yBbTpclavEVT1gi+C2Sqk8guA0/57L0t67D
 zm6DEUM2ihqWgNEeGhnTUHofFtWaeg7BG/2iH22iEhuCDQSMR8KKKyazKxZ5d1CHpAgysxBu
 aOt8+0GkICnLmRiO04GzXoQ58FUnCegTXWtUarfguwQbHV+okyvzZrAwjq7nS3PsXUxBxUy9
 agsOeTDITli+IofLXGZXv3cHKmsxxsfPj+xzrUngQcAE/Ez45OOsPW2eJoyQsdVrl1okmjFX
 Ap627u+iqFLVYphSJhh7NRTNA2hXuVA7cIU2qewRk1QzbDK5vZ/TafSl3MlrME/bNt0keNMA
 /XhNP2z908f1U1DtuQINBEjok5sBEADw+uSZ74E/BGpqWWaY1S5YLxi34npeNgAf5R/ST8fo
 wsDtn5kvwAdD7Q3fTqv9gVWfDZKOFoM4PCFGgy904q2ghwln0vQtAC2LOFkxscJv4Iy1x7MZ
 ldqZdemTXRPOtsj2CdE7PXEGdOTOm46SCjjcdHHsa5jL6KYzgvGH+F+BEzowWNCVwixR3RQZ
 ELG6rxCbFGpClGi6ALA95eN854xGRpBQjsDyQsnttOZLOMH19IG/rdvttqOEUeJ3UI5gZ7cR
 k5hGLVFPNuVOerYV2/4E3+97/0F1mACl9FJfxCS4uy5kX05YfEizfDCm+oWjIFdHb0KqCtxA
 UUD8ubeL917eQW5clRUVNgzi0vBXzkn3Ia0rqdSwD+/otdxpMatD0/esneJU9gq7IXbDwgyq
 8VOce7r6cK8EnEvKY6xgkU3hb/lNh1aTWF0hiaY2Uz88f5FYvzP7VZZmBk4E8UnQVBBsO9Mw
 /qbT8ZlPVkVRWgEb8UCIhD1QOXyBGwZ97TBLqDOTZ69d4BlDJkKKLcOeLsOLYqNo+meX/UXt
 l6W55vtVuB2g9GY0P2sWLEjpsULjKOVKcvmLAiJQsOQsMk3mVxEcjkU7/pvPBVKAeYj54yU0
 D+HKx1O2n0CMTtWRXF4L1Mn6QRkO/lVRNLFSk2xaP3bY+Rf7vwRg88ZM4bjHHs8ypwARAQAB
 iQI8BBgBCAAmAhsMFiEEbhHQj3UzgcdE8cg8H9Yu2W4lOocFAl16cM4FCRaG1zMACgkQH9Yu
 2W4lOocozRAA1Vyo6/aHkYCpYs3nn5W6l2/KzczRZwfWw2IhVsAtY+PQAiOOhzl2mrbbxACp
 X2DjDMoW7GLCAsGrdI0xYn1213uufwRFnuyx8kTY/HeZNH8VKuSInEZsb5jDgjr9qcJNbiDH
 Tg9ShaSCu97wdhCAtRCVQXpxcs9ljltbGnpX5y+XcIQzAHJNslSKaV3vkCn1R8xCH8rp/TGk
 QaARt3qgN5khPp8rib22iGuv1TF1AoJBM2wM807bPbHOvtwAI5su67sBOaufIu9rlqtj9Mf4
 X9dnODGyEgsRs9ZAwR9cUncuBruSayHZTG5weZvrP9ufwyVExRygWnRyo8lQltqct9n7IFtO
 lyVq8RVPWCL4LZKqTyC4DT/nsvS3rsPOboMRQzaKGpaA0R4aGdNQeh8W1Zp6DsEb/aIfbaIS
 G4INBIxHwoorJrMrFnl3UIekCDKzEG5o63z7QaQgKcuZGI7TgbNehDnwVScJ6BNda1Rqt+C7
 BBsdX6iTK/NmsDCOrudLc+xdTEHFTL1qCw55MMhOWL4ih8tcZle/dwcqazHGx8+P7HOtSeBB
 wAT8TPjk46w9bZ4mjJCx1WuXWiSaMVcCnrbu76KoUtVimFImGHs1FM0DaFe5UDtwhTap7BGT
 VDNsMrm9n9Np9KXcyWswT9s23SR40wD9eE0/bP3Tx/VTUO25Ag0ESOiTmwEQAPD65JnvgT8E
 ampZZpjVLlgvGLfiel42AB/lH9JPx+jCwO2fmS/AB0PtDd9Oq/2BVZ8Nko4Wgzg8IUaDL3Ti
 raCHCWfS9C0ALYs4WTGxwm/gjLXHsxmV2pl16ZNdE862yPYJ0Ts9cQZ05M6bjpIKONx0cexr
 mMvopjOC8Yf4X4ETOjBY0JXCLFHdFBkQsbqvEJsUakKUaLoAsD3l43znjEZGkFCOwPJCye20
 5ks4wfX0gb+t2+22o4RR4ndQjmBntxGTmEYtUU825U56thXb/gTf73v/QXWYAKX0Ul/EJLi7
 LmRfTlh8SLN8MKb6haMgV0dvQqoK3EBRQPy5t4v3Xt5BblyVFRU2DOLS8FfOSfchrSup1LAP
 7+i13Gkxq0PT96yd4lT2CrshdsPCDKrxU5x7uvpwrwScS8pjrGCRTeFv+U2HVpNYXSGJpjZT
 Pzx/kVi/M/tVlmYGTgTxSdBUEGw70zD+ptPxmU9WRVFaARvxQIiEPVA5fIEbBn3tMEuoM5Nn
 r13gGUMmQootw54uw4tio2j6Z5f9Re2Xpbnm+1W4HaD0ZjQ/axYsSOmxQuMo5Upy+YsCIlCw
 5CwyTeZXERyORTv+m88FUoB5iPnjJTQP4crHU7afQIxO1ZFcXgvUyfpBGQ7+VVE0sVKTbFo/
 dtj5F/u/BGDzxkzhuMcezzKnABEBAAGJAjwEGAEIACYCGwwWIQRuEdCPdTOBx0TxyDwf1i7Z
 biU6hwUCXXpwzgUJFobXMwAKCRAf1i7ZbiU6hyjNEADVXKjr9oeRgKlizeeflbqXb8rNzNFn
 B9bDYiFWwC1j49ACI46HOXaattvEAKlfYOMMyhbsYsICwat0jTFifXbXe65/BEWe7LHyRNj8
 d5k0fxUq5IicRmxvmMOCOv2pwk1uIMdOD1KFpIK73vB2EIC1EJVBenFyz2WOW1saelfnL5dw
 hDMAck2yVIppXe+QKfVHzEIfyun9MaRBoBG3eqA3mSE+nyuJvbaIa6/VMXUCgkEzbAzzTts9
 sc6+3AAjmy7ruwE5q58i72uWq2P0x/hf12c4MbISCxGz1kDBH1xSdy4Gu5JrIdlMbnB5m+s/
 25/DJUTFHKBadHKjyVCW2py32fsgW06XJWrxFU9YIvgtkqpPILgNP+ey9Leuw85ugxFDNooa
 loDRHhoZ01B6HxbVmnoOwRv9oh9tohIbgg0EjEfCiismsysWeXdQh6QIMrMQbmjrfPtBpCAp
 y5kYjtOBs16EOfBVJwnoE11rVGq34LsEGx1fqJMr82awMI6u50tz7F1MQcVMvWoLDnkwyE5Y
 viKHy1xmV793ByprMcbHz4/sc61J4EHABPxM+OTjrD1tniaMkLHVa5daJJoxVwKetu7voqhS
 1WKYUiYYezUUzQNoV7lQO3CFNqnsEZNUM2wyub2f02n0pdzJazBP2zbdJHjTAP14TT9s/dPH
 9VNQ7bkCDQRI6JObARAA8Prkme+BPwRqallmmNUuWC8Yt+J6XjYAH+Uf0k/H6MLA7Z+ZL8AH
 Q+0N306r/YFVnw2SjhaDODwhRoMvdOKtoIcJZ9L0LQAtizhZMbHCb+CMtcezGZXamXXpk10T
 zrbI9gnROz1xBnTkzpuOkgo43HRx7GuYy+imM4Lxh/hfgRM6MFjQlcIsUd0UGRCxuq8QmxRq
 QpRougCwPeXjfOeMRkaQUI7A8kLJ7bTmSzjB9fSBv63b7bajhFHid1COYGe3EZOYRi1RTzbl
 Tnq2Fdv+BN/ve/9BdZgApfRSX8QkuLsuZF9OWHxIs3wwpvqFoyBXR29CqgrcQFFA/Lm3i/de
 3kFuXJUVFTYM4tLwV85J9yGtK6nUsA/v6LXcaTGrQ9P3rJ3iVPYKuyF2w8IMqvFTnHu6+nCv
 BJxLymOsYJFN4W/5TYdWk1hdIYmmNlM/PH+RWL8z+1WWZgZOBPFJ0FQQbDvTMP6m0/GZT1ZF
 UVoBG/FAiIQ9UDl8gRsGfe0wS6gzk2evXeAZQyZCii3Dni7Di2KjaPpnl/1F7Zelueb7Vbgd
 oPRmND9rFixI6bFC4yjlSnL5iwIiULDkLDJN5lcRHI5FO/6bzwVSgHmI+eMlNA/hysdTtp9A
 jE7VkVxeC9TJ+kEZDv5VUTSxUpNsWj922PkX+78EYPPGTOG4xx7PMqcAEQEAAYkCPAQYAQgA
 JgIbDBYhBG4R0I91M4HHRPHIPB/WLtluJTqHBQJdenDOBQkWhtczAAoJEB/WLtluJTqHKM0Q
 ANVcqOv2h5GAqWLN55+Vupdvys3M0WcH1sNiIVbALWPj0AIjjoc5dpq228QAqV9g4wzKFuxi
 wgLBq3SNMWJ9dtd7rn8ERZ7ssfJE2Px3mTR/FSrkiJxGbG+Yw4I6/anCTW4gx04PUoWkgrve
 8HYQgLUQlUF6cXLPZY5bWxp6V+cvl3CEMwByTbJUimld75Ap9UfMQh/K6f0xpEGgEbd6oDeZ
 IT6fK4m9tohrr9UxdQKCQTNsDPNO2z2xzr7cACObLuu7ATmrnyLva5arY/TH+F/XZzgxshIL
 EbPWQMEfXFJ3Lga7kmsh2UxucHmb6z/bn8MlRMUcoFp0cqPJUJbanLfZ+yBbTpclavEVT1gi
 +C2Sqk8guA0/57L0t67Dzm6DEUM2ihqWgNEeGhnTUHofFtWaeg7BG/2iH22iEhuCDQSMR8KK
 KyazKxZ5d1CHpAgysxBuaOt8+0GkICnLmRiO04GzXoQ58FUnCegTXWtUarfguwQbHV+okyvz
 ZrAwjq7nS3PsXUxBxUy9agsOeTDITli+IofLXGZXv3cHKmsxxsfPj+xzrUngQcAE/Ez45OOs
 PW2eJoyQsdVrl1okmjFXAp627u+iqFLVYphSJhh7NRTNA2hXuVA7cIU2qewRk1QzbDK5vZ/T
 afSl3MlrME/bNt0keNMA/XhNP2z908f1U1DtuQINBEjok5sBEADw+uSZ74E/BGpqWWaY1S5Y
 Lxi34npeNgAf5R/ST8fowsDtn5kvwAdD7Q3fTqv9gVWfDZKOFoM4PCFGgy904q2ghwln0vQt
 AC2LOFkxscJv4Iy1x7MZldqZdemTXRPOtsj2CdE7PXEGdOTOm46SCjjcdHHsa5jL6KYzgvGH
 +F+BEzowWNCVwixR3RQZELG6rxCbFGpClGi6ALA95eN854xGRpBQjsDyQsnttOZLOMH19IG/
 rdvttqOEUeJ3UI5gZ7cRk5hGLVFPNuVOerYV2/4E3+97/0F1mACl9FJfxCS4uy5kX05YfEiz
 fDCm+oWjIFdHb0KqCtxAUUD8ubeL917eQW5clRUVNgzi0vBXzkn3Ia0rqdSwD+/otdxpMatD
 0/esneJU9gq7IXbDwgyq8VOce7r6cK8EnEvKY6xgkU3hb/lNh1aTWF0hiaY2Uz88f5FYvzP7
 VZZmBk4E8UnQVBBsO9Mw/qbT8ZlPVkVRWgEb8UCIhD1QOXyBGwZ97TBLqDOTZ69d4BlDJkKK
 LcOeLsOLYqNo+meX/UXtl6W55vtVuB2g9GY0P2sWLEjpsULjKOVKcvmLAiJQsOQsMk3mVxEc
 jkU7/pvPBVKAeYj54yU0D+HKx1O2n0CMTtWRXF4L1Mn6QRkO/lVRNLFSk2xaP3bY+Rf7vwRg
 88ZM4bjHHs8ypwARAQABiQI8BBgBCAAmAhsMFiEEbhHQj3UzgcdE8cg8H9Yu2W4lOocFAl16
 cM8FCRaG1zMACgkQH9Yu2W4lOoeg2g//bEUXU3+TEu30Viix530A9zSkA0ScIuoYsywVy9rY
 2TU8hrAvjhNjQTDQqxL2Qk4ijzkubKB+gUEu2defsJY8P2g3CtEU5BGeKD6rUdDfwGdm+cra
 +w13rcQVDZgDLtLXPA4hpLF/7f8zr0MB6I+c+TO3ePSOGYY4FiwhMan/2uqHPG4aknDe4DIe
 CTyokt4kMY2yYAaWkv9fJfl4FoHi5nlMwoAUPYtDSbg2J4ln83DIRMzLopL0FSct0KQxEwn+
 9ZA1xUBV9ldXvpqa5bMkqih3Nq/sWRAHk/HieVjkCQOL/2RPs0zBggGVaFq7suxxfNHDaS6V
 KEkhk55mzl88C9MdcxODfLW4emjSKLbLwmMW16TlGEP37WpctaU5+y46TnFUp0J2tlQtJZjO
 XQYBOYExP3UwykxB8qqHnV6oxGTXDa+vVYJOOH/oEG423O2wx7ZrZkwn3EFgMR5KctagtR9p
 yY8VZnXP0FWSNqmbluA57drBPFrbKu5VvBfdx2ByJ5CYif88mA7lLcUix7PNqurgpblDsHzJ
 yH/c7rtlS/Tre/63adLfr8dco2iJo0UH8QIlC1h1439u19eDKtLvJh12ps7FHfUgDnJvxSVG
 PfSwPH9prRd3coBHIi5w72U5Bzh4C/0M1/qZaffKDMZi+9bssC22gY6adAaqWd1AoLu5Ag0E
 SOiTmwEQAPD65JnvgT8EampZZpjVLlgvGLfiel42AB/lH9JPx+jCwO2fmS/AB0PtDd9Oq/2B
 VZ8Nko4Wgzg8IUaDL3TiraCHCWfS9C0ALYs4WTGxwm/gjLXHsxmV2pl16ZNdE862yPYJ0Ts9
 cQZ05M6bjpIKONx0cexrmMvopjOC8Yf4X4ETOjBY0JXCLFHdFBkQsbqvEJsUakKUaLoAsD3l
 43znjEZGkFCOwPJCye205ks4wfX0gb+t2+22o4RR4ndQjmBntxGTmEYtUU825U56thXb/gTf
 73v/QXWYAKX0Ul/EJLi7LmRfTlh8SLN8MKb6haMgV0dvQqoK3EBRQPy5t4v3Xt5BblyVFRU2
 DOLS8FfOSfchrSup1LAP7+i13Gkxq0PT96yd4lT2CrshdsPCDKrxU5x7uvpwrwScS8pjrGCR
 TeFv+U2HVpNYXSGJpjZTPzx/kVi/M/tVlmYGTgTxSdBUEGw70zD+ptPxmU9WRVFaARvxQIiE
 PVA5fIEbBn3tMEuoM5Nnr13gGUMmQootw54uw4tio2j6Z5f9Re2Xpbnm+1W4HaD0ZjQ/axYs
 SOmxQuMo5Upy+YsCIlCw5CwyTeZXERyORTv+m88FUoB5iPnjJTQP4crHU7afQIxO1ZFcXgvU
 yfpBGQ7+VVE0sVKTbFo/dtj5F/u/BGDzxkzhuMcezzKnABEBAAGJAjwEGAEIACYCGwwWIQRu
 EdCPdTOBx0TxyDwf1i7ZbiU6hwUCXXpwzwUJFobXMwAKCRAf1i7ZbiU6h6DaD/9sRRdTf5MS
 7fRWKLHnfQD3NKQDRJwi6hizLBXL2tjZNTyGsC+OE2NBMNCrEvZCTiKPOS5soH6BQS7Z15+w
 ljw/aDcK0RTkEZ4oPqtR0N/AZ2b5ytr7DXetxBUNmAMu0tc8DiGksX/t/zOvQwHoj5z5M7d4
 9I4ZhjgWLCExqf/a6oc8bhqScN7gMh4JPKiS3iQxjbJgBpaS/18l+XgWgeLmeUzCgBQ9i0NJ
 uDYniWfzcMhEzMuikvQVJy3QpDETCf71kDXFQFX2V1e+mprlsySqKHc2r+xZEAeT8eJ5WOQJ
 A4v/ZE+zTMGCAZVoWruy7HF80cNpLpUoSSGTnmbOXzwL0x1zE4N8tbh6aNIotsvCYxbXpOUY
 Q/ftaly1pTn7LjpOcVSnQna2VC0lmM5dBgE5gTE/dTDKTEHyqoedXqjEZNcNr69Vgk44f+gQ
 bjbc7bDHtmtmTCfcQWAxHkpy1qC1H2nJjxVmdc/QVZI2qZuW4Dnt2sE8Wtsq7lW8F93HYHIn
 kJiJ/zyYDuUtxSLHs82q6uCluUOwfMnIf9zuu2VL9Ot7/rdp0t+vx1yjaImjRQfxAiULWHXj
 f27X14Mq0u8mHXamzsUd9SAOcm/FJUY99LA8f2mtF3dygEciLnDvZTkHOHgL/QzX+plp98oM
 xmL71uywLbaBjpp0BqpZ3UCguw==
Subject: Re: [X2Go-Dev] Bug#1469: But wait; there is more... patches!
Message-ID: <5742cbf3-aab2-205b-5c14-df9754a6c5c5@ionic.de>
Date: Wed, 20 May 2020 09:52:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <VnStfHqOfEV696XWKKjeMSuahU9XjhK2Txgit7J8BASDxM9h7eFulrhhTX481UZ4QDaWEvDllKfWhjB1nhYCeZfXEgVGQ0jo-T87qRzFgBU=@protonmail.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="zzBLN4VGd9gFW6RRF3CgybeUWH27vf3qO"

[Message part 1 (text/plain, inline)]
* On 5/19/20 11:24 PM, Melroy van den Berg wrote:
> As Mike suggested, I redone all changes (plus even some more bonus items).
> Since I was in a separate git branch I could run the format-patch easily via:git
> format-patch master. Thanks for the suggestion.
> 
> @Uli I'm using the auto-formatter for C++ built-in in VS Code.
> 
> I think the end-result with all the separate patches makes more sense now, sorry
> I didn't do it right away. I think once I have a wiki account, I will add all
> these best practices your x2go wiki. Instead of Attachment: <your-patch.diff>:
> https://wiki.x2go.org/doku.php/wiki:bugs?s[]=git&s[]=patch#bug_submission_with_a_patch.
> 
> See the attachments for all the patches in this mail (11 in total). Thanks in
> advance.

Alex's coding style is... special, I guess, but I usually don't change it unless
I have to change a line anyway and mine can also be considered odd at times.


0001-First-auto-format-the-code-for-readability-and-human.patch: won't apply,
it's just adding unnecessary noise and making blaming more difficult.


0002-endl-for-every-debug-line.patch: won't apply. Using (std::)endl is actually
a bug, because qDebug (which is used by x2goDebug internally) already appends a
newline character by default, so another endl call would just give us double
newlines and make the log output worse. I'm actually tempted to remove the other
endls instead, but there's no real benefit in doing so immediately, so I'll just
keep them until a change to the lines has to be made anyway (or it fits
semantically).


0003-send-eof-before-close.patch: good catch, thanks, applied. Strictly
speaking, though, this should not cause any issues, as ssh_channel_close () will
(according to its documentation) already send an EOF. The worst thing that
SHOULD happen is that the additional ssh_channel_send_eof () call is unnecessary
and will cause an internal error in libssh because it might want to write to an
already EOF'd and closed channel. Then again, this error should be benign, since
we'll kill the channel right away anyway.


0004-return-false-in-all-bad-cases.patch: applied, thanks.


0005-Refactor-and-fix-channel-session-closes.patch: highly amended, but mostly
ultimately applied. Did not apply unnecessary code style or endl changes, but
picked most stuff. Also, I originally made the new function static because I
didn't see any benefit in having it part of the API for other places to call it.
Turned out this was a bad idea, so I reverted to registering it within the class
and make it private, like you did. Thanks.


0006-Remove-deprecated-call-and-use-new-libssh-API-call.-.patch: won't apply.
This code path is for old libssh versions only (pre-0.8) and still works there,
so I don't see any reason to change it. Newer versions should already use the
non-deprecated function, so everything's fine.


0007-Fix-when-not-password-auth.-Otherwise-you-get-double.patch: mostly applied,
slightly amended. Not changing return (...) vs. return ..., the actual change
looks good though.


0008-Correct-retval-check.-Plus-some-minor-formatting.patch: functionally
applied, minus formatting.


0009-Another-missing-endl.patch: not applied, same reasoning as for 0001.


0010-Mark-as-unused-explicitly.patch: can't hurt, I guess, so applied, but
slightly amended.


0011-improve-gitignore-why-not.patch: mostly applied, without the .gitignore
file entry deletion which is intentional.



Mihai


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 23 13:33:26 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.