X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)

Full log

Message #30 received at 1469@bugs.x2go.org (full text, mbox, reply):

Received: (at 1469) by bugs.x2go.org; 19 May 2020 20:38:05 +0000
From ulrich.sibiller@gmail.com  Tue May 19 22:37:41 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FREEMAIL_REPLYTO,
	FREEMAIL_REPLYTO_END_DIGIT,SPF_HELO_NONE,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.2
Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 3763A5DAF0
	for <1469@bugs.x2go.org>; Tue, 19 May 2020 22:37:36 +0200 (CEST)
Received: by mail-qk1-x741.google.com with SMTP id f13so1241742qkh.2
        for <1469@bugs.x2go.org>; Tue, 19 May 2020 13:37:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:reply-to:from:date:message-id
         :subject:to:cc:content-transfer-encoding;
        bh=wW4HPKFCbHhsbQ8RAaao0qw8/Tkizk6pQJcTaszk+yM=;
        b=K6iMypcSmavy74qNkuMFFxTdEDp+L9rjP08jwQK704+MbUAwE6USrAwYdxjOG8iv0i
         gDotZ9gB0qT7uLBs1WZ1qrSFVLdIpzUF/bYs7WVttR4dq/UAIHHyMRBQOyr3xpsvh5I0
         rSD3D8WCE5u1wJ6DlKtmhO8bTOf0DBhMJdj93qpOqgCtozPFowzNi0rnhS4wwoOwfkti
         3QP2TtGlDQYQtlt6cEdXRrLj12Tic5S0bTkUXKKK30rScoaGqmAgs4Lp9AE+yzbLdDwm
         8E8u5Vd92Tv6INdT1Z7v5Ioluz9bYtkhHFHp/QkWWfbJz7BMxLrF3PxHn33ya4kzOUG+
         N0cA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:reply-to
         :from:date:message-id:subject:to:cc:content-transfer-encoding;
        bh=wW4HPKFCbHhsbQ8RAaao0qw8/Tkizk6pQJcTaszk+yM=;
        b=GSsNySiqbO58NHTYK0kGXUYB4n6SOG8s/HiUNYH/zody9tMEKglf/H36B/XHPDnfkL
         qMyesrvsxWlTQHGHC/dUubB8rrxXUWxK+o2N+Mj8QrHv0reY448beFjHbIoSo53e3mbe
         7+GEcLx5NUxYXPe8wpXw8R1PLkMzC62IrL1c7fpgNegyKKZAM9egAxUFl/xK7Bl3nzv/
         uuZEAry/hWztKALqfioqySiEVWUpKgEhxiezC1hOkrNf01baUUFIM/p2wWY+2zwQC53H
         y5+ieRdUY/p45MPaEH05BypneuLhR7DiISWKhdax6PoTH59PvQNo8COxNV5UFBKHPyh+
         kOtQ==
X-Gm-Message-State: AOAM532NMkEXils3Q+5gg6zeqMuHS9tZGc/zO6R5GQQHhtcnt1lYBOcP
	ZwDicJP8Wbbf/lQbaleiinoP6SjRUiuVJnmb914=
X-Google-Smtp-Source: ABdhPJx1hMzkNeoQ1qHc53B3F7ufKoQWgxhm+OiASfUVkRs9CbjlJWZFNGRJx1HHuOx+0hpnN/M0K3qenwWBA9NO4vU=
X-Received: by 2002:a25:785:: with SMTP id 127mr1989167ybh.306.1589920654779;
 Tue, 19 May 2020 13:37:34 -0700 (PDT)
MIME-Version: 1.0
References: <Nf4e-RR7tv5ZjrP9b31cyDJXHDClVE5R6fFyaE0wsZNPOk928OaXhMPa1ORMSsmATLtCa2Jp8XlSZqscpcQh-P9Em3cji311xXVTm_JUrnI=@protonmail.com>
 <vq79NxFEEt8Pcp8OgUNEMq3mjc-pTXr2Am-M5IFBFEQ3Z2QlGHllLVmhjXXGe6fRM_hIfq91T7Y419CPz62rBb9Yn0GQL6Fc2s1kdrffjlY=@protonmail.com>
 <20200519194833.Horde.kr6XjaMhAMOcOXrvwxL5PjI@mail.das-netzwerkteam.de> <vwmmt0MpRwz20ya2I5-8qr7-aJ2JCq98JUDJJtHfzwSTnw40ZtvMJcqJNXII0hKASmilLCHLKekLnhna6OsDx11KLVYN4IFEOq4yQCv0awg=@protonmail.com>
In-Reply-To: <vwmmt0MpRwz20ya2I5-8qr7-aJ2JCq98JUDJJtHfzwSTnw40ZtvMJcqJNXII0hKASmilLCHLKekLnhna6OsDx11KLVYN4IFEOq4yQCv0awg=@protonmail.com>
Reply-To: uli42@gmx.de
From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Date: Tue, 19 May 2020 22:37:08 +0200
Message-ID: <CANVnVYLuG=28Cn_BP7BuFNPkNWawE4x7t-nLOK5duQ2tDJ5ESA@mail.gmail.com>
Subject: Re: [X2Go-Dev] Bug#1469: Bug#1469: Patch!
To: Melroy van den Berg <melroy89@protonmail.com>, 1469@bugs.x2go.org
Cc: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

What about taking the original code, run your auto-formatter (what
tool are you using?), make a patch. Then copy your patched version
over the auto-formatted version and create one or more other patches,
depending on your changes. Using git add -p this is very easy to
accomplish.

Uli

On Tue, May 19, 2020 at 10:08 PM Melroy van den Berg
<melroy89@protonmail.com> wrote:
>
> Hi,
>
> Well.. it was not unnecessary. The code was actually unreadable, wrong indentations and inconsistent throughout the whole file.
> I needed to execute this auto-formatter, before I could even begin to understand the code.
>
> In fact, I urge you to execute this on the whole archive. And keep the code quality high via a CI pipeline or something.
>
> I can understand it makes it hard to read. I also fixed other some issues like this double error message during login and all the debug statements.
> What would be your approach? I think it's still wise to auto-format the code in consistent matter.
>
> Regards,
> Melroy van den Berg
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> Op dinsdag, mei 19, 2020 9:48 PM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> schreef:
>
> > Hi Melroy,
> >
> > On Di 19 Mai 2020 03:59:16 CEST, Melroy van den Berg wrote:
> >
> > > Hi,
> > > I did some refactoring in the sshmasterconnection.cpp file. I think > it can definitely use some clean-up and further splitting functions > and even into multiple files eventually.
> > > I cloned the master branch of code.x2go.org/x2goclient repo.
> > > The changes I applied are in the attachment of this mail (a git > patch file). I think closing previous sessions and connection solved > my strange SSH connection is resulting into Socket error: No such > file or directory".
> > > Although X2Go client is calling libssh > calls (libssh version > currently in use runtime on my host is: 0.7.0).
> > > For some reason this vague error message popped-up by libssh, > properly a result of previous session being created and not > correctly closed. And/or not closed in the right order (/missing API > calls), like a good example:
> > > ssh_channel_send_eof(channel);
> > > ssh_channel_close(channel);
> > > ssh_channel_free(channel);
> > > And I created yet again a new YT video showing my result:
> > > https://youtu.be/vmASLJq0CKM
> > > (including some brief explanation what I did so far, I also ran an > formatted on the code, because it was very very hard to read with > all the wrong indents)
> > > I also made another video showing yet another bug I found regarding > the SSH tunneling (during some heavy testing), the only solution was > to restart the whole docker image:
> > > https://youtu.be/xEpIyo84fWc (I think this issue is unrelated, but > maybe wise to take serious as well)
> > > Again see attachment for the patch (branched from master).
> > > Regards,
> > > Melroy van den Berg
> >
> > Thanks for working on X2Go Client. With your patch, there is a problem though. It is barely unreviewable, because you have so many changes (also white space changes) in one patch file.
> >
> > Please clone the X2Go Client Git repo, add atomic changes with good commit messages. Keep white-space changes and technical changes fully separate (ideally: technical changes first, white-space changes last).
> >
> > Then export your patches using 'git format-patch <last-official-commit>..HEAD' and send us the set of patches instead this one bulk commit/patch.
> >
> > Thanks for your efforts!!!
> >
> > Mike
> >
> > -----------------------------------
> >
> > DAS-NETZWERKTEAM
> > c\o Technik- und Ökologiezentrum Eckernförde
> > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
> > mobile: +49 (1520) 1976 148
> > landline: +49 (4351) 850 8940
> >
> > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
> > mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
> _______________________________________________
> x2go-dev mailing list
> x2go-dev@lists.x2go.org
> https://lists.x2go.org/listinfo/x2go-dev

Send a report that this bug log contains spam.