#1469 - X2Go Client connection issue (Socket error)

X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)

Reported by: Melroy van den Berg <melroy89@protonmail.com>

Date: Mon, 18 May 2020 18:55:02 UTC

Severity: normal

Tags: pending

Found in version 4.1.2.2

Fixed in version 4.1.2.3

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

X-Loop: owner@bugs.x2go.org
Subject: Bug#1469: [X2Go-Dev] Bug#1469: Patch!
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 1469@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 19 May 2020 19:50:10 +0000
Resent-Message-ID: <handler.1469.B1469.158991772119000@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1469
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
References: <vq79NxFEEt8Pcp8OgUNEMq3mjc-pTXr2Am-M5IFBFEQ3Z2QlGHllLVmhjXXGe6fRM_hIfq91T7Y419CPz62rBb9Yn0GQL6Fc2s1kdrffjlY=@protonmail.com> <Nf4e-RR7tv5ZjrP9b31cyDJXHDClVE5R6fFyaE0wsZNPOk928OaXhMPa1ORMSsmATLtCa2Jp8XlSZqscpcQh-P9Em3cji311xXVTm_JUrnI=@protonmail.com> <vq79NxFEEt8Pcp8OgUNEMq3mjc-pTXr2Am-M5IFBFEQ3Z2QlGHllLVmhjXXGe6fRM_hIfq91T7Y419CPz62rBb9Yn0GQL6Fc2s1kdrffjlY=@protonmail.com>
Received: via spool by 1469-submit@bugs.x2go.org id=B1469.158991772119000
          (code B ref 1469); Tue, 19 May 2020 19:50:10 +0000
Received: (at 1469) by bugs.x2go.org; 19 May 2020 19:48:41 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.5 required=3.0 tests=BAYES_00,KHOP_HELO_FCRDNS,
	SPF_HELO_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no
	version=3.4.2
Received: from fregna.das-netzwerkteam.de (fregna-internal.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E674F5DAF0
	for <1469@bugs.x2go.org>; Tue, 19 May 2020 21:48:33 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [148.251.201.105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 5F97C605B1;
	Tue, 19 May 2020 19:48:33 +0000 (UTC)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 5761BC0195;
	Tue, 19 May 2020 21:48:33 +0200 (CEST)
Received: from [37.123.126.38] ([37.123.126.38]) by mail.das-netzwerkteam.de
 (Horde Framework) with HTTPS; Tue, 19 May 2020 19:48:33 +0000
Date: Tue, 19 May 2020 19:48:33 +0000
Message-ID: <20200519194833.Horde.kr6XjaMhAMOcOXrvwxL5PjI@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Melroy van den Berg <melroy89@protonmail.com>, 1469@bugs.x2go.org
In-Reply-To: <Nf4e-RR7tv5ZjrP9b31cyDJXHDClVE5R6fFyaE0wsZNPOk928OaXhMPa1ORMSsmATLtCa2Jp8XlSZqscpcQh-P9Em3cji311xXVTm_JUrnI=@protonmail.com>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 37.123.126.38
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Firefox/68.0
Content-Type: multipart/signed; boundary="=_mXA6mNgrNWoJDlZN3GRzIQY";
 protocol="application/pgp-signature"; micalg=pgp-sha512
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

Hi Melroy, On Di 19 Mai 2020 03:59:16 CEST, Melroy van den Berg wrote: > Hi, > > I did some refactoring in the sshmasterconnection.cpp file. I think > it can definitely use some clean-up and further splitting functions > and even into multiple files eventually. > I cloned the master branch of code.x2go.org/x2goclient repo. > > The changes I applied are in the attachment of this mail (a git > patch file). I think closing previous sessions and connection solved > my strange SSH connection is resulting into Socket error: No such > file or directory". > Although X2Go client is calling [libssh > calls](https://api.libssh.org/master/index.html) (libssh version > currently in use runtime on my host is: 0.7.0). > For some reason this vague error message popped-up by libssh, > properly a result of previous session being created and not > correctly closed. And/or not closed in the right order (/missing API > calls), like a good example: > > ssh_channel_send_eof(channel); > ssh_channel_close(channel); > ssh_channel_free(channel); > > And I created yet again a new YT video showing my result: > https://youtu.be/vmASLJq0CKM > (including some brief explanation what I did so far, I also ran an > formatted on the code, because it was very very hard to read with > all the wrong indents) > > I also made another video showing yet another bug I found regarding > the SSH tunneling (during some heavy testing), the only solution was > to restart the whole docker image: > https://youtu.be/xEpIyo84fWc (I think this issue is unrelated, but > maybe wise to take serious as well) > > Again see attachment for the patch (branched from master). > > Regards, > Melroy van den Berg Thanks for working on X2Go Client. With your patch, there is a problem though. It is barely unreviewable, because you have so many changes (also white space changes) in one patch file. Please clone the X2Go Client Git repo, add atomic changes with good commit messages. Keep white-space changes and technical changes fully separate (ideally: technical changes first, white-space changes last). Then export your patches using 'git format-patch <last-official-commit>..HEAD' and send us the set of patches instead this one bulk commit/patch. Thanks for your efforts!!! Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 23 13:06:16 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #1469 X2Go Client connection issue (Socket error)

X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)