X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)

Full log

Message #15 received at 1469@bugs.x2go.org (full text, mbox, reply):

Received: (at 1469) by bugs.x2go.org; 19 May 2020 01:59:39 +0000
From melroy89@protonmail.com  Tue May 19 03:59:32 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,
	HTML_MESSAGE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.2
Received: from mail4.protonmail.ch (mail4.protonmail.ch [185.70.40.27])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 031CC5DAF0
	for <1469@bugs.x2go.org>; Tue, 19 May 2020 03:59:24 +0200 (CEST)
Date: Tue, 19 May 2020 01:59:16 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
	s=protonmail; t=1589853562;
	bh=vxifWNEn9yV8EmFqpaaRWWLw6CCPvlJ2iQ/OzrNcVEc=;
	h=Date:To:From:Reply-To:Subject:From;
	b=H5u6KTMCdik1ckVncU0bDLWlxnIF8scuMSHabGehMMwg5BBMKxZMSu17cW8FQJRKL
	 NQBxybz9LCYAmkSh9xupa+Uiz2NR7q25NqOd0njpQns5duVsSpxOGZq7IzD93z6weF
	 uqz86ofwAYWRVMrKqK9EL2WXW9UzOkn8n8ulcMEo=
To: "1469@bugs.x2go.org" <1469@bugs.x2go.org>
From: Melroy van den Berg <melroy89@protonmail.com>
Reply-To: Melroy van den Berg <melroy89@protonmail.com>
Subject: Patch!
Message-ID: <Nf4e-RR7tv5ZjrP9b31cyDJXHDClVE5R6fFyaE0wsZNPOk928OaXhMPa1ORMSsmATLtCa2Jp8XlSZqscpcQh-P9Em3cji311xXVTm_JUrnI=@protonmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="b1_d4bbc6fe9ba24f53adc087369873ae07"

[Message part 1 (text/plain, inline)]

Hi,

I did some refactoring in the sshmasterconnection.cpp file. I think it can definitely use some clean-up and further splitting functions and even into multiple files eventually.
I cloned the master branch of code.x2go.org/x2goclient repo.

The changes I applied are in the attachment of this mail (a git patch file). I think closing previous sessions and connection solved my strange SSH connection is resulting into Socket error: No such file or directory".
Although X2Go client is calling [libssh calls](https://api.libssh.org/master/index.html) (libssh version currently in use runtime on my host is: 0.7.0).
For some reason this vague error message popped-up by libssh, properly a result of previous session being created and not correctly closed. And/or not closed in the right order (/missing API calls), like a good example:

ssh_channel_send_eof(channel);
ssh_channel_close(channel);
ssh_channel_free(channel);

And I created yet again a new YT video showing my result:
https://youtu.be/vmASLJq0CKM
(including some brief explanation what I did so far, I also ran an formatted on the code, because it was very very hard to read with all the wrong indents)

I also made another video showing yet another bug I found regarding the SSH tunneling (during some heavy testing), the only solution was to restart the whole docker image:
https://youtu.be/xEpIyo84fWc (I think this issue is unrelated, but maybe wise to take serious as well)

Again see attachment for the patch (branched from master).

Regards,
Melroy van den Berg

[Message part 2 (text/html, inline)]

[melroy_socket_error.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.