X2Go Bug report logs - #1353
with dash as default shell, x2goagent.options are not being parsed correctly

version graph

Package: x2goserver-x2goagent; Maintainer for x2goserver-x2goagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver-x2goagent is src:x2goserver.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Mon, 10 Dec 2018 11:15:01 UTC

Severity: normal

Found in version 4.1.0.3

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1353: [X2Go-Dev] Bug#1353: with dash as default shell, x2goagent.options are not being parsed correctly
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 1353@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 10 Dec 2018 14:35:01 +0000
Resent-Message-ID: <handler.1353.B1353.154445221311778@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1353
X-X2Go-PR-Package: x2goserver-x2goagent
X-X2Go-PR-Keywords: 
Received: via spool by 1353-submit@bugs.x2go.org id=B1353.154445221311778
          (code B ref 1353); Mon, 10 Dec 2018 14:35:01 +0000
Received: (at 1353) by bugs.x2go.org; 10 Dec 2018 14:30:13 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 296C95DAEF
	for <1353@bugs.x2go.org>; Mon, 10 Dec 2018 15:30:10 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 7pPncfuVaqkc for <1353@bugs.x2go.org>;
	Mon, 10 Dec 2018 15:30:01 +0100 (CET)
Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 3DB2F5DA26
	for <1353@bugs.x2go.org>; Mon, 10 Dec 2018 15:30:01 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [148.251.201.105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 136C360540;
	Mon, 10 Dec 2018 14:30:01 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 09819C26F2;
	Mon, 10 Dec 2018 15:30:01 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id w6YGytTAg2du; Mon, 10 Dec 2018 15:29:54 +0100 (CET)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id D3B85C26DB;
	Mon, 10 Dec 2018 15:29:54 +0100 (CET)
Received: from m-088.informatik.uni-kiel.de (m-088.informatik.uni-kiel.de
 [134.245.254.88]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS;
 Mon, 10 Dec 2018 14:29:54 +0000
Date: Mon, 10 Dec 2018 14:29:54 +0000
Message-ID: <20181210142954.Horde.XTLq4qL3F982mrKXDU6Q-B0@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Stefan Baur <X2Go-ML-1@baur-itcs.de>, 1353@bugs.x2go.org
In-Reply-To: <7ad80b01-6169-8fa9-5b67-d94b0725d579@baur-itcs.de>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.88
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Firefox/60.0
Content-Type: multipart/signed; boundary="=_d_7Yo736KSLlW29B_WLTMf4";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Hi Stefan,

On  Mo 10 Dez 2018 12:00:56 CET, Stefan Baur wrote:

> package: x2goserver-x2goagent
> version: 4.1.0.3
>
> According to a user, when dash is set as the default shell,
> x2goagent.options are not being parsed correctly, as dash does not
> understand the "+=" syntax used in this file to concatenate various
> options.  The particular piece of code that sources/runs this file
> should be calling bash explicitly to avoid this.
>
> -Stefan

The x2goagent.options file is sourced by x2gostartagent and that uses  
/bin/bash as shebang.

I am inclined to close this bug unless you have more info. Even if you  
user as /bin/dash as default shell, the x2goagent.options file should  
be sourced by bash.

MIke
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Dec 5 04:34:47 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.