X2Go Bug report logs - #1353
with dash as default shell, x2goagent.options are not being parsed correctly

version graph

Package: x2goserver-x2goagent; Maintainer for x2goserver-x2goagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver-x2goagent is src:x2goserver.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Mon, 10 Dec 2018 11:15:01 UTC

Severity: normal

Found in version 4.1.0.3

Full log

Message #30 received at 1353@bugs.x2go.org (full text, mbox, reply):

Received: (at 1353) by bugs.x2go.org; 13 Dec 2018 19:29:52 +0000
From mike.gabriel@das-netzwerkteam.de  Thu Dec 13 20:29:49 2018
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_20,RDNS_NONE
	autolearn=no autolearn_force=no version=3.4.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 05B945DAEF
	for <1353@bugs.x2go.org>; Thu, 13 Dec 2018 20:29:49 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NjEjMTJN2tNQ for <1353@bugs.x2go.org>;
	Thu, 13 Dec 2018 20:29:43 +0100 (CET)
Received: from fregna.das-netzwerkteam.de (unknown [IPv6:2a01:4f8:202:1381::1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 4E61B5DACB
	for <1353@bugs.x2go.org>; Thu, 13 Dec 2018 20:29:43 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 36C1D610AE
	for <1353@bugs.x2go.org>; Thu, 13 Dec 2018 19:29:43 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 294F9C275E
	for <1353@bugs.x2go.org>; Thu, 13 Dec 2018 20:29:43 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pLP1kdDkhslc for <1353@bugs.x2go.org>;
	Thu, 13 Dec 2018 20:29:37 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 4D81DC276F
	for <1353@bugs.x2go.org>; Thu, 13 Dec 2018 20:29:37 +0100 (CET)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 38628C275E;
	Thu, 13 Dec 2018 20:29:37 +0100 (CET)
X-Priority: 3
To: X2Go-ML-1@baur-itcs.de
Cc: 1353@bugs.x2go.org
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Subject: Re: [X2Go-Dev] Bug#1353:  Bug#1353: with dash as default shell,
 x2goagent.options are not being parsed correctly
In-Reply-To: <711a9a29-55eb-46b7-be18-3a189be010ad@baur-itcs.de>
References: <20181210142954.Horde.XTLq4qL3F982mrKXDU6Q-B0@mail.das-netzwerkteam.de>
 <c0e49f8a-b10b-2e60-74ed-ecc26bc6384b@baur-itcs.de>
 <711a9a29-55eb-46b7-be18-3a189be010ad@baur-itcs.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: base64
Date: Thu, 13 Dec 2018 19:29:35 +0000
MIME-Version: 1.0
Message-ID: <20181213202937.Horde.EIQf-t7HY1SeaxbUeOCHTMJ@mail.das-netzwerkteam.de>
User-Agent: Horde Application Framework 5

Hi Stefan,

On Monday, 10 December 2018, Stefan Baur wrote:
> Am 10.12.18 um 15:32 schrieb Stefan Baur:
> >> The x2goagent.options file is sourced by x2gostartagent and that uses
> >> /bin/bash as shebang.
> >>
> >> I am inclined to close this bug unless you have more info. Even if you
> >> user as /bin/dash as default shell, the x2goagent.options file should be
> >> sourced by bash.
> > Interesting.  Please keep it open for now; I will check back with the
> > affected user.  For some reason, their session wasn't picking up the
> > x2goagent.options, and they had /bin/dash as their default shell.
> 
> The user says that not the individual accounts' shell was set to
> /bin/dash, but the system-wide default shell.
> And changing it to /bin/bash fixed the issue for them.
> Grepping through the X2Go code, I found several instances where /bin/sh
> is used (/usr/sbin/x2golistsessions_root, /usr/sbin/x2gocleansessions,
> /usr/bin/x2gopath, /usr/bin/x2gobasepath, /etc/init.d/x2goserver,
> /usr/bin/x2goprint).  There is also a match in the /usr/bin/x2goagent
> binary.
> 
> Could it be that x2gostartagent itself is being called in a way that
> skips the shebang line? (e.g. "/bin/sh -c /usr/bin/x2gostartagent")
>  

Ouch! Good point. We should look at x2goclient debugging output and check how X2Go Client launches x2gostartagent. IIRC, it use such a call as you mentioned above....

Mike

-- 
Sent from my Jolla

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 21:02:00 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.