X2Go Bug report logs - #1353
with dash as default shell, x2goagent.options are not being parsed correctly

version graph

Package: x2goserver-x2goagent; Maintainer for x2goserver-x2goagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver-x2goagent is src:x2goserver.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Mon, 10 Dec 2018 11:15:01 UTC

Severity: normal

Found in version 4.1.0.3

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1353: [X2Go-Dev] Bug#1353: with dash as default shell, x2goagent.options are not being parsed correctly
Reply-To: Stefan Baur <X2Go-ML-1@baur-itcs.de>, 1353@bugs.x2go.org
Resent-From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 10 Dec 2018 19:35:02 +0000
Resent-Message-ID: <handler.1353.B1353.154447035729797@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1353
X-X2Go-PR-Package: x2goserver-x2goagent
X-X2Go-PR-Keywords: 
Received: via spool by 1353-submit@bugs.x2go.org id=B1353.154447035729797
          (code B ref 1353); Mon, 10 Dec 2018 19:35:02 +0000
Received: (at 1353) by bugs.x2go.org; 10 Dec 2018 19:32:37 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D80945DAEF
	for <1353@bugs.x2go.org>; Mon, 10 Dec 2018 20:32:34 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id GzU-eZmsF34B for <1353@bugs.x2go.org>;
	Mon, 10 Dec 2018 20:32:25 +0100 (CET)
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id D7E0C5DA26
	for <1353@bugs.x2go.org>; Mon, 10 Dec 2018 20:32:23 +0100 (CET)
Received: from [192.168.0.15] ([149.172.203.221]) by mrelayeu.kundenserver.de
 (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id
 1M6EKU-1gYc5X0yXg-006hRa for <1353@bugs.x2go.org>; Mon, 10 Dec 2018 20:32:23
 +0100
To: 1353@bugs.x2go.org
References: <20181210142954.Horde.XTLq4qL3F982mrKXDU6Q-B0@mail.das-netzwerkteam.de>
 <c0e49f8a-b10b-2e60-74ed-ecc26bc6384b@baur-itcs.de>
From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
Openpgp: preference=signencrypt
Autocrypt: addr=X2Go-ML-1@baur-itcs.de; prefer-encrypt=mutual; keydata=
 xsBNBFLfOiwBCACzIiDVwWVRvuMzgSAvXRFRaPaZOSB8s84PG1oGLfmqhwzF44vj1Xv4tcKD
 mvu0TsLTksOkvop8WwGYeeU8lDaxEG1zyN8SOu1WU/FPEKw2jITRox8yIrSkUsMkWYuxdjv/
 9XcAh9qaPsHP7E1jD6/wVZuYZkuX6W41Nxt06VsvDGCfrbQh4ya7w1IiSnoQeIHNNQVN9f3j
 xcHLj5S5YriSCThtbFCdr3AJXfF5iMolu8kLgAXM0bH1C7PxAjM/pQjWmdMVN/Y+uXXzcMO8
 8aQ0f0q3QeGWxCAP2xwBapUfP6LHDRPp/tV7P7ji8wKlabrSGdv0M9Qd9pn/YCYQE0ZdABEB
 AAHNJlN0ZWZhbiBCYXVyIDxwb3N0bWFzdGVyQHN0ZWZhbmJhdXIuZGU+wsCCBBMBAgAsAhsj
 BQkJZgGABwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AFAlNGc+ECGQEACgkQbt30GM2+URlB
 /Af+MbRrzRMTzSg7N6MUob1MXDpnuUjtzMWddfuHpL7/D2VuY4AaYGkChrD2sdl2C+UIaCXv
 t0P/QU6Fm+yMTr023pioaBy74heCiusBZI7GufqKMsOcQUgpGZaaHwCijUceJR0lrq4Hy3dF
 tgrv+gLjlqDy/cqWBfoohd8JAINk0gHIWFJIm8El1bEvr1sxQ5Bw5zdshD/C0GEI8zsdI6GW
 uZ+tpBB6BA+k19CU0tW/BFoUJ8MyRk4m75UtwLmBMmVji6coGAnXKwud30OsCnmbSreBFpw7
 xS3coC/PHMT02YR1UAEuRJ6NCzpHfQT4qXjU3wQSj/5VSJOlG+qBNht4/87ATQRS3zosAQgA
 4KPXmGU1XE8CTRJ/4m/f8MTri3JfEvGJTerWwC2hBuXHGWrSBmmRNAdJHzNTvq5IoR9tQ6Cb
 Nrqxf6alr/v34Vr2bUg0s+jlK9TWOkVLAFoz6zytm/2BrRBIZ5So6Ymfc6efwsScsHOI++wi
 pzqELkpluqtXysb13RsBVLxBdp5TZCVPjCc9pLWjudfjEagQt2oJgtO2WndasrKvoZYkfRi6
 oSCK9B84YjNJoRF00LdK3n7K3SBvj4UPSl+ygzLVaD+3ZdIlbhX+bfn/Vp/10xdJ+/U8Fr7l
 7umrBKr17D8eO3mRYMGY9w1qc+pfNGOR76GIbPWj2tPVaBD9nmUaowARAQABwsBlBBgBAgAP
 BQJS3zosAhsMBQkJZgGAAAoJEG7d9BjNvlEZ77YIAJViZTXJ5V0OOUQIYxzQIOao2nkASHeE
 AHT0/sq/H26z9ak9G4JsUwYF7jWg2V3MNI0jDhkIs9tZMHlT/BQxT8oM/UfIzPwjfhrWK41p
 QPnaDT8AB/nJl9p+IOt9NvPfMIL7iO7a+/au2hpHbX3p85vXR1oqquHmAaMls67a3uCkTHUW
 8+ilwfXleF8+9AOLV1Ys5ue1d8kh3+2VM7tE9f0wt2N8akFTBXJg/gIKH2YCc8xoOxhl0bv3
 +If4QjOPBUxb6+ge5IThHtVWI5K5Wr9ORnjcS00v2P7Zf02R5FTEq8nCFr+CeAOin8WlTtWs
 bzi9QGo4aIv+5+HKkfVEC34=
Message-ID: <711a9a29-55eb-46b7-be18-3a189be010ad@baur-itcs.de>
Date: Mon, 10 Dec 2018 20:32:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <c0e49f8a-b10b-2e60-74ed-ecc26bc6384b@baur-itcs.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="vRqdcTEPcQ3STkTIGXx0eU24F21nDaS8D"
X-Provags-ID: V03:K1:H0H+aJh9qaArNRUSbk16ZpMsmw6HwiUNllLIjc7ngNZf2ukwQ1n
 A1Wa2ZPIPEzL8TRl94bgblOjpzV9t1klvLSmlEhcY0HP4re8q2C2TIdXID4E9Pq4Mie0LpP
 dILRenvB+wNEs1qYz52v7T2WWMYMF8jq0BVM0FIvOQ25EZQ9B07nJjXDm7MnnbCoYCfcVbN
 6w7Q1lBco1u7l0Ireh3Kg==
X-UI-Out-Filterresults: notjunk:1;V03:K0:q9EizodIxNI=:ldB9V+Q4I2itI15fmyqDv3
 3agcpvBMGy0iRyGzPLkxaaei5+fmw8SaQvr3jWlGrzkzloL1X70SBOc9G5elau3meRNgtkGHH
 bilU7krFgMFTTJN+K+1qU0xapXINPUxXKhvmIkCmmFaxox6N9K2uMqIyKHkPQJJqi5V42J8IZ
 aEQjbdo6prMJ9UBSnraC9WRbM3z2a9af787XfEAB5xCrA7Q2GImzyhzCS40X8Eixof/mQH/lH
 erH4wVAAHroim2GSLMZadVZT94Rkf7HoOGzTh4oqXDHL1tTU8ML4vPciVHjEDIOL4g6SUcho6
 6YiP9ywwlFwzLab+Lu41dnGoTgfD+gI4MVaTQ5RjV0Fnlrz8BcpxvhFGbMEgdVy/UbqMz7Tvl
 iOmOU/kl0txTJoveB4ocfMwlrft9ymfeyyARH1ApenPokksv3s1rOJVyQgW/9CwjDz5D2F9Lm
 ZWGb1Xa9W1RotMdH6lS/YJgybupsUSv1WEsgv4lNifgTp3/9lUm02P3IcIw8Czflw69beho36
 ADLCt10ncuwt8LWg8LHYYGkAFWMc5MjBjQcQ5DFxrCHZ9ibMhbnGFR+/zmkPlWp96hjQGFJ4x
 mri627QUFC5NruJmmWUF9kH77Hn2ei/93Sd0y+OzNNl+JFiJeTIsXDQH8N5l2QTCAeNYDOs+I
 rId8031kSFvkImbGt0S0IEg9w5+++tH7aIyVPQ7mZTd39CsvsBmk8pqUvv0HJK14GVA3gU7Ze
 0v2jVxku2cAcALiRNkoGScDj5vkfu0TZlsLfJjYTVLy6XWd5cEU0YWlNfTk=

[Message part 1 (text/plain, inline)]
Am 10.12.18 um 15:32 schrieb Stefan Baur:
>> The x2goagent.options file is sourced by x2gostartagent and that uses
>> /bin/bash as shebang.
>>
>> I am inclined to close this bug unless you have more info. Even if you
>> user as /bin/dash as default shell, the x2goagent.options file should be
>> sourced by bash.
> Interesting.  Please keep it open for now; I will check back with the
> affected user.  For some reason, their session wasn't picking up the
> x2goagent.options, and they had /bin/dash as their default shell.

The user says that not the individual accounts' shell was set to
/bin/dash, but the system-wide default shell.
And changing it to /bin/bash fixed the issue for them.
Grepping through the X2Go code, I found several instances where /bin/sh
is used (/usr/sbin/x2golistsessions_root, /usr/sbin/x2gocleansessions,
/usr/bin/x2gopath, /usr/bin/x2gobasepath, /etc/init.d/x2goserver,
/usr/bin/x2goprint).  There is also a match in the /usr/bin/x2goagent
binary.

Could it be that x2gostartagent itself is being called in a way that
skips the shebang line? (e.g. "/bin/sh -c /usr/bin/x2gostartagent")


Kind Regards,
Stefan Baur

-- 
BAUR-ITCS UG (haftungsbeschränkt)
Geschäftsführer: Stefan Baur
Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 20:48:35 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.