X2Go Bug report logs - #1295
x2goclient/broker mode : don't close on suspended session with --close-disconnect

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Walid MOGHRABI <w.moghrabi@servicemagic.eu>

Date: Wed, 9 May 2018 14:05:02 UTC

Severity: normal

Found in version 4.1.2.0-0~1750~ubuntu16.04.1

Full log


Message #10 received at 1295@bugs.x2go.org (full text, mbox, reply):

Received: (at 1295) by bugs.x2go.org; 15 May 2018 12:01:18 +0000
From mike.gabriel@das-netzwerkteam.de  Tue May 15 14:01:15 2018
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=3.0 tests=BAYES_00,RDNS_NONE,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 96B995DAE9
	for <1295@bugs.x2go.org>; Tue, 15 May 2018 14:01:15 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TCb9OYTJwL0X for <1295@bugs.x2go.org>;
	Tue, 15 May 2018 14:01:09 +0200 (CEST)
Received: from fregna.das-netzwerkteam.de (unknown [IPv6:2a01:4f8:202:1381::1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 7FF665DACE
	for <1295@bugs.x2go.org>; Tue, 15 May 2018 14:01:09 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [148.251.201.105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 6441560532;
	Tue, 15 May 2018 12:01:09 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 55420C47EC;
	Tue, 15 May 2018 14:01:09 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id IrxnJSCypNRW; Tue, 15 May 2018 14:01:03 +0200 (CEST)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id D0AE6C47EA;
	Tue, 15 May 2018 14:01:03 +0200 (CEST)
Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de
 [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS;
 Tue, 15 May 2018 12:01:03 +0000
Date: Tue, 15 May 2018 12:01:03 +0000
Message-ID: <20180515120103.Horde.J-atjJEMwEJEk_ujSVdemdf@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Walid MOGHRABI <w.moghrabi@servicemagic.eu>, 1295@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#1295: x2goclient/broker mode : don't close on
 suspended session with --close-disconnect
References: <1577747420.29014986.1525874065272.JavaMail.root@servicemagic.eu>
 <386210362.29017491.1525874443782.JavaMail.root@servicemagic.eu>
In-Reply-To: <386210362.29017491.1525874443782.JavaMail.root@servicemagic.eu>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 178.62.101.154
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0
Content-Type: multipart/signed; boundary="=_kFyUyOxNCD5hccLdzezhhcP";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Hi Walid,

On  Mi 09 Mai 2018 16:00:43 CEST, Walid MOGHRABI wrote:

> package: x2goclient
> version: 4.1.2.0-0~1750~ubuntu16.04.1
> priority: bug
>
> In broker/tce mode, when I connect a new session on TCE-CLIENT-1, if  
> I live migrate the running session on TCE-CLIENT-2, the session is  
> detached from client 1 to client 2 correctly (suspended on client 1  
> and correctly resumed on client 2) but x2goclient doesn't close  
> itself on client 1 once session is detached.

This per se is a bug, as --close-disconnect fails.

> The client stays opened on the sessions profiles list with the  
> currently logged in user instead of closing itself and getting back  
> to the broker login prompt.

I think --close-disconnect is not what you want. You want --broker-autologoff.

> This is a major security issue since anyone can then just click on a  
> session profile to connect with the current user credentials.

Understood. However, please check if you can achieve the correct  
behaviour with --broker-autologoff. It saves you the X2Go Client  
restarts on session logout.

Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Apr 17 14:32:23 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.