X2Go Bug report logs - #1183
Pass broker creds to RDP client as plaintext

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Walid MOGHRABI <w.moghrabi@servicemagic.eu>

Date: Wed, 31 May 2017 14:45:02 UTC

Severity: wishlist

Tags: patch

Full log


Message #10 received at 1183@bugs.x2go.org (full text, mbox, reply):

Received: (at 1183) by bugs.x2go.org; 31 May 2017 19:58:41 +0000
From mike.gabriel@das-netzwerkteam.de  Wed May 31 21:58:40 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4393C5DAD3
	for <1183@bugs.x2go.org>; Wed, 31 May 2017 21:58:40 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Dwe-wFogG9hk for <1183@bugs.x2go.org>;
	Wed, 31 May 2017 21:58:33 +0200 (CEST)
Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 637A05DACE
	for <1183@bugs.x2go.org>; Wed, 31 May 2017 21:58:33 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 0F47A60748;
	Wed, 31 May 2017 19:58:33 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 03AA5C7C8A;
	Wed, 31 May 2017 21:58:33 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id QMEavv4nciCW; Wed, 31 May 2017 21:58:28 +0200 (CEST)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 73CE8C7C85;
	Wed, 31 May 2017 21:58:28 +0200 (CEST)
Received: from p57B5CC09.dip0.t-ipconnect.de (p57B5CC09.dip0.t-ipconnect.de
 [87.181.204.9]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS;
 Wed, 31 May 2017 19:58:28 +0000
Date: Wed, 31 May 2017 19:58:28 +0000
Message-ID: <20170531195828.Horde.vAcyRcGCGpIX0L09g1bH-8e@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Walid MOGHRABI <w.moghrabi@servicemagic.eu>, 1183@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#1183: Pass broker creds to RDP client as
 plaintext
References: <1917592832.211198.1490277173586.JavaMail.root@servicemagic.eu>
 <1693780969.10950067.1496241649670.JavaMail.root@servicemagic.eu>
In-Reply-To: <1693780969.10950067.1496241649670.JavaMail.root@servicemagic.eu>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 87.181.204.9
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Firefox/45.0
Content-Type: multipart/signed; boundary="=_pXq0OcvXuYV6HgJ8HoRarfo";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Hi Walid,

On  Mi 31 Mai 2017 16:40:49 CEST, Walid MOGHRABI wrote:

> package: x2goclient
> priority: wishlist
> tags: patch
>
> This is a proposal patch in order to let the RDP client use the  
> credentials used at broker auth login so that users can enter them  
> only once in broker mode.
>
> This patch also add support for --close-disconnect in broker mode + RDP

I just looked at your patch.

Requests before patch can get accepted:

  1. Please split up the RDP broker creds as session creds from the  
--close-disconnect change.
  2. Please let the cmdline option start with --broker-...

           --broker-use-creds-for-session

  3. Don't limit this functionality to RDP sessions only. It is  
useful for all sorts of session
     types (X2Go, DirectRDP, DirectXDMCP if already in (there were  
rumours about such a new feature)).

Thanks for your work on X2Go,
Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Jan 31 20:08:17 2023; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.