X2Go Bug report logs - #1155
Volume levels are not saved with TCE

version graph

Package: x2gothinclient; Maintainer for x2gothinclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2gothinclient is src:x2gothinclient.

Reported by: Walid MOGHRABI <w.moghrabi@servicemagic.eu>

Date: Mon, 13 Mar 2017 10:45:01 UTC

Severity: normal

Found in version 1.5.0.0

Full log


Message #35 received at 1155@bugs.x2go.org (full text, mbox, reply):

Received: (at 1155) by bugs.x2go.org; 28 Mar 2017 12:19:26 +0000
From ionic@ionic.de  Tue Mar 28 14:19:25 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=3.0 tests=BAYES_20,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS autolearn=ham autolearn_force=no
	version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 3DB525DAD1
	for <1155@bugs.x2go.org>; Tue, 28 Mar 2017 14:19:24 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id LLp8y2AeGGbP for <1155@bugs.x2go.org>;
	Tue, 28 Mar 2017 14:19:17 +0200 (CEST)
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 934B65DAD0
	for <1155@bugs.x2go.org>; Tue, 28 Mar 2017 14:19:17 +0200 (CEST)
Received: from nopileos.local (178.162.222.163.adsl.inet-telecom.org [178.162.222.163])
	by mail.ionic.de (Postfix) with ESMTPSA id BA04E4F00145;
	Tue, 28 Mar 2017 14:19:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1490703557; bh=/VUTi86UfmmHZTUMGHmyG8FykK9I4Hevf/vq2VKYEYI=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=Rue29xZiM1+8XDWjnUTqPqbMTq8GIXLXMjQZRPIlO0K9zkvKlpj72PbYN7trwHqwj
	 xlXzBav/4T2eu1xAurqAQ/tlGeOl8ruFXMwS6ETUIpBAtmcsu0nqSP64+p2tSJvfkD
	 ui+2iFmoPCavFbJlCYPmC+R8jChbv3KdKhX38kn4=
Subject: Re: Volume levels are not saved with TCE
To: Walid MOGHRABI <w.moghrabi@servicemagic.eu>, 1155@bugs.x2go.org
References: <75149176.888907.1490686875815.JavaMail.root@servicemagic.eu>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <04c30efe-21d7-28dc-3a65-37cf96255d99@ionic.de>
Date: Tue, 28 Mar 2017 14:19:12 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0)
 Gecko/20100101 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <75149176.888907.1490686875815.JavaMail.root@servicemagic.eu>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="hASSrmr6XlKHu0dkVCeciqQwF2hd611Ck"
[Message part 1 (text/plain, inline)]
On 28.03.2017 09:41 AM, Walid MOGHRABI wrote:
> Well, I would like the settings to be saved inside the X2Go session then restored from there.
> I know TCEs are read only (or volatile) so you can't save the client settings there and then get them back from there.
> From a local client with X2Go client installed, it works of course since it relies on the local settings that can be saved in this situation.
> But thinclient mode is a bit different and I suppose there should be a way to :
> 
>     1) save the volume levels at the X2Go session level when closing the session (maybe something that can be done through a logout script or the x2gocleansession process)
>     2) retrieve the volume levels from the X2Go session and use it to set the local pulseaudio settings (probably through geting values from saved settings through SSH at connection time)
> 
> This could be activated only in --thinclient mode so that, normal X2Goclient behaviour could keep on using the local pulseaudio settings and not geting the ones from the X2Go session.

That's not really something we want to do, because the volume we talk about here
is a client-side setting.

In a simple setup where only one client machine ever connects to one session,
and that client machine never changes, that might work, but in any more
complicated setup it's a recipe for doom.

Further, given that I know your setup a little bit, saving or restoring settings
would not work as expected when for instance additional headsets are *not*
plugged in while the session is established but later on.


x2ogcleansessions is a totally wrong approach for stuff like that, because
saving the settings must be done while the client is still connected (since we
need to access the client-side PA daemon.)

If anything, you could use x2goserver's hooks infrastructure, but I'm not sure
in what context these scripts are executed. If it's any context that doesn't
inherit environment variables from the client, that's not going to work. The
pre-suspend/pre-terminate and post-resume/post-scripts hooks (check
/usr/lib/x2go/extensions) might be promising places for something like that.


Again, as a general feature that's probably causing more trouble than it's
worth, especially when using multiple sessions at a time or when changing
client-side stuff.



Mihai

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Mon Apr 22 19:18:34 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.