X2Go Bug report logs - #1100
xterm's shell started from x2goclient has wrong PATH

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Mark Dixon <m.c.dixon@leeds.ac.uk>

Date: Tue, 11 Oct 2016 15:05:01 UTC

Severity: normal

Tags: pending

Merged with 1018, 1199

Found in version 4.0.5.1

Fixed in versions 4.1.0.1, 4.1.1.0

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1100: Solution Proposal
Reply-To: "Ezell, Matthew A." <ezellma@ornl.gov>, 1100@bugs.x2go.org
Resent-From: "Ezell, Matthew A." <ezellma@ornl.gov>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 21 Mar 2017 21:25:02 +0000
Resent-Message-ID: <handler.1100.B1100.149013125830094@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1100
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 1100-submit@bugs.x2go.org id=B1100.149013125830094
          (code B ref 1100); Tue, 21 Mar 2017 21:25:02 +0000
Received: (at 1100) by bugs.x2go.org; 21 Mar 2017 21:20:58 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_50,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS autolearn=ham autolearn_force=no
	version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 45A215DAD0
	for <1100@bugs.x2go.org>; Tue, 21 Mar 2017 22:20:56 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Rvjc1XO24JEx for <1100@bugs.x2go.org>;
	Tue, 21 Mar 2017 22:20:49 +0100 (CET)
X-Greylist: delayed 627 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Tue, 21 Mar 2017 22:20:48 CET
Received: from mta02.ornl.gov (mta02.ornl.gov [128.219.177.136])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 83B8D5DA4B
	for <1100@bugs.x2go.org>; Tue, 21 Mar 2017 22:20:47 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=ornl.gov; i=@ornl.gov; q=dns/txt; s=p20151116;
  t=1490131248; x=1521667248;
  h=from:to:subject:date:message-id:content-id:
   content-transfer-encoding:mime-version;
  bh=9AESayAyl35IcmbEQg+ZVY2y8HQQSmpKiRbkx10ljCQ=;
  b=p+Ru5sQKv7kFbsleNR2VetWU/qKwDzBGrRijq/Mh84Ms/QG/3/nqph4K
   Hu9PDbla8pI0uzx2G9gEGhKS91NvLX/4RthF6X6eiqTnmzBDYvU21OkRP
   JmNRJMFnKaxVGxBXZvTpd5BpDkmifQhpkzj6di8WDmWLRUus/kaZHur6t
   3b++KTPiI8UjGJ+vf/y5VBceqGhlxm+rZ/r/uYREzlcjQp6CkK/IZ9Jzu
   QTSKTEWhezkCj+AIjCUA/9tlQH8VSjaCF5kE6fovmqZrkEUp8ZKtvJze/
   aRHQc9+99oW67RGnpYER+BhLTw83/J+f6gT5wXTCGYOuHcSkUhWmgSJxY
   Q==;
X-SG: RELAYLIST
X-IronPort-AV: E=Sophos;i="5.36,201,1486443600"; 
   d="scan'208";a="8195498"
Received: from emgwy1.ornl.gov ([160.91.254.9])
  by iron2.ornl.gov with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 17:10:17 -0400
Received: from EXCHOS31.ornl.gov (exchos31.ornl.gov [128.219.12.151])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by emgwy1.ornl.gov (Postfix) with ESMTPS id 3vnlp15j6Dz7tF7
	for <1100@bugs.x2go.org>; Tue, 21 Mar 2017 17:10:17 -0400 (EDT)
Received: from EXCHOS30.ornl.gov (128.219.12.150) by EXCHOS31.ornl.gov
 (128.219.12.151) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 21 Mar
 2017 17:10:17 -0400
Received: from EXCHCS31.ornl.gov (128.219.12.145) by EXCHOS30.ornl.gov
 (128.219.12.150) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 21 Mar
 2017 17:10:17 -0400
Received: from EXCHCS31.ornl.gov ([fe80::cde0:6908:129a:fa57]) by
 EXCHCS31.ornl.gov ([fe80::cde0:6908:129a:fa57%16]) with mapi id
 15.00.1178.000; Tue, 21 Mar 2017 17:10:16 -0400
From: "Ezell, Matthew A." <ezellma@ornl.gov>
To: "1100@bugs.x2go.org" <1100@bugs.x2go.org>
Thread-Topic: Solution Proposal
Thread-Index: AQHSooeJZjqC3+izBE6oFGeFPFirkQ==
Date: Tue, 21 Mar 2017 21:10:16 +0000
Message-ID: <4D7014AD-633C-47C6-972E-682DB0282F70@ornl.gov>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1e.0.170107
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [128.219.12.132]
Content-Type: text/plain; charset="utf-8"
Content-ID: <773F3CA56DD2EA45BDE7029C931473F7@ornl.gov>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
I’m not sure I understand what nefarious behavior #336 is supposed to prevent either.  It did, unfortunately, make x2go unusable in our environment.

I propose one of the following solutions:

1. Revert the behavior (sounds like this isn’t going to happen?)
2. Add a ‘secure path’ boolean session option in the client (you can leave it on by default, I’ll have my users turn it off)
3. In the client, hard code the full path to the x2go server and convert x2go to use all absolute paths (hopefully this prevents all the same things as #336 without the side effect)
4. Option 3, but add an ‘x2go server binary’ string session option in the client in case the admin installed x2go in an alternate location
5. Save the path before setting it (export X2GOSAVEPATH=$PATH; export PATH=<safe_path>; cmd).  Then, somewhere after all the x2go stuff has been run, restore the original path

I’ll be happy to test implementations once the core developers determine the best path forward.

Thanks,
~Matt


Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Sep 26 03:41:38 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.