X2Go Bug report logs - #928
x2goclient 4.0.5.0 overwrites user's shell

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#928: X2Go issue (in src:x2goclient) has been marked as pending for release
Reply-To: Mihai Moldovan <ionic@ionic.de>, 928@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 14 Jan 2016 04:20:02 +0000
Resent-Message-ID: <handler.928.B928.145274490413157@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 928
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: patch
Received: via spool by 928-submit@bugs.x2go.org id=B928.145274490413157
          (code B ref 928); Thu, 14 Jan 2016 04:20:02 +0000
Received: (at 928) by bugs.x2go.org; 14 Jan 2016 04:15:04 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 933D35DB16; Thu, 14 Jan 2016 05:15:01 +0100 (CET)
From: Mihai Moldovan <ionic@ionic.de>
To: 928-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 928@bugs.x2go.org
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20160114041501.933D35DB16@ymir.das-netzwerkteam.de>
Date: Thu, 14 Jan 2016 05:15:01 +0100 (CET)

tag #928 pending
fixed #928 4.0.5.1
thanks

Hello,

X2Go issue #928 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=256e30d

The issue will most likely be fixed in src:x2goclient (4.0.5.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 256e30d47178a7d4c8f8e25317d60a4fca673a3d
Author: Orion Poplawski <orion@cora.nwra.com>
Date:   Thu Jan 14 03:16:49 2016 +0100

    ssh{process,masterconnection}.cpp: run bash as a login shell when invoking any command remotely. Fixes: #928.
    
    Because this opens the door for ~/.bash_logout and friend scripts to be
    executed, which may contain calls to ncurses' reset or clear, also set
    the TERM variable to dump to not have unexpected output on stderr at
    logout time.

diff --git a/debian/changelog b/debian/changelog
index 7cee1e5..a3d37fa 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -53,6 +53,14 @@ x2goclient (4.0.5.1-0x2go1) UNRELEASED; urgency=low
     - Windows: Update bundled Win32 OpenSSL from 1.0.1p to 1.0.1q,
       which fixes the multiple CVEs announced on 2015-12-03.
 
+  [ Orion Poplawski ]
+  * New upstream release (4.0.5.1):
+    - ssh{process,masterconnection}.cpp: run bash as a login shell when
+      invoking any command remotely. Fixes: #928. Because this opens the door
+      for ~/.bash_logout and friend scripts to be executed, which may contain
+      calls to ncurses' reset or clear, also set the TERM variable to dump to
+      not have unexpected output on stderr at logout time.
+
  -- X2Go Release Manager <git-admin@x2go.org>  Tue, 28 Jul 2015 06:05:27 +0200
 
 x2goclient (4.0.5.0-0x2go1) unstable; urgency=low

Send a report that this bug log contains spam.