#872 - Turn xinerama.conf file related code inside X2Go Client into legacy code (for NX agents << 3.6)

X2Go Bug report logs - #872
Turn xinerama.conf file related code inside X2Go Client into legacy code (for NX agents << 3.6)

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Fri, 15 May 2015 12:00:01 UTC

Severity: important

Found in version 4.0.4.0

Received: (at 872) by bugs.x2go.org; 19 May 2015 08:59:28 +0000
From mike.gabriel@das-netzwerkteam.de  Tue May 19 10:59:26 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EDEE45DA83
	for <872@bugs.x2go.org>; Tue, 19 May 2015 10:59:25 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 6EA913DC7;
	Tue, 19 May 2015 10:59:25 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 1359D3BCF5;
	Tue, 19 May 2015 10:59:25 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id GQXVb2M9LWaY; Tue, 19 May 2015 10:59:24 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id A20B73BA08;
	Tue, 19 May 2015 10:59:24 +0200 (CEST)
Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de
 [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Tue, 19 May 2015 08:59:24 +0000
Date: Tue, 19 May 2015 08:59:24 +0000
Message-ID: <20150519085924.Horde.jBEwyYwTdmSksyJml9XJ-w1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>, 872@bugs.x2go.org, Ulrich
 Sibiller <uli42@gmx.de>
Subject: Re: [X2Go-Dev] Bug#872: Bug#872: Bug#872: Turn xinerama.conf file
 related code inside X2Go Client into legacy code (for NX agents << 3.6)
References: <20150515115912.Horde.GtfqM24QvRXo7Sd2CZWsHw1@mail.das-netzwerkteam.de>
 <55583925.1040206@phoca-gmbh.de>
 <20150518084055.Horde.mlraxHD7gXZTq0IPaU98Eg1@mail.das-netzwerkteam.de>
 <5559AF7A.9070803@phoca-gmbh.de>
 <CANVnVYJOtianqJR3jOx2TTne0-0xcg4AN7FcLYxQ0V0iMM1cqg@mail.gmail.com>
 <5559EBF8.5090900@phoca-gmbh.de>
 <CANVnVY+DLhZuxtFDEwyUrAtaLLYV1+UkxejjpFeBint1GJ-69A@mail.gmail.com>
 <555AEFD2.2020807@phoca-gmbh.de>
In-Reply-To: <555AEFD2.2020807@phoca-gmbh.de>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 178.62.101.154
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_S6WXj0Rc05YlA79D0VNHtw1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

Hi Alex, On Di 19 Mai 2015 10:09:54 CEST, Oleksandr Shneyder wrote: > Am 18.05.2015 um 21:01 schrieb Ulrich Sibiller: >> On Mon, May 18, 2015 at 3:41 PM, Oleksandr Shneyder >> <o.shneyder@phoca-gmbh.de> wrote: >>> yes, if you moving window between two physical displays, without >>> resizing it, x2goagent doesn't know, that display configuration is >>> changed, because geometry of the x2goagent stays same. So I resized a >>> window to refresh a display configurations. >> >> Why does nxagent/x2goagent need know about that? In the current >> solution with xinerama.conf I don't see why x2goagent should be >> informed in this case. And if it really needs to know, this patch >> _should_ help (I have not tested this patch alone): >> >> https://github.com/uli42/nx-libs/commit/61018cd39d02fbda1f2f766d8320c53866fa55d3 >> >> Uli >> > Imagine that you have agent window in the middle of two screens. Window > size is 1024x768. You current displays configuration in that case is: > left-512x768, right-512x768. Imagine, that you moved your window 100 px > left. Now your displays configuration is: left-612x768, right-412x768. > But from the view of x2goagent nothing is changed, agent has no idea > about the display geometry on the client side. This is why client > updating xinerama.conf and resizing a window to apply new settings. I > hope it's understandable. This is exactly what Ulrich is working on [1]. In the first test builds with his patches, the nxagent window adapts the Xinerama layout inside the nxagent whenever nxagent is moved over the client-side screen area. Especially check the changes in hw/nxagent/Screen.c, and there the intersect() function. With Ulrich's patches, nxagent has Xinerama support without being in need of a xinerama.conf file. I tested that with Python X2Go (i.e., via nxproxy) and via command line session startups (i.e., all on the same host). There are still some kinks we observe with several window managers, but I am pretty sure that those issues need to be fixed in the window managers (esp. MATE's window manager and also openbox). Mike https://github.com/ArcticaProject/nx-libs/pull/23/files -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:15:12 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #872 Turn xinerama.conf file related code inside X2Go Client into legacy code (for NX agents << 3.6)

X2Go Bug report logs - #872
Turn xinerama.conf file related code inside X2Go Client into legacy code (for NX agents << 3.6)