X2Go Bug report logs - #872
Turn xinerama.conf file related code inside X2Go Client into legacy code (for NX agents << 3.6)

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Fri, 15 May 2015 12:00:01 UTC

Severity: important

Found in version 4.0.4.0

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#872: [X2Go-Dev] Bug#872: Bug#872: Bug#872: Turn xinerama.conf file related code inside X2Go Client into legacy code (for NX agents << 3.6)
Reply-To: Ulrich Sibiller <uli42@gmx.de>, 872@bugs.x2go.org
Resent-From: Ulrich Sibiller <uli42@gmx.de>
Original-Sender: ulrich.sibiller@gmail.com
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 19 May 2015 08:55:02 +0000
Resent-Message-ID: <handler.872.B872.143202544416977@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 872
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 872-submit@bugs.x2go.org id=B872.143202544416977
          (code B ref 872); Tue, 19 May 2015 08:55:02 +0000
Received: (at 872) by bugs.x2go.org; 19 May 2015 08:50:44 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
	T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-la0-f52.google.com (mail-la0-f52.google.com [209.85.215.52])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 46C095DA83
	for <872@bugs.x2go.org>; Tue, 19 May 2015 10:50:42 +0200 (CEST)
Received: by lagr1 with SMTP id r1so12676643lag.0
        for <872@bugs.x2go.org>; Tue, 19 May 2015 01:50:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:content-type;
        bh=wkSFUL+uCd/lDlYcYCwO7kdq6LD084RxkTj1IKAtG0E=;
        b=Wz+ND5BDDMha/LLpxcjss9IHKswc1hRzBZX8DA8VBysdmQKzn/uanf0/y/xwXueu9i
         3GH9wUQQg8bdaulahnNv9ncqjst+DIQPPieh3mPLZRSQ2X8vbJ862YRUeyPXKSWZwm1t
         ItZZIvuLEhs2aYGMhFCTizbBbna7611aRZ2tltmtojxDTWv3rK0JlMqInd6cXUf6fehM
         VY5N4gTYut51usQ6Q7PGUEk52TaB/obSl88VkeGhkU3VKz4954bt5ry5TcGz8So3DfAf
         zZY5Egpy/WGtB8TCsF6qWJfSekXYF5VuU57px9w0ejCISRSGRfsVDSjmCP1BBQ2sTQIu
         pbOQ==
X-Received: by 10.112.219.201 with SMTP id pq9mr20659950lbc.109.1432025441406;
 Tue, 19 May 2015 01:50:41 -0700 (PDT)
MIME-Version: 1.0
Sender: ulrich.sibiller@gmail.com
Received: by 10.112.11.201 with HTTP; Tue, 19 May 2015 01:50:20 -0700 (PDT)
In-Reply-To: <555AEFD2.2020807@phoca-gmbh.de>
References: <20150515115912.Horde.GtfqM24QvRXo7Sd2CZWsHw1@mail.das-netzwerkteam.de>
 <55583925.1040206@phoca-gmbh.de> <20150518084055.Horde.mlraxHD7gXZTq0IPaU98Eg1@mail.das-netzwerkteam.de>
 <5559AF7A.9070803@phoca-gmbh.de> <CANVnVYJOtianqJR3jOx2TTne0-0xcg4AN7FcLYxQ0V0iMM1cqg@mail.gmail.com>
 <5559EBF8.5090900@phoca-gmbh.de> <CANVnVY+DLhZuxtFDEwyUrAtaLLYV1+UkxejjpFeBint1GJ-69A@mail.gmail.com>
 <555AEFD2.2020807@phoca-gmbh.de>
From: Ulrich Sibiller <uli42@gmx.de>
Date: Tue, 19 May 2015 10:50:20 +0200
X-Google-Sender-Auth: XApulHs_FfRg5tDF26tPjwxvE4k
Message-ID: <CANVnVYJkOWBG3em2LFDbbBkKR4n_DuHmFLVnUS577ySSBPTLRw@mail.gmail.com>
To: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>, 872 <872@bugs.x2go.org>
Content-Type: text/plain; charset=UTF-8

On Tue, May 19, 2015 at 10:09 AM, Oleksandr Shneyder
<o.shneyder@phoca-gmbh.de> wrote:
> Imagine that you have agent window in the middle of two screens. Window
> size is 1024x768. You current displays configuration in that case is:
> left-512x768, right-512x768. Imagine, that you moved your window 100 px
> left. Now your displays configuration is: left-612x768, right-412x768.
> But from the view of x2goagent nothing is changed, agent has no idea
> about the display geometry on the client side. This is why client
> updating xinerama.conf and resizing a window to apply new settings. I
> hope it's understandable.


Yes, it is understandable. But this only relevant for xinerama
information. And that information is coming from the config file
(which is correctly updated in this case by x2goclient). So I still do
not see why x2goagent needs to be triggered in any way. If a software
needs to know the xinerama setup it issues a XineramaQueryScreens()
request. This is intercepted by the libNX_xinerama.so and answered
with the information from the config file. The x2goagent does not even
see this request and thus does noot need to be updated. The only
problem that your code solves might be the window manager in the
session that caches xinerama information.

Do you have a use case that does not work without the resize?

Uli

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:39:25 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.