X2Go Bug report logs - #855
x2goclient deletes important files that it should leave untouched

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Sun, 26 Apr 2015 14:00:02 UTC

Severity: grave

Found in version 4.1.0.0

Full log

Message #10 received at 855@bugs.x2go.org (full text, mbox, reply):

Received: (at 855) by bugs.x2go.org; 19 Feb 2018 12:57:15 +0000
From X2Go-ML-1@baur-itcs.de  Mon Feb 19 13:57:13 2018
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_05,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4544F5DAEA
	for <855@bugs.x2go.org>; Mon, 19 Feb 2018 13:57:13 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id IlrAC9cogPWH for <855@bugs.x2go.org>;
	Mon, 19 Feb 2018 13:57:08 +0100 (CET)
X-Greylist: delayed 452 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Mon, 19 Feb 2018 13:57:08 CET
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 134185DAC9
	for <855@bugs.x2go.org>; Mon, 19 Feb 2018 13:57:08 +0100 (CET)
Received: from [192.168.0.15] ([134.3.37.90]) by mrelayeu.kundenserver.de
 (mreue104 [212.227.15.145]) with ESMTPSA (Nemesis) id
 0M9GoA-1euwKz1yog-00ClM7 for <855@bugs.x2go.org>; Mon, 19 Feb 2018 13:44:35
 +0100
From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
To: 855@bugs.x2go.org
Subject: Update on file deletion issue in portable mode
Message-ID: <b6620a0c-e52f-011c-c449-00977cb4314e@baur-itcs.de>
Date: Mon, 19 Feb 2018 13:44:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="vNQGoYvFrkT8WwIlmVFG6cDZ5yUrmm4Uo"
X-Provags-ID: V03:K0:lIC5zD/xEUvNaXPJyJOskz9eu2TuF0Ob39V57NLgF/qgZjo2lJS
 WGtsm1RdnwMoPZA+y44D/sT18dJ7pvQK2vpxIFBtHTPhe63oL75GoFOLeXTZk5szeFgNqAk
 5AOyPu9nc9IrOdmbkHlaWoD04/+pBpChBCqG5kR9YqlA47vlXITs0hhw0iaR8DqbpsaC2ss
 Q1TTu9YH+rpguchGtBemA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:pXrUkSi2omg=:DJdf08oedT25wiG1QoSu82
 X7k5FsnQkUmIDpwSYf75adlcletAZ5e3UAlZd0TkrwdJPopWJPd9S+SxNb6KkB8I2k9q/dNlE
 8MZ32Tksk7mpEq0UpjxG7sPYkop1+nvoRutKp9vV0L3EGKg0rh9BBKDsmfBsL9GGeCXhz3/NF
 ly4JabQg0p6mvc/lG713VDiNfOXnmJVU+sPErma42tFSEkuMT+B7/tArbMI7vilT+nsmuZrpV
 ICGVmbzeiUBil6+d+Y57EvrvCpqn/QZfEAyTaZzJbzZewLUg01VXgbJqVjuXk3QcrRTchH/+5
 9wR2WDc+kQmzpeGc6dCwoNspD6SacItRfpPaDrxNNP4+k0v8rW1+v4jZRF5RXa07g6uPzRG+/
 zuNxnqXhoEJwMkINM7kAn81Bexyb0Vhb1hX0LzvF5aEwqTSwSVMqLLS8M9Q4uDVrb1Z2FqiFk
 ctfjyS1q1IoGnkDbBLTpN4NY42pDeL3bmc5S2zOott/kRQPnUe0Tyn/weIoR1XZA/ZXofNGu4
 gr8zB3MoDuCNcIt/G+bSXWgwfDKjZvyQJjHh62SGgcEsGdIBvsyBnyNGDowplfoCci9GuyHJn
 cixbwm68OKgwwvTr9nKswc9R/jFfusjgrkA9Je67q+AAmyeMIEfu9EIVZ4KSNF8No+tDKOmcg
 FdUDE7MiK2mOdFlqFsgKix/ghfVRwa6NyVbTkZ1H7xuoXx+US0wKQNBuFn6P9XZgzbKm2OllI
 IVsXhsGJw4bMTTXOsIGo8JX78e/onZx5R1vOpg==

[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.1.0.0
Severity: grave

When you install X2GoClient on Windows in portable mode, in the
directory some_dir\x2goclient, and create a batch file to start it in
porable mode as some_dir\x2goclient.cmd, with the following content:

@echo off
cd /d %~dp0\x2goclient
start "X2GoClient" x2goclient.exe --portable

Then, either upon connecting to a server (causing ssh\known_hosts to be
created/updated), or upon closing of x2goclient, the content of these
directories gets deleted (save for the file ssh\known_hosts):

some_dir\x2goclient\.ssh
some_dir\x2goclient\ssh

Obviously, this is NOT good, because people will be tempted to store
their private keys in that directory, only to find them gone afterwards.

My guess is that it hits .ssh as well because .ssh is no regular FAT
file name, but rather one that can only be created in cmd.exe with "md
.ssh", and probably only works on VFAT, not regular FAT, so a routine
looking to match ssh that isn't VFAT-safe will hit .ssh instead.

Could it be that we have a bug in x2goclient that purges the ssh
directory whenever known_hosts is accessed for writing, or similar?

Kind Regards,
Stefan Baur

-- 
BAUR-ITCS UG (haftungsbeschränkt)
Geschäftsführer: Stefan Baur
Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:13:05 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.