X2Go Bug report logs - #84
DESTDIR and OPTFLAGS patches for nx-libs

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Wed, 12 Dec 2012 12:03:38 UTC

Severity: normal

Forwarded to https://github.com/ArcticaProject/nx-libs/issues/141

Full log


View this message in rfc822 format

X-Loop: git-admin@x2go.org
Subject: Bug#84: Hardcoded -O3 in CFLAGS
Reply-To: Jan Engelhardt <jengelh@inai.de>, 84@bugs.x2go.org
Resent-From: Jan Engelhardt <jengelh@inai.de>
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: git-admin@x2go.org
Resent-Date: Wed, 09 Jan 2013 14:33:02 +0000
Resent-Message-ID: <handler.84.B84.1357741566579@bugs.x2go.org>
Resent-Sender: git-admin@x2go.org
X-X2Go-PR-Message: followup 84
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: 
Received: via spool by 84-submit@bugs.x2go.org id=B84.1357741566579
          (code B ref 84); Wed, 09 Jan 2013 14:33:02 +0000
Received: (at 84) by bugs.x2go.org; 9 Jan 2013 14:26:06 +0000
Received: from ares07.inai.de (ares07.inai.de [5.9.24.206])
	by ymir (Postfix) with ESMTPS id 58ABB5DB0A
	for <84@bugs.x2go.org>; Wed,  9 Jan 2013 15:26:06 +0100 (CET)
Received: by ares07.inai.de (Postfix, from userid 25121)
	id 3548096A06B1; Wed,  9 Jan 2013 15:26:06 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by ares07.inai.de (Postfix) with ESMTP id 0E83496A068E;
	Wed,  9 Jan 2013 15:26:06 +0100 (CET)
Date: Wed, 9 Jan 2013 15:26:06 +0100 (CET)
From: Jan Engelhardt <jengelh@inai.de>
To: Reinhard Tartler <siretart@gmail.com>
cc: 84@bugs.x2go.org, Bernard Cafarelli <voyageur@gentoo.org>
In-Reply-To: <CAJ0cceZ8_Cssbx0dYZnFnjOf87ULFv9L7Oyzj8owKjQgY0s_4Q@mail.gmail.com>
Message-ID: <alpine.LNX.2.01.1301091524210.30785@nerf07.vanv.qr>
References: <ef1f449976cebc4b8ddb052befd9c231@cafarelli.fr> <alpine.LNX.2.01.1301081706500.14229@nerf07.vanv.qr> <20130109010011.4f92023b@enterprise.cafarelli.fr> <alpine.LNX.2.01.1301091514470.30600@nerf07.vanv.qr>
 <CAJ0cceZ8_Cssbx0dYZnFnjOf87ULFv9L7Oyzj8owKjQgY0s_4Q@mail.gmail.com>
User-Agent: Alpine 2.01 (LNX 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Wednesday 2013-01-09 15:21, Reinhard Tartler wrote:
>> +++ nx-libs-3.5.0.17/nxcomp/Makefile.in
>> @@ -36,8 +36,7 @@ LIBVERSION=@LIBVERSION@
>>  #
>>
>>  CXX         = @CXX@
>> -CXXFLAGS    = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
>> -              -Wall -Wpointer-arith
>> +CXXFLAGS    = @X_CFLAGS@ @DEFS@ -Wall -Wpointer-arith @CXXFLAGS@
>>  CXXINCLUDES =
>>  CXXDEFINES  =
>>
>AFAIUI, this is not a fix. Instead of replacing the hardcoded values,
>this patch ensures that all options end behind the hardcoded values.
>This makes it impossible to drop compiler flags that are specified
>within.
>
>This may be fair when your goal is to only change the optimization
>level, but may be insufficient when the goal is a hardened build.

I don't care about the "hardened" because that is just another case
of "user wants to specify his own CFLAGS".
I had hoped that @CXXFLAGS@ would be those user-specific ones,
but alas, no.
*Total dismay at Makefile authors who still squat on CXXFLAGS*

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Mon May 20 20:40:35 2019; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.