From unknown Thu Mar 28 18:25:26 2024 X-Loop: git-admin@x2go.org Subject: Bug#84: Hardcoded -O3 in CFLAGS Reply-To: Jan Engelhardt , 84@bugs.x2go.org Resent-From: Jan Engelhardt Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: git-admin@x2go.org Resent-Date: Wed, 09 Jan 2013 14:33:02 +0000 Resent-Message-ID: Resent-Sender: git-admin@x2go.org X-X2Go-PR-Message: followup 84 X-X2Go-PR-Package: nx-libs X-X2Go-PR-Keywords: Received: via spool by 84-submit@bugs.x2go.org id=B84.1357741566579 (code B ref 84); Wed, 09 Jan 2013 14:33:02 +0000 Received: (at 84) by bugs.x2go.org; 9 Jan 2013 14:26:06 +0000 Received: from ares07.inai.de (ares07.inai.de [5.9.24.206]) by ymir (Postfix) with ESMTPS id 58ABB5DB0A for <84@bugs.x2go.org>; Wed, 9 Jan 2013 15:26:06 +0100 (CET) Received: by ares07.inai.de (Postfix, from userid 25121) id 3548096A06B1; Wed, 9 Jan 2013 15:26:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ares07.inai.de (Postfix) with ESMTP id 0E83496A068E; Wed, 9 Jan 2013 15:26:06 +0100 (CET) Date: Wed, 9 Jan 2013 15:26:06 +0100 (CET) From: Jan Engelhardt To: Reinhard Tartler cc: 84@bugs.x2go.org, Bernard Cafarelli In-Reply-To: Message-ID: References: <20130109010011.4f92023b@enterprise.cafarelli.fr> User-Agent: Alpine 2.01 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Wednesday 2013-01-09 15:21, Reinhard Tartler wrote: >> +++ nx-libs-3.5.0.17/nxcomp/Makefile.in >> @@ -36,8 +36,7 @@ LIBVERSION=@LIBVERSION@ >> # >> >> CXX = @CXX@ >> -CXXFLAGS = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \ >> - -Wall -Wpointer-arith >> +CXXFLAGS = @X_CFLAGS@ @DEFS@ -Wall -Wpointer-arith @CXXFLAGS@ >> CXXINCLUDES = >> CXXDEFINES = >> >AFAIUI, this is not a fix. Instead of replacing the hardcoded values, >this patch ensures that all options end behind the hardcoded values. >This makes it impossible to drop compiler flags that are specified >within. > >This may be fair when your goal is to only change the optimization >level, but may be insufficient when the goal is a hardened build. I don't care about the "hardened" because that is just another case of "user wants to specify his own CFLAGS". I had hoped that @CXXFLAGS@ would be those user-specific ones, but alas, no. *Total dismay at Makefile authors who still squat on CXXFLAGS*