X2Go Bug report logs - #836
defaults.py X2GOBROKER_SESSIONPROFILE_DEFAULTS height/width/fullscreen values prevents client from setting initial geometry on startup

Full log

Message #15 received at 836@bugs.x2go.org (full text, mbox, reply):

Received: (at 836) by bugs.x2go.org; 7 Apr 2015 20:11:21 +0000
From alavaliant@ra09.com  Tue Apr  7 22:11:18 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
X-Greylist: delayed 2690 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Tue, 07 Apr 2015 22:11:17 CEST
Received: from thetower.ra09.com (ra09.com [202.124.104.240])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 27E505DAD6
	for <836@bugs.x2go.org>; Tue,  7 Apr 2015 22:11:16 +0200 (CEST)
Received: from grigorig.ra09.com ([10.1.1.8])
	by thetower.ra09.com with esmtp (Exim 4.80)
	(envelope-from <alavaliant@ra09.com>)
	id 1YfZ8e-0004rp-Ui; Wed, 08 Apr 2015 07:26:21 +1200
Message-ID: <55242F81.5030205@ra09.com>
Date: Wed, 08 Apr 2015 07:26:57 +1200
From: Jason Alavaliant <alavaliant@ra09.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 836@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#836: defaults.py X2GOBROKER_SESSIONPROFILE_DEFAULTS
 height/width/fullscreen values prevents client from setting initial geometry
 on startup
References: <20150406203527.Horde.hmGer9Igu5FvYHv8MHGCFw1@mail.das-netzwerkteam.de>
In-Reply-To: <20150406203527.Horde.hmGer9Igu5FvYHv8MHGCFw1@mail.das-netzwerkteam.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

On 07/04/15 08:35, Mike Gabriel wrote:
> Hi Jason,
>
> thanks for your feedback on the broker.
>
> On  Sa 04 Apr 2015 11:01:27 CEST, Jason Alavaliant wrote:
>
>> Package: python-x2gobroker
>> Version: 0.0.3.0
>>
>> In the same vein as the dpi issue noted in bug #834 the presence of 
>> default values for height, width and fullscreen in the 
>> /usr/lib/python2.7/dist-packages/x2gobroker/defaults.py   file under 
>> theX2GOBROKER_SESSIONPROFILE_DEFAULTS    section prevent the 
>> x2goclient --geometry option being used to set what default geometry 
>> size (or if to use fullscreen) to be set by the client even if the 
>> admin of the x2gobroker setup hasn't defined those values in the 
>> x2gobroker-sessionprofiles.conf file.
>>
>> I'd suggest updating the 
>> /usr/lib/python2.7/dist-packages/x2gobroker/defaults.py file to 
>> remove the lines
>> "u'height': 600,"
>> "u'fullscreen': False,"
>> "u'width': 800,"
>> from the X2GOBROKER_SESSIONPROFILE_DEFAULTS section.
>>
>> In my testing with those default value gone;
>>
>> * If a height/width/fullscreen values are set in 
>> x2gobroker-sessionprofiles.conf (which is the default provided in the 
>> sample config file), then those values are used by the session 
>> overriding whatever the client has set as it's geometry option.
>> * If the values aren't set in x2gobroker-sessionprofiles.conf and a 
>> --geometry command line argument ISN'T provided to the client then 
>> the x2goclient defaults of height=600, width=800, fullscreen=False 
>> are used resulting in the same behaviour as if the defaults 
>> previously defined in defaults.py were still present.
>> *  If the values aren't set in x2gobroker-sessionprofiles.conf and a 
>> --geometry command line argument IS provided to the client it is then 
>> used and the user running the x2goclient can pick their own initial 
>> geometry to start with.
>>
>> So in default cases having that default value removed shouldn't 
>> change behavior and it would allow people to configure their starting 
>> geometry if the x2gobroker admin has permitted it by not providing 
>> overriding values in the x2gobroker-sessionprofiles.conf file.
>
> The issue goes deeper, I guess.
>
> When fixing #834 [1] I did not take into account, that the session 
> profile default values defined in defaults.py also have another 
> context. The X2GOBROKER_SESSIONPROFILE_DEFAULTS dict also implicitly 
> provides information about the type for each value (int, str, bool).
>
> So simply commenting them out is not a solution.
>
> Furthermore, my idea is to provide a special value in 
> x2gobroker-sessionprofiles.conf, i.e.,
>
>   fullscreen=not-set
>   dpi=not-set
>
> etc.
>
> If the admin uses those option for configuration, the broker will 
> simply hide those session profile options when handing the session 
> profile over to the client.
>
> What do you think of that alternative approach?
>
> Mike
>
> [1] http://bugs.x2go.org/834
Your alternative approach of providing a special not-set value to be 
used in the x2gobroker-sessionprofiles.conf sounds like it should work fine.

Thanks
Jason

Send a report that this bug log contains spam.